diff options
| author | Amit Shekhar <ashekhar@codeaurora.org> | 2018-06-20 17:36:23 -0700 |
|---|---|---|
| committer | Chong Zhang <chz@google.com> | 2018-07-16 17:55:18 +0000 |
| commit | deb7e33ac65e8a0e0749e657d0586d170e751c3b (patch) | |
| tree | 94c416fd62484d25e36c1625a1925c5cdfe9937b /mm-video-v4l2 | |
| parent | 98f4c5a93e3d56721e2cbe9721717e2cfd4db1a7 (diff) | |
| download | media-deb7e33ac65e8a0e0749e657d0586d170e751c3b.tar.gz | |
media: Fix order of setting bitrate and rate ctrl paramspie-dr1-dev
Setting frame quality factor depends on CQ rate control, hence,
rate control needs to be set earlier.
Fix order of setting bitrate and rate ctrl params.
Change-Id: Id5e52e5b4fbc847f911a1c3e3460c78db90c49b9
CRs-Fixed: 2264722
Bug: 110283731
(cherry picked from commit 930afd7644c8ee73326ec8970a3a7c02c4b97a34)
Diffstat (limited to 'mm-video-v4l2')
| -rw-r--r-- | mm-video-v4l2/vidc/venc/src/video_encoder_device_v4l2.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/mm-video-v4l2/vidc/venc/src/video_encoder_device_v4l2.cpp b/mm-video-v4l2/vidc/venc/src/video_encoder_device_v4l2.cpp index 4db6d0ea..36d5baa7 100644 --- a/mm-video-v4l2/vidc/venc/src/video_encoder_device_v4l2.cpp +++ b/mm-video-v4l2/vidc/venc/src/video_encoder_device_v4l2.cpp @@ -2115,13 +2115,13 @@ bool venc_dev::venc_set_param(void *paramData, OMX_INDEXTYPE index) DEBUG_PRINT_LOW("venc_set_param: OMX_IndexParamVideoBitrate"); if (pParam->nPortIndex == (OMX_U32) PORT_INDEX_OUT) { - if (!venc_set_target_bitrate(pParam->nTargetBitrate)) { - DEBUG_PRINT_ERROR("ERROR: Setting Target Bit Rate / Quality Factor failed"); + if (!venc_set_ratectrl_cfg(pParam->eControlRate)) { + DEBUG_PRINT_ERROR("ERROR: Rate Control setting failed"); return false; } - if (!venc_set_ratectrl_cfg(pParam->eControlRate)) { - DEBUG_PRINT_ERROR("ERROR: Rate Control setting failed"); + if (!venc_set_target_bitrate(pParam->nTargetBitrate)) { + DEBUG_PRINT_ERROR("ERROR: Setting Target Bit Rate / Quality Factor failed"); return false; } } else { |