diff options
| author | Michael Adisumarta <madisuma@codeaurora.org> | 2020-04-24 17:51:07 -0700 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2020-09-17 13:45:43 -0700 |
| commit | c307e93baf3021307a331f436dc8517542d204ae (patch) | |
| tree | 16f9a69b7e8956a6b5b8ca2b0ee656eb992f9805 | |
| parent | a727d543f0e16c7bd4fe019970782b1bc58dc7e8 (diff) | |
| download | ipacfg-mgr-c307e93baf3021307a331f436dc8517542d204ae.tar.gz | |
ipacm: Print flt rules that fail mdfy_flt_rule
Move the individual flt rule status check outside the
IOCTl fail check to seperate the rules that failed when
IPACM sends more than one rule.
Change-Id: I4a2c51374bbedced687e23041104a1bc33627c55
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
| -rw-r--r-- | ipacm/src/IPACM_Filtering.cpp | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/ipacm/src/IPACM_Filtering.cpp b/ipacm/src/IPACM_Filtering.cpp index b230c36..875a794 100644 --- a/ipacm/src/IPACM_Filtering.cpp +++ b/ipacm/src/IPACM_Filtering.cpp @@ -1006,17 +1006,18 @@ bool IPACM_Filtering::ModifyFilteringRule(struct ipa_ioc_mdfy_flt_rule* ruleTabl } ret = ioctl(fd, IPA_IOC_MDFY_FLT_RULE, ruleTable); - if (ret != 0) - { - IPACMERR("Failed modifying filtering rule %pK\n", ruleTable); - for (i = 0; i < ruleTable->num_rules; i++) + for (i = 0; i < ruleTable->num_rules; i++) + { + if (ruleTable->rules[i].status != 0) { - if (ruleTable->rules[i].status != 0) - { - IPACMERR("Modifying filter rule %d failed\n", i); - } + IPACMERR("Modifying filter rule %d failed\n", i); } + } + + if (ret != 0) + { + IPACMERR("Failed modifying filtering rule IOCTL for %pK\n", ruleTable); return false; } |