summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorDante Russo <drusso@codeaurora.org>2019-05-15 15:08:30 -0700
committerDante Russo <drusso@codeaurora.org>2019-05-15 15:09:39 -0700
commit61b7ed6bf0718c2b4a93350f130e8b13f980c823 (patch)
treee4624b234f15f2f16476fe9bec02d98e42a9cff1 /core
parent4d6bb2da93570f07d874e2a76519518c6d4b163f (diff)
downloadgps-61b7ed6bf0718c2b4a93350f130e8b13f980c823.tar.gz
Fix few ASAN issues reported
- Fix a Use After Free issue in Gnss Update Config If Engine Capabilities are not known yet at the time of the MsgGnssUpdateConfig, the ids arrray will be freed but the ids pointer will be copied into a new MsgGnssUpdateConfig that will access the ids array again - Issue in NetworkInfoDataItemBase which will result in array out of bound access which might result in heap buffer overflow. Change-Id: Ib5a6dc29fef9eb6676d4605f92d60f26a47d1d90 CRs-fixed: 2449980
Diffstat (limited to 'core')
-rw-r--r--core/data-items/DataItemConcreteTypesBase.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/data-items/DataItemConcreteTypesBase.h b/core/data-items/DataItemConcreteTypesBase.h
index 552d46a..a6e68f1 100644
--- a/core/data-items/DataItemConcreteTypesBase.h
+++ b/core/data-items/DataItemConcreteTypesBase.h
@@ -249,7 +249,7 @@ public:
mId(NETWORKINFO_DATA_ITEM_ID) {
memset (&mAllNetworkHandles, NETWORK_HANDLE_UNKNOWN,
sizeof (mAllNetworkHandles));
- mAllNetworkHandles[type] = networkHandle;
+ mAllNetworkHandles[initialType] = networkHandle;
}
virtual ~NetworkInfoDataItemBase() {}
inline virtual DataItemId getId() { return mId; }