diff options
| author | Srinivas Dasari <dasaris@codeaurora.org> | 2015-09-21 14:34:51 +0530 |
|---|---|---|
| committer | Srinivas Dasari <dasaris@codeaurora.org> | 2016-01-20 16:14:31 +0530 |
| commit | c19f715ece840e705749d2dfd1857210d7e31897 (patch) | |
| tree | c279d29eb5e7d0b08586eb8ef379d0a36d0f39d6 /qcwcn/wifi_hal/cpp_bindings.cpp | |
| parent | a3c2c8f1bfcddd50047c8ad29e535a54e99acf62 (diff) | |
| download | wlan-c19f715ece840e705749d2dfd1857210d7e31897.tar.gz | |
WiFi_HAL: Fix static analyzer findings
This commit fixes few issues found by static analyzer.
Change-Id: Ia22718b9545e1e56a784e28a1b2582cb489b8cc9
Diffstat (limited to 'qcwcn/wifi_hal/cpp_bindings.cpp')
| -rw-r--r-- | qcwcn/wifi_hal/cpp_bindings.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/qcwcn/wifi_hal/cpp_bindings.cpp b/qcwcn/wifi_hal/cpp_bindings.cpp index 381d8c8..dfc9258 100644 --- a/qcwcn/wifi_hal/cpp_bindings.cpp +++ b/qcwcn/wifi_hal/cpp_bindings.cpp @@ -631,6 +631,7 @@ int WifiCommand::requestResponse(WifiRequest& request) { } out: nl_cb_put(cb); + mMsg.destroy(); return err; } @@ -991,6 +992,11 @@ wifi_error WifiVendorCommand::get_mac_addr(struct nlattr **tb_vendor, return WIFI_ERROR_INVALID_ARGS; } + if (nla_len(tb_vendor[attribute]) != sizeof(mac_addr)) { + ALOGE("Invalid mac addr lenght\n"); + return WIFI_ERROR_INVALID_ARGS; + } + memcpy(addr, (u8 *)nla_data(tb_vendor[attribute]), nla_len(tb_vendor[attribute])); return WIFI_SUCCESS; |