summaryrefslogtreecommitdiff
path: root/qcwcn
diff options
context:
space:
mode:
authormukesh agrawal <quiche@google.com>2016-04-12 17:57:45 -0700
committermukesh agrawal <quiche@google.com>2016-04-14 11:33:01 -0700
commit93022ce448414130b4241c6920797c1dc1df2250 (patch)
tree2118f4bde526cc5c4d6680f4de8ed586375841d9 /qcwcn
parent813d900af4dd1b834008ea7ce26b944d9b9f4e89 (diff)
downloadwlan-93022ce448414130b4241c6920797c1dc1df2250.tar.gz
Wifi-HAL: reduce gscan log volume
When printing logs that depend on values in a list, concatenate the list items into a string. Then print the string as a single log message. Originally part of https://partner-android-review.googlesource.com/#/c/558740 BUG=27779612 TEST=compile Change-Id: I9402ff6f156193fc9c1c4086c617f1770332a2d0
Diffstat (limited to 'qcwcn')
-rw-r--r--qcwcn/wifi_hal/gscan.cpp17
-rw-r--r--qcwcn/wifi_hal/gscan_event_handler.cpp19
2 files changed, 24 insertions, 12 deletions
diff --git a/qcwcn/wifi_hal/gscan.cpp b/qcwcn/wifi_hal/gscan.cpp
index 44f46c1..cf22b7f 100644
--- a/qcwcn/wifi_hal/gscan.cpp
+++ b/qcwcn/wifi_hal/gscan.cpp
@@ -1470,16 +1470,15 @@ int GScanCommand::handleResponse(WifiEvent &reply) {
QCA_WLAN_VENDOR_ATTR_GSCAN_RESULTS_CHANNELS],
sizeof(wifi_channel) * (*mNumChannelsPtr));
}
-
- ALOGD("%s: Get valid channels response received.",
- __FUNCTION__);
- ALOGD("%s: Num channels : %d",
- __FUNCTION__, *mNumChannelsPtr);
- ALOGD("%s: List of valid channels are: ", __FUNCTION__);
- for(i = 0; i < *mNumChannelsPtr; i++)
- {
- ALOGD("%u", *(mChannels + i));
+ char buf[100];
+ size_t len = 0;
+ for (i = 0; i < *mNumChannelsPtr && len < sizeof(buf); i++) {
+ len += snprintf(buf + len, sizeof(buf)-len, "%u ",
+ *(mChannels + i));
}
+ ALOGV("%s: Num Channels %d: List of valid channels are: %s",
+ __FUNCTION__, *mNumChannelsPtr, buf);
+
}
break;
case QCA_NL80211_VENDOR_SUBCMD_GSCAN_GET_CAPABILITIES:
diff --git a/qcwcn/wifi_hal/gscan_event_handler.cpp b/qcwcn/wifi_hal/gscan_event_handler.cpp
index ba13664..a35a85b 100644
--- a/qcwcn/wifi_hal/gscan_event_handler.cpp
+++ b/qcwcn/wifi_hal/gscan_event_handler.cpp
@@ -360,6 +360,8 @@ static wifi_error gscan_get_significant_change_results(u32 num_results,
int j;
int rem = 0;
u32 len = 0;
+ char rssi_buf[1024]; //TODO: sizeof buf
+ int rem_size;
struct nlattr *scanResultsInfo;
for (scanResultsInfo = (struct nlattr *) nla_data(tb_vendor[
@@ -438,9 +440,20 @@ static wifi_error gscan_get_significant_change_results(u32 num_results,
QCA_WLAN_VENDOR_ATTR_GSCAN_RESULTS_SIGNIFICANT_CHANGE_RESULT_RSSI_LIST]
), results[i]->num_rssi * sizeof(wifi_rssi));
- for (j = 0; j < results[i]->num_rssi; j++)
- ALOGI(" significant_change_result: %d, rssi[%d]:%d, ",
- i, j, results[i]->rssi[j]);
+ ALOGV("significant_change_result:%d, BSSID:"
+ "%02x:%02x:%02x:%02x:%02x:%02x channel:%d num_rssi:%d ",
+ i, results[i]->bssid[0], results[i]->bssid[1], results[i]->bssid[2],
+ results[i]->bssid[3], results[i]->bssid[4], results[i]->bssid[5],
+ results[i]->channel, results[i]->num_rssi);
+
+ rem_size = sizeof(rssi_buf);
+ char *dst = rssi_buf;
+ for (j = 0; j < results[i]->num_rssi && rem_size > 0; j++) {
+ len = snprintf(dst, rem_size, "rssi[%d]:%d, ", j, results[i]->rssi[j]);
+ dst += len;
+ rem_size -= len;
+ }
+ ALOGV("RSSI LIST: %s", rssi_buf);
/* Increment loop index to prase next record. */
i++;