summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-26Merge "WIFIHAL: Fix use-after-free issue while freeing monitor socket list" ↵android-mainline-10.0.0_r9android-mainline-10.0.0_r7android-mainline-10.0.0_r5android-mainline-10.0.0_r4android-10.0.0_r36android-10.0.0_r35android-10.0.0_r34android-10.0.0_r33android-10.0.0_r32android-10.0.0_r31android-10.0.0_r30android10-qpr2-s4-releaseandroid10-qpr2-s3-releaseandroid10-qpr2-s2-releaseandroid10-qpr2-s1-releaseandroid10-qpr2-releaseandroid10-qpr1-mainline-releaseandroid10-mainline-media-releaseTreeHugger Robot
into qt-r1-dev
2019-06-13Wifi-Hal: Avoid accessing invalid memory while parsing pkt statsAjit Vaishya
Current implementation of packet stats parsing isn't validating remaining buflen, which might lead to accessing invalid memory location while parsing. To address this issue, we need to check whether received buflen is sufficient to parse the stat before reading the stats from nlmsg. While parsing pkt stats, the bufflen shall be decremented for all versions of packet log records. Add logic to decrement buflen for the missed versions also. Change-Id: I573a5158b97f2c2b1b59026a8ae14e23ffc8135f CRs-Fixed: 2422931 Bug: 130226017 Test: Manual Test, turn verbose logging and check pkt log
2019-06-13Wifi-hal: RX and Per packet fate stats for new pkt log version V2Ajit Vaishya
Current RX stats parsing structure differs with the recent architectures. Hence , the firmware / host indicates this need to parse the data with the updated structures through the version ( V2) and the parser is expected to adapt to the same. This commit introduces to parse pktlog stats based on PKT_LOG_V2 parsing structure and the rx rate calculation also differs based on this Version 2. Change-Id: Id0997296e93be15158cb9fd27b25067010227666 CRs-Fixed: 2402099 Bug: 130226017 Test: Manual Test, turn verbose logging and check pkt log
2019-06-13Wifi-hal: TX Per Packet stats for V2 version.Ajit Vaishya
Current TX per packet stats parsing logic cannot be used to parse TX stats for packet log new version V2, because of packet log structure format is different. This changes introduces to parse new packet log version V2, based on required OFFSET from received TX payload. Support to read packet log version i.e V1/V2/V3 by reading firmware version. Change-Id: Ie5c508bb2fd3e00674dd807c3003b00857d3f070 CRs-Fixed: 2402099 Bug: 130226017 Test: Manual Test, turn verbose logging and check pkt log
2019-06-10WIFIHAL: Fix use-after-free issue while freeing monitor socket listVinay Gannevaram
During cleanup of monitor socket list, entries are freed with out being deleted from the list. This results in accessing memory which was already freed. Hence deleting the entry before freeing it, so that list would have only valid entries. Bug: 133773150 Test: Manual Test CRs-Fixed: 2463143 Change-Id: Ic746c7527958f238c77ddd4fd6d98cb8abab67bb Signed-off-by: Vinay Gannevaram <quic_vganneva@quicinc.com>
2019-05-23WIFIHAL: Support to send nl requests through wifihalVinay Gannevaram
Added support in wifihal to send nl messages on behalf of its clients. Since netadmin capabilities are given to wifihal, it is used as bridge to send nl messages to kernel Added support for clients to register for nl events. CRs-Fixed: 2424237 Bug: 131618408 Bug: 28340421 Test: Regression test Change-Id: If8b62733e1d298804e0be98918eb875fc52a4ad1 Signed-off-by: Srinivas Girigowda <quic_sgirigow@quicinc.com>
2019-05-23wifi-hal: Map kernel error ENOBUFS to wifi-hal error codeRajeev Kumar
Kernel error ENOBUFS is not mapped to any defined wifi-hal error code. Map ENOBUFS error to WIFI_ERROR_TOO_MANY_REQUESTS wifi-hal error. Change-Id: I1d372a70a713a25505849da1a6716650007a7f64 CRs-Fixed: 2439902 Bug: 130214647 Bug: 132599519 Test: Regression Test Signed-off-by: Rajeev Kumar <quic_rajekuma@quicinc.com>
2019-04-30Merge "Wifi-hal: Enable pktlog when verbose log on." into qt-devandroid10-devTreeHugger Robot
2019-04-25Wifi-hal: Enable pktlog when verbose log on.lesl
In current desgin, packet fate will start logging when log level change to “VERBOSE_DEBUG_PROBLEM”. But in current design, no any use case will change log level to “VERBOSE_DEBUG_PROBLEM”. Framework use “VERBOSE_REPRO_PROBLEM” when user turn on wifi verbose logging in developer option. Modify pkt ring buffer check condition to VERBOSE_DEBUG_PROBLE to enable pktlog with verbose on. Bug:74360031 Test: Manual Test Change-Id: I0d600797108055adafcedd4ac7664b3781c3b74c
2019-04-19Wifi-Hal: Pass the address of the global variable to NL callbackAjit Vaishya
Current implementation passes the address of a local variable to the netlink control block callback, ending up to go out of scope if the callback is invoked after the scope for the current function ends (from where the registration happened), resulting in an invalid memory access. Address this issue by having the respective variable defined with a global scope. Change-Id: Ied10a8f17f20326864f80ac40b0ceac6791f6cd1 CRs-Fixed: 2427930 Bug: 129092516 Test: Manual test
2019-04-03Merge "SAR: Add handling of WIFI_POWER_SCENARIO_ON_BODY_BT"Ahmed ElArabawy
2019-04-02Wifi-Hal: Avoid infinite loop on pkt stats of V0 versionAjit Vaishya
Currently when hardware version received as NULL string, pkt_log sets to V0 version i.e. PKT_LOG_V0 and parsing of packet stats done by decrementing specified length mention in packet log header , in case of PKT_LOG_V0 this length is decrementing which makes parsing stuck to infinite loop. To overcome this, parsing length is decremented apart from V2 packet log version too. CRs-Fixed: 2422931 Bug: 129272032 Bug: 118484168 Test: Connect STA to AP and play youtube. Change-Id: I573a5158b97f2c2b1b59026a8ae14e23ffc8135f
2019-04-02Revert "Revert "Wifi-hal: RX and Per packet fate stats for new pkt log ↵Srinivas Girigowda
version V2"" This reverts commit 9584c413fae876e2883fc0e5a93a98df0f32d3ff. Bug: 129272032 Bug: 118484168 Test: connect STA to AP and play youtube. Change-Id: Id9396d04e6cd202867390dcb428a6177a8a89681
2019-04-02Revert "Revert "Wifi-hal: TX Per Packet stats for V2 version.""Srinivas Girigowda
This reverts commit 41d7798f68a93664a836c8b86c23addd3db9d17f. Bug: 129272032 Bug: 118484168 Test: Connect STA to AP and play youtube. Change-Id: If86b053c4e083cf1c01e7d7293d79706c6bb093e
2019-04-02Merge "Wifi: Add ether type to sending offloaded packet"Ahmed ElArabawy
2019-03-29SAR: Add handling of WIFI_POWER_SCENARIO_ON_BODY_BTAhmed ElArabawy
This commit adds support for the WIFI_POWER_SCENARIO_ON_BODY_BT SAR scenario, and map it to the proper BDF table. Bug: Test: adb shell halutil -sar enable 5 Change-Id: I3013815acb022f1d395c260ae16e29c4093346c9
2019-03-23Revert "Wifi-hal: TX Per Packet stats for V2 version."Sunil Ravi
Bug: 129148201 This reverts commit 181078ab828d12786c457037cda2fa61a50ab188. Reason for revert: Regression observed in 3P App Launch which increased by ~204ms Change-Id: I9dda376c45b528a867d4ca87266e60475d60a3ee
2019-03-23Revert "Wifi-hal: RX and Per packet fate stats for new pkt log version V2"Sunil Ravi
Bug: 129148201 This reverts commit dbac4bd447d0bc8323a1fec31406475036072095. Reason for revert: Regression observed in 3P App Launch which increased by ~204ms Change-Id: I71513fcaa4d3aa0dfdad51b1e4d2845479d500cd
2019-03-18Wifi: Add ether type to sending offloaded packetvamsi krishna
In current implementation, the ether type used for offloaded packets is always hardcoded to IPv4 in lower layers. This commit adds support to specify ether type of offloaded packets from user space. Bug: 122487582 Test: Manual Change-Id: Ib3a5dcb92aa6b193eabbcff32cd5a1138dcd04d0 CRs-Fixed: 2398213
2019-03-12Wifi-hal: RX and Per packet fate stats for new pkt log version V2Ajit Vaishya
Current Rx stats parsing structure which is different from new packet log version i.e V2, so parsed RX per packet stats are coming in improper format and per packet fate stats format also is diff w.r.t V2 pkt log version, which leads to improper offset on received payload while parsing it. This commit introduces to parse pktlog stats based on PKT_LOG_V2 parsing structure and V2 based rx rate calculatio. Bug: 118484168 Test: Regression Test Change-Id: Id0997296e93be15158cb9fd27b25067010227666 CRs-Fixed: 2402099
2019-03-12Wifi-hal: TX Per Packet stats for V2 version.Ajit Vaishya
Current TX per packet stats parsing logic cannot be used to parse TX stats for packet log new version V2, because of packet log structre format is different. This changes introduces to parse new packet log version V2, based on required OFFSET from received TX payload. Support to read packet log version i.e V1/V2/V3 by reading firmare version. Bug: 118484168 Test: Regression test Change-Id: Ie5c508bb2fd3e00674dd807c3003b00857d3f070 CRs-Fixed: 2402099
2019-03-06Merge "WiFi-HAL: Add user hint sub-type to set country code commmand"Ahmed ElArabawy
2019-02-24[automerger skipped] DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-masterXin Li
am: 4f8fa4bb22 -s ours am skip reason: subject contains skip directive Change-Id: I56aeed16e5a9d3f8fcf65979813aff444e6615a9
2019-02-20DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-masterXin Li
Bug: 120848293 Change-Id: I9a66d6bd93de8d149620a9453f774d5a377d2a82
2019-02-11wifi-hal: Add support handling NDPE attributePeng Xu
Add handling NDPE attribute in NAN capabilities. This allows the framework to enable or disable using of NDP attribute in NAN data request message. Bug: 113149569 Test: Manual Change-Id: If2ca515447fbd44bca3bc272ce5fd72718d7eb19 CRs-fixed: 2244053
2019-02-06WiFi-HAL: Add user hint sub-type to set country code commmandPeng Xu
Add new user hint sub-type NL80211_USER_REG_HINT_CELL_BASE to wifi_set_country_code command if the feature is supported by host driver. Bug: 121154896 Test: Regression test Change-Id: Ie1c0da1cc75aba02809ffd0f5d76bdb4f2ec680c CRs-fixed: 2205885
2019-02-01Merge "Wifi-Hal: Copy "ignoredBeaconFrames" param in DW/MAC stats"Ahmed ElArabawy
2019-01-28Wifi-Hal: Copy "ignoredBeaconFrames" param in DW/MAC statsRakesh Sunki
"ignoredBeaconFrames" param sent by the firmware not being copied to DE/MAC stats. Add fix to copy the param to the DW/MAC structures Bug: 121156967 Test: Regressin Test Change-Id: I49c2c85987a726ae4cda6faf23376b3b7b0ef87f CRs-Fixed: 2101126
2019-01-17Wifi-Hal: Support to trigger alert signal On DATA_STALL EVENTAjit Vaishya
On received EVENT_WLAN_STA_DATA_STALL Event support to send alert signal with data stall reason code to wifi framework. Bug: 121120734 Test: Regression CRs-Fixed: 2208413 Change-Id: Ie232b546dffdb6f62191700a6fa321d061a076a7
2019-01-17Wifi-HAL: Treat wake counter related stats from driver as optionalAmarnath Hullur Subramanyam
Earlier, all the attributes of wakestats were considered mandatory to be present from driver. This commit addresses that wake counter related stats to be treated as optional. If these attributes are not present in the message from driver then it is reported as zero instead of discarding the whole message. Bug: 121156966 Test: Regression CRs-Fixed: 2218700 Change-Id: I51137a5104537edae9529e2b6b62f5f07e10c67a
2019-01-17Wifi-HAL: Prevent using uninitialized data from mode_infomazumdar
Initialize mode_info with zeros so that we can prevent accessing and using uninitialized data from mode_info which might cause stability issues. Bug: 121156968 Test: Regression Testing Change-Id: I92d8647c5db39642c7c727dbcc65fd9875bce173 CRs-Fixed: 2243785
2019-01-17WiFi-HAL: Initialize "wifi_read_packet_filter" return typemazumdar
In earlier implementation of "wifi_read_packet_filter", there may arise a scenario where return "ret" remain uninitialized if "length" value passed to this function is zero and APF "enable/disable" functionality is carried out by the framework. Make changes, so that return "ret" is initialized at the time of its declaration and a check is added where "length" to be passed to this function is non-zero. Bug: 121109906 Test: Regression Test Change-Id: Ibc8bd164f086f8578b98b83eab3b2884188a4138 CRs-Fixed: 2263409
2019-01-16WiFi-Hal: Add support for Wi-Fi latency mode featureSrinivas Girigowda
Add support to set Wi-Fi latency mode in host driver using Wi-Fi HAL. Supported latency modes are NORMAL, MODERATE, LOW and ULTRA LOW. Bug: 118642535 Test: $ adb shell halutil -latency <mode (normal/low/ultra-low)> Change-Id: I4028c2c3c1a5950e9b6bd79f4f04766b8ce309c8
2019-01-16WiFi-Hal: Sync qca-vendor_copy.h to upstream qca-vendor.hSrinivas Dasari
Sync qca-vendor_copy.h to upstream qca-vendor.h and remove duplicate enums/defines from vendor_definitions.h Bug: 121155020 Test: Manual CRs-Fixed: 2290651 Change-Id: I44e1c955ff2e4b207063ce5d7b88bb2bb8fb4ed6
2018-10-24[automerger skipped] Merge pie-platform-release to aosp-master - DO NOT ↵Bill Yi
MERGE am: 136eb4d05f -s ours am: 3a45366b5e -s ours am: a3b3ceb87d -s ours Change-Id: Ib04ed6c3ee6e8952840fcfef0f98e42bed9faaa1
2018-10-24[automerger skipped] Merge pie-platform-release to aosp-master - DO NOT ↵Bill Yi
MERGE am: 136eb4d05f -s ours am: 3a45366b5e -s ours Change-Id: If362e43ecb117cd13cdec35200306bc656dbf758
2018-10-24[automerger skipped] Merge pie-platform-release to aosp-master - DO NOT MERGEBill Yi
am: 136eb4d05f -s ours Change-Id: I4b922947892aad51577abad276c07e408d0a98d6
2018-10-24Merge pie-platform-release to aosp-master - DO NOT MERGEandroid-wear-8.0.0_r2android-q-preview-6android-q-preview-5android-q-preview-4android-q-preview-2.5android-q-preview-1android-o-mr1-iot-release-smart-display-r9android-o-mr1-iot-release-smart-display-r8android-o-mr1-iot-release-smart-display-r5android-o-mr1-iot-release-smart-display-r40.1Jandroid-o-mr1-iot-release-smart-display-r4android-o-mr1-iot-release-smart-display-r39android-o-mr1-iot-release-smart-display-r30android-o-mr1-iot-release-smart-display-r22android-o-mr1-iot-release-smart-display-r14android-o-mr1-iot-release-smart-clock-r6android-o-mr1-iot-release-smart-clock-r2android-o-mr1-iot-release-smart-clock-fsiandroid-o-mr1-iot-release-smart-clock-fcsandroid-o-mr1-iot-release-cube_r2android-o-mr1-iot-release-cube-fsiandroid-o-mr1-iot-release-cube-fcsandroid-o-mr1-iot-release-1.0.8android-o-mr1-iot-release-1.0.7android-o-mr1-iot-release-1.0.10android-n-iot-release-ihome-igv1nougat-iot-releaseBill Yi
Change-Id: Ifffa0bf175eec813da063c0d951bbe9162757f7c
2018-10-24[automerger skipped] Merge pi-platform-release to stage-aosp-master - DO NOT ↵Bill Yi
MERGE am: 918cb5aaa8 -s ours am: 47ad011aa7 -s ours Change-Id: Ic5d6f0b1dfba98bf3c92cf0bb68b0a39a18cfd6b
2018-10-24[automerger skipped] Merge pi-platform-release to stage-aosp-master - DO NOT ↵Bill Yi
MERGE am: 918cb5aaa8 -s ours Change-Id: I10b3e5634b29a2395c04af677f9344ad2b3f95d0
2018-10-24Merge pi-platform-release to stage-aosp-master - DO NOT MERGEBill Yi
Change-Id: Iae64408aaa970b193021c8877d52b78477b3a197
2018-10-19Merge "Allow implicit-fallthrough warnings locally." am: f71546676c am: ↵Chih-Hung Hsieh
421c5642c9 am: 4e08ace081 Change-Id: I484828be8b58ab1e76d88a7cd42bec2832d0ac79
2018-10-19Merge "Allow implicit-fallthrough warnings locally." am: f71546676cChih-Hung Hsieh
am: 421c5642c9 Change-Id: I50680ea26a498557a12bd6f275fe5b04a0263b34
2018-10-19Merge "Allow implicit-fallthrough warnings locally."Chih-Hung Hsieh
am: f71546676c Change-Id: I612116de163b475acb229e3da13db15671128711
2018-10-19Merge "Allow implicit-fallthrough warnings locally."Treehugger Robot
2018-10-19Allow implicit-fallthrough warnings locally.Chih-Hung Hsieh
It will be a global error by default. Test: make checkbuild Bug: 112564944 Change-Id: Ie5b2a9a4d1f58080d7a3e83fbe80c0aa2798e13c Exempt-From-Owner-Approval: do not block on new warnings
2018-08-08Merge "Merge Android Pie into master" am: b6f04dece7 am: 8ea058dd44 am: ↵Xin Li
ba979c3265 am: 5fcb05e422 Change-Id: Iecf12680f6aa85412894419855879af50f502aee
2018-08-07Merge "Merge Android Pie into master" am: b6f04dece7 am: 8ea058dd44Xin Li
am: ba979c3265 Change-Id: Ib5ca48459c550b72cf8c4e230e1749d6a6b49a2a
2018-08-07Merge "Merge Android Pie into master" am: b6f04dece7Xin Li
am: 8ea058dd44 Change-Id: Ib10841f529579a79dfc21d988249464a0112f711
2018-08-07Merge "Merge Android Pie into master"Xin Li
am: b6f04dece7 Change-Id: I99ecd0a035d4749b18556a96f14b7a60343e1b4a