Remove race in gtest unit tests.

We run multiple configurations of these tests simultaneously.
FilePath::GenerateUniqueFilename has a TOCTTOU race (by design). It
takes a base path to create the directory in though, so just use the
cwd for the test data directory instead of a fixed path for all test
runs.

Test: Ran the test in the new test runner
Bug: http://b/37631288
Change-Id: I81c58885bd84a14dd5d94eb3a64299861470fea7

1 files changed, 9 insertions, 1 deletions

diff --git a/sources/third_party/googletest/googletest/test/gtest-filepath_test.cc b/sources/third_party/googletest/googletest/test/gtest-filepath_test.cc
index ae9f55a0c..a39faf740 100644
--- a/sources/third_party/googletest/googletest/test/gtest-filepath_test.cc
+++ b/sources/third_party/googletest/googletest/test/gtest-filepath_test.cc
@@ -526,7 +526,15 @@ class DirectoryCreationTest : public Test {
     else
       return std::string(temp_dir) + "\\";
 #elif GTEST_OS_LINUX_ANDROID
-    return "/sdcard/";
+    // We can't use a fixed path because we run multiple configurations of this
+    // test on the device simultaneously. This executable has its own directory
+    // though, so we can use this as the temp path.
+    char cwd[PATH_MAX];
+    if (getcwd(cwd, sizeof(cwd)) == NULL) {
+      perror("getcwd");
+      abort();
+    }
+    return cwd;
 #else
     return "/tmp/";
 #endif  // GTEST_OS_WINDOWS_MOBILE