summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHung-ying Tyan <tyanh@google.com>2021-11-05 17:00:58 +0800
committerHung-ying Tyan <tyanh@google.com>2021-11-05 17:10:38 +0800
commitaddad94cce6823f386b539c0ee8e4b28926215d1 (patch)
tree5fe4844c6f94eb9afcf5f79d9c656312a99a0c87
parent5b93afd7fc2b783ee01cc77baca4e228ae98103f (diff)
downloadCamera2-addad94cce6823f386b539c0ee8e4b28926215d1.tar.gz
AOSP/Camera2: check system feature instead of actual camera device
It is not reliable to check the actual camera devices at boot complete as camera devices may be created after the boot-complete event. Check the system features instead. Bug: 198371493 Bug: 203729113 Test: build aosp_$pixel, reboot, check the app, check log Change-Id: I5581621fed8244f6d19554be00f2c6543799dc92
-rw-r--r--src/com/android/camera/SetActivitiesCameraReceiver.java30
1 files changed, 8 insertions, 22 deletions
diff --git a/src/com/android/camera/SetActivitiesCameraReceiver.java b/src/com/android/camera/SetActivitiesCameraReceiver.java
index 7a79c52e6..347e82b9f 100644
--- a/src/com/android/camera/SetActivitiesCameraReceiver.java
+++ b/src/com/android/camera/SetActivitiesCameraReceiver.java
@@ -38,8 +38,7 @@ public class SetActivitiesCameraReceiver extends BroadcastReceiver {
public void onReceive(Context context, Intent intent) {
// Disable camera-related activities if there is no camera.
int component_state = (CHECK_BACK_CAMERA_ONLY
- ? hasBackCamera()
- : (hasCamera() || supportExternalCamera(context)))
+ ? hasBackCamera(context) : hasCamera(context))
? PackageManager.COMPONENT_ENABLED_STATE_ENABLED
: PackageManager.COMPONENT_ENABLED_STATE_DISABLED;
@@ -50,29 +49,16 @@ public class SetActivitiesCameraReceiver extends BroadcastReceiver {
}
}
- private boolean supportExternalCamera(Context context) {
+ private boolean hasCamera(Context context) {
PackageManager pm = context.getPackageManager();
- return pm.hasSystemFeature(PackageManager.FEATURE_CAMERA_EXTERNAL);
+ return pm.hasSystemFeature(PackageManager.FEATURE_CAMERA)
+ || pm.hasSystemFeature(PackageManager.FEATURE_CAMERA_FRONT)
+ || pm.hasSystemFeature(PackageManager.FEATURE_CAMERA_EXTERNAL);
}
- private boolean hasCamera() {
- int n = android.hardware.Camera.getNumberOfCameras();
- Log.i(TAG, "number of camera: " + n);
- return (n > 0);
- }
-
- private boolean hasBackCamera() {
- int n = android.hardware.Camera.getNumberOfCameras();
- CameraInfo info = new CameraInfo();
- for (int i = 0; i < n; i++) {
- android.hardware.Camera.getCameraInfo(i, info);
- if (info.facing == CameraInfo.CAMERA_FACING_BACK) {
- Log.i(TAG, "back camera found: " + i);
- return true;
- }
- }
- Log.i(TAG, "no back camera");
- return false;
+ private boolean hasBackCamera(Context context) {
+ PackageManager pm = context.getPackageManager();
+ return pm.hasSystemFeature(PackageManager.FEATURE_CAMERA);
}
private void setComponent(Context context, String klass, final int enabledState) {