diff options
| author | Yabin Huang <yabinh@google.com> | 2019-10-24 14:33:02 -0700 |
|---|---|---|
| committer | Yabin Huang <yabinh@google.com> | 2019-10-28 12:15:54 -0700 |
| commit | e8bc338f72bc92034fa09991c5f8a89603dfadfd (patch) | |
| tree | cade2555dd64ab7dfe8c0b989b22807e244fdb63 | |
| parent | 05529c19a2e89c3a5beaea11222af73077675a63 (diff) | |
| download | tests-e8bc338f72bc92034fa09991c5f8a89603dfadfd.tar.gz | |
Fix null rootHints
1.Create media browser with art size extra
2.Log the client name when rootHints is null
Bug: 143305459
Test: manual
Change-Id: I11ba78e3451ee8688b3c4e80e087a8f5399b8073
| -rw-r--r-- | TestMediaApp/src/com/android/car/media/testmediaapp/TmaBrowser.java | 4 | ||||
| -rw-r--r-- | TestMediaApp/src/com/android/car/media/testmediaapp/phone/TmaLauncherActivity.java | 7 |
2 files changed, 9 insertions, 2 deletions
diff --git a/TestMediaApp/src/com/android/car/media/testmediaapp/TmaBrowser.java b/TestMediaApp/src/com/android/car/media/testmediaapp/TmaBrowser.java index 6aeac39..079ab3b 100644 --- a/TestMediaApp/src/com/android/car/media/testmediaapp/TmaBrowser.java +++ b/TestMediaApp/src/com/android/car/media/testmediaapp/TmaBrowser.java @@ -152,6 +152,10 @@ public class TmaBrowser extends MediaBrowserServiceCompat { @Override public BrowserRoot onGetRoot( @NonNull String clientPackageName, int clientUid, Bundle rootHints) { + if (rootHints == null) { + Log.e(TAG, "Client " + clientPackageName + " didn't set rootHints."); + throw new NullPointerException("rootHints is null"); + } Log.i(TAG, "onGetroot client: " + clientPackageName + " EXTRA_MEDIA_ART_SIZE_HINT_PIXELS: " + rootHints.getInt(MediaKeys.EXTRA_MEDIA_ART_SIZE_HINT_PIXELS, 0)); return mRoot; diff --git a/TestMediaApp/src/com/android/car/media/testmediaapp/phone/TmaLauncherActivity.java b/TestMediaApp/src/com/android/car/media/testmediaapp/phone/TmaLauncherActivity.java index e38defa..2727ae4 100644 --- a/TestMediaApp/src/com/android/car/media/testmediaapp/phone/TmaLauncherActivity.java +++ b/TestMediaApp/src/com/android/car/media/testmediaapp/phone/TmaLauncherActivity.java @@ -11,6 +11,7 @@ import android.util.Log; import androidx.appcompat.app.AppCompatActivity; +import com.android.car.media.testmediaapp.MediaKeys; import com.android.car.media.testmediaapp.TmaBrowser; import com.android.car.media.testmediaapp.prefs.TmaPrefsActivity; import com.android.car.media.testmediaapp.R; @@ -38,9 +39,11 @@ public class TmaLauncherActivity extends AppCompatActivity { startActivity(prefsIntent); }); - + Bundle rootHints = new Bundle(); + // TODO: 256 is just a placeholder. We'd better find a proper value. + rootHints.putInt(MediaKeys.EXTRA_MEDIA_ART_SIZE_HINT_PIXELS, 256); mediaBrowser = new MediaBrowserCompat(this, new ComponentName(this, TmaBrowser.class), - mConnectionCallbacks, null); + mConnectionCallbacks, rootHints); } private final MediaBrowserCompat.ConnectionCallback mConnectionCallbacks = |