diff options
| author | Danny Epstein <depstein@google.com> | 2020-07-06 17:27:10 -0700 |
|---|---|---|
| committer | Danny Epstein <depstein@google.com> | 2020-07-06 17:27:10 -0700 |
| commit | 41af77ce3fcd704f6738f8edf9ffc1de3a7be4d4 (patch) | |
| tree | 35eb71b84be753b8db2490ea7278a9a2f23beabf | |
| parent | 577fab74809d3ea85e09dd586036f18ec795be57 (diff) | |
| download | tests-41af77ce3fcd704f6738f8edf9ffc1de3a7be4d4.tar.gz | |
Fix nits in RotaryIME
Bug: 131421840
Bug: 152439508
Test: manual
Change-Id: Ic26daaddbb153f006c0a0f17a6dae94040a6ca04
| -rw-r--r-- | RotaryIME/res/layout/horizontal_keyboard.xml | 2 | ||||
| -rw-r--r-- | RotaryIME/res/values/colors.xml | 1 | ||||
| -rw-r--r-- | RotaryIME/src/com/android/car/rotaryime/RotaryIme.java | 4 |
3 files changed, 4 insertions, 3 deletions
diff --git a/RotaryIME/res/layout/horizontal_keyboard.xml b/RotaryIME/res/layout/horizontal_keyboard.xml index f76b6b4..7c1bff6 100644 --- a/RotaryIME/res/layout/horizontal_keyboard.xml +++ b/RotaryIME/res/layout/horizontal_keyboard.xml @@ -19,7 +19,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:background="#2c2c2c"> + android:background="@color/keyboard_background"> <com.android.car.ui.FocusParkingView android:layout_width="wrap_content" android:layout_height="wrap_content" /> diff --git a/RotaryIME/res/values/colors.xml b/RotaryIME/res/values/colors.xml index e2bc73d..4e6e535 100644 --- a/RotaryIME/res/values/colors.xml +++ b/RotaryIME/res/values/colors.xml @@ -15,6 +15,7 @@ ~ limitations under the License. --> <resources> + <color name="keyboard_background">#2c2c2c</color> <color name="key_background_normal">#404040</color> <color name="key_background_focused">#6080c0</color> <color name="key_background_pressed">#a0c0ff</color> diff --git a/RotaryIME/src/com/android/car/rotaryime/RotaryIme.java b/RotaryIME/src/com/android/car/rotaryime/RotaryIme.java index 4d7f3e4..1d63e2f 100644 --- a/RotaryIME/src/com/android/car/rotaryime/RotaryIme.java +++ b/RotaryIME/src/com/android/car/rotaryime/RotaryIme.java @@ -25,7 +25,7 @@ import android.widget.TextView; import androidx.annotation.NonNull; /** - * Sample IME for rotary controllers. This is intentionally very basic so that it's easy to + * Sample IME for rotary controllers. This is intentionally very basic so that it's easy to * understand the code. It doesn't support multiple locales / layouts. It doesn't support password * fields, numeric fields, etc. */ @@ -56,7 +56,7 @@ public class RotaryIme extends InputMethodService { // on the key which will invoke its click handler. Long press will similarly result in the key's // long click handler being invoked. - // The first row contains letters and the delete key. + // The first row contains letters in alphabetical order and the delete key. ViewGroup letters = rootView.findViewById(R.id.letters); int aIndex = findChild(letters, rootView.findViewById(R.id.a)); for (int i = 0; i < 26; i++) { |