diff options
author | Marcus Hagerott <mhagerott@google.com> | 2016-12-20 08:40:00 -0800 |
---|---|---|
committer | Marcus Hagerott <mhagerott@google.com> | 2016-12-20 08:40:00 -0800 |
commit | 24b4613a00504bd2b6d81a7edb7261e0913f932e (patch) | |
tree | 7785d536972a8c543a3a6ac7049d1dce2537807f /tests/src/com | |
parent | 4bd50d69d2b8934dbd4cbd634ad83807d9b02735 (diff) | |
download | Contacts-24b4613a00504bd2b6d81a7edb7261e0913f932e.tar.gz |
Make SIM import UI tests less flaky
Test: ran GoogleContactsTests
Change-Id: Id8081d5df6e0e5c4c62930001021891a1e71407d
Diffstat (limited to 'tests/src/com')
-rw-r--r-- | tests/src/com/android/contacts/activities/SimImportActivityTest.java | 30 |
1 files changed, 19 insertions, 11 deletions
diff --git a/tests/src/com/android/contacts/activities/SimImportActivityTest.java b/tests/src/com/android/contacts/activities/SimImportActivityTest.java index 8ebe69bdb..8362b9fac 100644 --- a/tests/src/com/android/contacts/activities/SimImportActivityTest.java +++ b/tests/src/com/android/contacts/activities/SimImportActivityTest.java @@ -66,6 +66,7 @@ public class SimImportActivityTest { private Instrumentation mInstrumentation; private FakeSimContactDao mDao; private AccountsTestHelper mAccountHelper; + private Activity mActivity; @Before public void setUp() throws Exception { @@ -87,6 +88,10 @@ public class SimImportActivityTest { SimContactDao.setFactoryForTest(SimContactDao.DEFAULT_FACTORY); mAccountHelper.cleanup(); AccountTypeManager.setInstanceForTest(null); + if (mActivity != null) { + mActivity.finish(); + mInstrumentation.waitForIdleSync(); + } } @Test @@ -96,11 +101,13 @@ public class SimImportActivityTest { new SimContact(2, "Sim Two", null), new SimContact(3, null, "5550103") ); - mInstrumentation.startActivitySync(new Intent(mContext, SimImportActivity.class) + mActivity = mInstrumentation.startActivitySync(new Intent(mContext, SimImportActivity.class) .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)); mDevice.waitForIdle(); + assertTrue(mDevice.wait(Until.hasObject(By.text("Sim One")), TIMEOUT)); + assertTrue(mDevice.hasObject(By.text("Sim One"))); assertTrue(mDevice.hasObject(By.text("Sim Two"))); assertTrue(mDevice.hasObject(By.text("5550103"))); @@ -115,24 +122,24 @@ public class SimImportActivityTest { mDevice.waitForIdle(); - assertTrue(mDevice.hasObject(By.textStartsWith("No contacts"))); + assertTrue(mDevice.wait(Until.hasObject(By.textStartsWith("No contacts")), TIMEOUT)); } @Test public void smokeRotateInEmptyState() { mDao.addSim(someSimCard()); - final Activity activity = mInstrumentation.startActivitySync( + mActivity = mInstrumentation.startActivitySync( new Intent(mContext, SimImportActivity.class) .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)); assertTrue(mDevice.wait(Until.hasObject(By.textStartsWith("No contacts")), TIMEOUT)); - activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE); + mActivity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE); mDevice.waitForIdle(); - assertTrue(mDevice.hasObject(By.textStartsWith("No contacts"))); + assertTrue(mDevice.wait(Until.hasObject(By.textStartsWith("No contacts")), TIMEOUT)); } @Test @@ -140,17 +147,17 @@ public class SimImportActivityTest { mDao.addSim(someSimCard(), new SimContact(1, "Name One", "5550101"), new SimContact(2, "Name Two", "5550102")); - final Activity activity = mInstrumentation.startActivitySync( + mActivity = mInstrumentation.startActivitySync( new Intent(mContext, SimImportActivity.class) .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)); assertTrue(mDevice.wait(Until.hasObject(By.textStartsWith("Name One")), TIMEOUT)); - activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE); + mActivity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE); mDevice.waitForIdle(); - assertTrue(mDevice.hasObject(By.textStartsWith("Name One"))); + assertTrue(mDevice.wait(Until.hasObject(By.textStartsWith("Name One")), TIMEOUT)); } @@ -175,7 +182,7 @@ public class SimImportActivityTest { new SimContact(5, "Skip Five", "5550105"), new SimContact(6, "Import Six", "5550106")); - final Activity activity = mInstrumentation.startActivitySync( + mActivity = mInstrumentation.startActivitySync( new Intent(mContext, SimImportActivity.class) .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)); @@ -187,13 +194,14 @@ public class SimImportActivityTest { mDevice.findObject(By.text("Skip Two")).click(); mDevice.findObject(By.text("Skip Five")).click(); + mDevice.waitForIdle(); assertTrue(mDevice.hasObject(By.text("Skip Two").checked(false))); assertTrue(mDevice.hasObject(By.text("Skip Five").checked(false))); - activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE); + mActivity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE); mDevice.wait(Until.hasObject(By.text("Import One")), TIMEOUT); - activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_USER); + mActivity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_USER); mDevice.wait(Until.hasObject(By.text("Import One")), TIMEOUT); mDevice.findObject(By.text("IMPORT").clickable(true)).click(); |