aboutsummaryrefslogtreecommitdiff
path: root/java/com
diff options
context:
space:
mode:
authorVarun Berry <vberry@google.com>2021-10-05 15:27:27 -0700
committerVarun Berry <vberry@google.com>2021-10-29 11:30:08 -0700
commitea87e575e6c8e6795ee33905220632e4612b4989 (patch)
treee1885478902a7f92262765c6158234694491eda8 /java/com
parentec22254450beb244f98777bf5cc0594ff1dcf61b (diff)
downloadDialer-ea87e575e6c8e6795ee33905220632e4612b4989.tar.gz
Use an explicit intent to start VoicemailChangePinActivityPeer.
This fixes an issue where the CHANGE_PIN intent can be intercepted. Bug: 186405602 Test: manual. Change-Id: If31e733c4f94fa4d0793a7538ec76a10752329b6
Diffstat (limited to 'java/com')
-rw-r--r--java/com/android/dialer/voicemail/listui/error/VoicemailErrorMessage.java2
-rw-r--r--java/com/android/dialer/voicemail/settings/AndroidManifest.xml4
-rw-r--r--java/com/android/dialer/voicemail/settings/VoicemailChangePinActivity.java1
3 files changed, 1 insertions, 6 deletions
diff --git a/java/com/android/dialer/voicemail/listui/error/VoicemailErrorMessage.java b/java/com/android/dialer/voicemail/listui/error/VoicemailErrorMessage.java
index 9accc321c..e22f30656 100644
--- a/java/com/android/dialer/voicemail/listui/error/VoicemailErrorMessage.java
+++ b/java/com/android/dialer/voicemail/listui/error/VoicemailErrorMessage.java
@@ -150,7 +150,7 @@ public class VoicemailErrorMessage {
public void onClick(View v) {
Logger.get(context)
.logImpression(DialerImpression.Type.VOICEMAIL_ALERT_SET_PIN_CLICKED);
- Intent intent = new Intent(VoicemailChangePinActivity.ACTION_CHANGE_PIN);
+ Intent intent = new Intent(context, VoicemailChangePinActivity.class);
intent.putExtra(VoicemailClient.PARAM_PHONE_ACCOUNT_HANDLE, phoneAccountHandle);
context.startActivity(intent);
}
diff --git a/java/com/android/dialer/voicemail/settings/AndroidManifest.xml b/java/com/android/dialer/voicemail/settings/AndroidManifest.xml
index 8506ddd41..f25858e9d 100644
--- a/java/com/android/dialer/voicemail/settings/AndroidManifest.xml
+++ b/java/com/android/dialer/voicemail/settings/AndroidManifest.xml
@@ -29,10 +29,6 @@
android:parentActivityName="com.android.dialer.app.settings.DialerSettingsActivity"
android:theme="@style/SettingsStyle"
android:windowSoftInputMode="stateVisible|adjustResize">
- <intent-filter>
- <action android:name="com.android.dialer.action.CHANGE_PIN"/>
- <category android:name="android.intent.category.DEFAULT"/>
- </intent-filter>
</activity>
<activity
android:name=".RecordVoicemailGreetingActivity"
diff --git a/java/com/android/dialer/voicemail/settings/VoicemailChangePinActivity.java b/java/com/android/dialer/voicemail/settings/VoicemailChangePinActivity.java
index 4e22fb335..ebebdf7d4 100644
--- a/java/com/android/dialer/voicemail/settings/VoicemailChangePinActivity.java
+++ b/java/com/android/dialer/voicemail/settings/VoicemailChangePinActivity.java
@@ -67,7 +67,6 @@ public class VoicemailChangePinActivity extends Activity
implements OnClickListener, OnEditorActionListener, TextWatcher {
private static final String TAG = "VmChangePinActivity";
- public static final String ACTION_CHANGE_PIN = "com.android.dialer.action.CHANGE_PIN";
private static final int MESSAGE_HANDLE_RESULT = 1;