summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnnie Chin <afchin@google.com>2017-02-02 13:15:33 -0800
committerAnnie Chin <afchin@google.com>2017-02-02 15:30:35 -0800
commit9f00a95dbd76036553275295b90a69815d3ac87e (patch)
treeb15bfdd304b4b11eb473e4bd1b0a1ffa70d8f087
parent13cd100ed0438cdcf918d3b3e3f42c506c0c52d1 (diff)
downloadExactCalculator-9f00a95dbd76036553275295b90a69815d3ac87e.tar.gz
Null-check result string.
Bug: 34801142 Change-Id: I1c464ea92c1a7698c81e515159173f6284d127de
-rw-r--r--src/com/android/calculator2/Evaluator.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/com/android/calculator2/Evaluator.java b/src/com/android/calculator2/Evaluator.java
index ea6d8ff..472cd34 100644
--- a/src/com/android/calculator2/Evaluator.java
+++ b/src/com/android/calculator2/Evaluator.java
@@ -1531,7 +1531,9 @@ public class Evaluator implements CalculatorExpr.ExprResolver {
final String rs = ei.mResultString;
// An error can occur here only under extremely unlikely conditions.
// Check anyway, and just refuse.
- if (ei.mResultString == ERRONEOUS_RESULT) {
+ // rs *should* never be null, but it happens. Check as a workaround to protect against
+ // crashes until we find the root cause (b/34801142)
+ if (rs == ERRONEOUS_RESULT || rs == null) {
return null;
}
final int dotIndex = rs.indexOf('.');