diff options
author | Annie Chin <afchin@google.com> | 2018-05-23 16:09:53 -0700 |
---|---|---|
committer | android-build-merger <android-build-merger@google.com> | 2018-05-23 16:09:53 -0700 |
commit | 58eb4c0860d3077ac3f115b982e57096970ec404 (patch) | |
tree | eb7a9ff9b4bdd4420ee19bab8a21fcb03c712737 | |
parent | 3c1b3cf255cc4260811023c70829edddb4e0abdf (diff) | |
parent | 172476febbe6a1f092babceabeb9712ffecdf9db (diff) | |
download | ExactCalculator-58eb4c0860d3077ac3f115b982e57096970ec404.tar.gz |
Merge "Refuse to open history if in ANIMATE state." into pi-dev
am: 172476febb
Change-Id: I2536c87d20e3ff3bf7cce47b907713d056bc8168
-rw-r--r-- | src/com/android/calculator2/Calculator.java | 21 | ||||
-rw-r--r-- | src/com/android/calculator2/DragLayout.java | 17 |
2 files changed, 22 insertions, 16 deletions
diff --git a/src/com/android/calculator2/Calculator.java b/src/com/android/calculator2/Calculator.java index 392447c..81ab1f6 100644 --- a/src/com/android/calculator2/Calculator.java +++ b/src/com/android/calculator2/Calculator.java @@ -535,9 +535,6 @@ public class Calculator extends Activity } public boolean isResultLayout() { - if (mCurrentState == CalculatorState.ANIMATE) { - throw new AssertionError("impossible state"); - } // Note that ERROR has INPUT, not RESULT layout. return mCurrentState == CalculatorState.INIT_FOR_RESULT || mCurrentState == CalculatorState.RESULT; @@ -1339,7 +1336,14 @@ public class Calculator extends Activity */ private boolean prepareForHistory() { if (mCurrentState == CalculatorState.ANIMATE) { - throw new AssertionError("onUserInteraction should have ended animation"); + // End the current animation and signal that preparation has failed. + // onUserInteraction is unreliable and onAnimationEnd() is asynchronous, so we + // aren't guaranteed to be out of the ANIMATE state by the time prepareForHistory is + // called. + if (mCurrentAnimator != null) { + mCurrentAnimator.end(); + } + return false; } else if (mCurrentState == CalculatorState.EVALUATE) { // Cancel current evaluation cancelIfEvaluating(true /* quiet */ ); @@ -1366,12 +1370,15 @@ public class Calculator extends Activity } private void showHistoryFragment() { - final FragmentManager manager = getFragmentManager(); - if (manager == null || manager.isDestroyed()) { + if (getHistoryFragment() != null) { + // If the fragment already exists, do nothing. return; } - if (getHistoryFragment() != null || !prepareForHistory()) { + final FragmentManager manager = getFragmentManager(); + if (manager == null || manager.isDestroyed() || !prepareForHistory()) { + // If the history fragment can not be shown, close the draglayout. + mDragLayout.setClosed(); return; } diff --git a/src/com/android/calculator2/DragLayout.java b/src/com/android/calculator2/DragLayout.java index e34c4da..74b0a8e 100644 --- a/src/com/android/calculator2/DragLayout.java +++ b/src/com/android/calculator2/DragLayout.java @@ -209,14 +209,11 @@ public class DragLayout extends ViewGroup { return mIsOpen; } - private void setClosed() { - if (mIsOpen) { - mIsOpen = false; - mHistoryFrame.setVisibility(View.INVISIBLE); - - if (mCloseCallback != null) { - mCloseCallback.onClose(); - } + public void setClosed() { + mIsOpen = false; + mHistoryFrame.setVisibility(View.INVISIBLE); + if (mCloseCallback != null) { + mCloseCallback.onClose(); } } @@ -350,7 +347,9 @@ public class DragLayout extends ViewGroup { settleToOpen = releasedChild.getTop() > -(mVerticalRange / 2); } - if (mDragHelper.settleCapturedViewAt(0, settleToOpen ? 0 : -mVerticalRange)) { + // If the view is not visible, then settle it closed, not open. + if (mDragHelper.settleCapturedViewAt(0, settleToOpen && mIsOpen ? 0 + : -mVerticalRange)) { ViewCompat.postInvalidateOnAnimation(DragLayout.this); } } |