diff options
author | Jon Miranda <jonmiranda@google.com> | 2018-06-21 17:20:23 -0700 |
---|---|---|
committer | Jon Miranda <jonmiranda@google.com> | 2018-06-21 17:20:23 -0700 |
commit | ca02f00eb168162064c5027158babf1c203833a8 (patch) | |
tree | 523c525511876cb73ead08e2c994574fefd0b919 | |
parent | 07fcd3bea29965239a9756b05e3572e0808abd75 (diff) | |
download | Launcher3-ca02f00eb168162064c5027158babf1c203833a8.tar.gz |
Add @Test and @Ignore to untested test methods in RequestPinItemTest.
Error prone complains when trying to merge launcher3 code to platform pi-dev.
"This looks like a test method but is not run; please add @Test and @Ignore,
or, if this is a helper method, reduce its visibility."
Output:
Executing tasks: [:assembleGoogleDebug, :assembleGoogleDebugAndroidTest]
Gradle build finished in 1s 631ms
Tests Ignored: 1 passed, 4 ignored
Bug: 78589564
Change-Id: Icde57fd8307e1ef409822d1417f629cd1aaa57ba
-rw-r--r-- | tests/src/com/android/launcher3/ui/widget/RequestPinItemTest.java | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tests/src/com/android/launcher3/ui/widget/RequestPinItemTest.java b/tests/src/com/android/launcher3/ui/widget/RequestPinItemTest.java index dba6db33f4..dcb564a778 100644 --- a/tests/src/com/android/launcher3/ui/widget/RequestPinItemTest.java +++ b/tests/src/com/android/launcher3/ui/widget/RequestPinItemTest.java @@ -45,6 +45,7 @@ import com.android.launcher3.util.rule.ShellCommandRule; import com.android.launcher3.widget.WidgetCell; import org.junit.Before; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; @@ -81,6 +82,7 @@ public class RequestPinItemTest extends AbstractLauncherUiTest { @Test public void testEmpty() throws Throwable { /* needed while the broken tests are being fixed */ } + @Test @Ignore public void testPinWidgetNoConfig() throws Throwable { runTest("pinWidgetNoConfig", true, new ItemOperator() { @Override @@ -93,6 +95,7 @@ public class RequestPinItemTest extends AbstractLauncherUiTest { }); } + @Test @Ignore public void testPinWidgetNoConfig_customPreview() throws Throwable { // Command to set custom preview Intent command = RequestPinItemActivity.getCommandIntent( @@ -110,6 +113,7 @@ public class RequestPinItemTest extends AbstractLauncherUiTest { }, command); } + @Test @Ignore public void testPinWidgetWithConfig() throws Throwable { runTest("pinWidgetWithConfig", true, new ItemOperator() { @Override @@ -122,6 +126,7 @@ public class RequestPinItemTest extends AbstractLauncherUiTest { }); } + @Test @Ignore public void testPinShortcut() throws Throwable { // Command to set the shortcut id Intent command = RequestPinItemActivity.getCommandIntent( |