aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTaesu Lee <taesu82.lee@samsung.com>2021-01-12 13:40:45 +0900
committerTaesu Lee <taesu82.lee@samsung.com>2021-01-12 18:50:34 +0900
commitbccecb639356481c793a2b7f1aa0f14aa802ad5d (patch)
tree1edc43b70fac809f679aec98467d309e34f5c02e
parent89efbab65dd1ba2d978bb7d593fa7e9601e6af72 (diff)
downloadMessaging-bccecb639356481c793a2b7f1aa0f14aa802ad5d.tar.gz
Fix wrong sync message issue for pending outgoing messagesandroid-s-preview-1
If sync operation is occurred between ResendMessageAction and SendMessageAction, the pending outgoing messages in local db are deleted and new messages are added from remote db. To fix this issue, ResendMessageAction will update RETRY_TIMESTAMP only. And RECEIVED_TIMESTAMP and SENT_TIMESTAMP will be updated in SendMessageAction when the message is queued. Test: manual Change-Id: I0ffa6f46a7094ec3dfd2954d4313b78dd57d6994 Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
-rw-r--r--src/com/android/messaging/datamodel/action/ResendMessageAction.java2
-rw-r--r--src/com/android/messaging/datamodel/action/SendMessageAction.java17
2 files changed, 13 insertions, 6 deletions
diff --git a/src/com/android/messaging/datamodel/action/ResendMessageAction.java b/src/com/android/messaging/datamodel/action/ResendMessageAction.java
index 0943f72..b442ae6 100644
--- a/src/com/android/messaging/datamodel/action/ResendMessageAction.java
+++ b/src/com/android/messaging/datamodel/action/ResendMessageAction.java
@@ -80,8 +80,6 @@ public class ResendMessageAction extends Action implements Parcelable {
final ContentValues values = new ContentValues();
values.put(MessageColumns.STATUS, MessageData.BUGLE_STATUS_OUTGOING_YET_TO_SEND);
- values.put(MessageColumns.RECEIVED_TIMESTAMP, timestamp);
- values.put(MessageColumns.SENT_TIMESTAMP, timestamp);
values.put(MessageColumns.RETRY_START_TIMESTAMP, timestamp);
// Row must exist as was just loaded above (on ActionService thread)
diff --git a/src/com/android/messaging/datamodel/action/SendMessageAction.java b/src/com/android/messaging/datamodel/action/SendMessageAction.java
index 35e6280..44c661d 100644
--- a/src/com/android/messaging/datamodel/action/SendMessageAction.java
+++ b/src/com/android/messaging/datamodel/action/SendMessageAction.java
@@ -95,13 +95,17 @@ public class SendMessageAction extends Action implements Parcelable {
private boolean queueAction(final String messageId, final Action processingAction) {
actionParameters.putString(KEY_MESSAGE_ID, messageId);
- final long timestamp = System.currentTimeMillis();
final DatabaseWrapper db = DataModel.get().getDatabase();
final MessageData message = BugleDatabaseOperations.readMessage(db, messageId);
// Check message can be resent
if (message != null && message.canSendMessage()) {
- final boolean isSms = (message.getProtocol() == MessageData.PROTOCOL_SMS);
+ final boolean isSms = message.getIsSms();
+ long timestamp = System.currentTimeMillis();
+ if (!isSms) {
+ // MMS expects timestamp rounded to nearest second
+ timestamp = 1000 * ((timestamp + 500) / 1000);
+ }
final ParticipantData self = BugleDatabaseOperations.getExistingParticipant(
db, message.getSelfId());
@@ -110,8 +114,13 @@ public class SendMessageAction extends Action implements Parcelable {
// Update message status
if (message.getYetToSend()) {
- // Initial sending of message
- message.markMessageSending(timestamp);
+ if (message.getReceivedTimeStamp() == message.getRetryStartTimestamp()) {
+ // Initial sending of message
+ message.markMessageSending(timestamp);
+ } else {
+ // Manual resend of message
+ message.markMessageManualResend(timestamp);
+ }
} else {
// Automatic resend of message
message.markMessageResending(timestamp);