aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-11[automerge] Trim recipient addresses that are unreasonably long. 2p: e37bb58fbbPresubmit Automerger Backend
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23181897 Bug: 278556945 Change-Id: Iea18a6475bc3157bcfe8a0cae05f7357e5003acd
2023-05-11Trim recipient addresses that are unreasonably long.Jake Klinker
This ensures that bad input does not affect the db - the fallback is a reasonable one where we just launch the new conversation screen and have the user select the recipient. TESTED=manually confirmed that I could no longer repro b/278556945 after this change. BUG=278556945 Change-Id: I705a304a92cb46b20d916c6f5c2db81e6fa84f06
2023-05-11Trim recipient addresses that are unreasonably long.Jake Klinker
This ensures that bad input does not affect the db - the fallback is a reasonable one where we just launch the new conversation screen and have the user select the recipient. TESTED=manually confirmed that I could no longer repro b/278556945 after this change. BUG=278556945 Change-Id: I705a304a92cb46b20d916c6f5c2db81e6fa84f06
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 83d5883687 am: 5b110f95e9 am: ff1c734aeb Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I163a39ab25cd6c67467c0b11cf8049d591dadd8c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: a4838ac96e am: 2ffa017167 am: 11d36f6b01 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: If6df6f5d7d9b2a69114390809189f62ec0d86929 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 83d5883687 am: fad62338f9 am: 633996e4bb Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I62d531ec009270bb3b3eae8f5cd02e5462441e9b Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 83d5883687 am: 5b110f95e9 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I29293e85cf9f1d845be9a035f1ab9eefc4d5812c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: a4838ac96e am: 2ffa017167 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Ib854c5b9807e0ad4552e6b330a4f8441135b8741 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 83d5883687 am: fad62338f9 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Ib164bfa5daf846fe80e3764ce9f077f75dc076b5 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10[automerge] Fix exposing private messages files through attachments with a ↵Presubmit Automerger Backend
content URI. 2p: 0d5452146c 2p: 471c3e9320 am: 749732f47b am: 78c26722e2 am: 7bf7a451f7 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Ic13449a3884c39331cd66ab3733d0f97d8ae9de8 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 83d5883687 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I37c232a6a57edc0cc0d069818787c8c77fe3d00e Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: a4838ac96e Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Id63d1f2cad4ba1adfa078289bc0ba25cd3491eea Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 83d5883687 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I7a6fa5befbf67d50fac2225ce835a5c519e8c46a Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 am: 6542270a1f Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I07b12cba891563e7bb935980afe3352cda7104af Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Ida74ec2de652b8e4fcb874a111852f655ba64cfe Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Iecdb3fbc6a6ada726fcb24b55835071db984e2d3 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c am: f5c73b1923 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I070d32b4f371b0b3d62a3352bcff495fb1c4e02f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10[automerge] Fix exposing private messages files through attachments with a ↵Presubmit Automerger Backend
content URI. 2p: 0d5452146c 2p: 471c3e9320 am: 749732f47b am: 78c26722e2 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I1c37352d2c828b7c5da07e146417bd59e4dfdd16 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10[automerge] Fix exposing private messages files through attachments with a ↵Presubmit Automerger Backend
content URI. 2p: 0d5452146c 2p: 471c3e9320 am: 749732f47b Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: Ied33ba04c0254c30e99d89bdcbcbc73696a1b35f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Fix exposing private messages files through attachments with a content URI. ↵Jake Klinker
am: 0d5452146c Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Change-Id: I56f3015298ed0b2acde72442b458e0b354f0e13d Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09[automerge] Fix exposing private messages files through attachments with a ↵Presubmit Automerger Backend
content URI. 2p: 0d5452146c 2p: 471c3e9320 Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Bug: 275552292 Change-Id: I48af374ac45d21758789153013278d68290ee701
2023-05-09[automerge] Fix exposing private messages files through attachments with a ↵Presubmit Automerger Backend
content URI. 2p: 0d5452146c Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/23089831 Bug: 275552292 Change-Id: I70bfdb81846c81cf0c79d9a1f33140e00734f163
2023-05-09Fix exposing private messages files through attachments with a content URI.Jake Klinker
Change-Id: I30b2a06c67af4a347d03c7504d13b9b9365acafd Tested: Was no longer able to repro b/275552292. Bug: 275552292
2023-05-09Fix exposing private messages files through attachments with a content URI.Jake Klinker
Change-Id: I30b2a06c67af4a347d03c7504d13b9b9365acafd Tested: Was no longer able to repro b/275552292. Bug: 275552292
2022-11-04Merge "Add unaudited exported flag to exposed runtime receivers"TreeHugger Robot
2022-10-17Fix errorprone warnings that should be errors am: 50b73ca58a am: f812cb353b ↵Cole Faust
am: 9000f7ab0b Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2255931 Change-Id: I824fc3032b18d2dd5484ef1c1ffce877f274f7e4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17Fix errorprone warnings that should be errors am: 50b73ca58a am: f812cb353bandroid-u-beta-1-gplCole Faust
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2255931 Change-Id: Id8f5515bcdc63cc1f354d468eb4bcd9ca9fed515 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17Fix errorprone warnings that should be errors am: 50b73ca58amain-16k-with-phonesCole Faust
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2255931 Change-Id: Ic88f3392fb80e1d1377c9442f1da817bc0444192 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-15Fix errorprone warnings that should be errorsCole Faust
This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: I8b1533cbea835343dcf589cbaa57c63794be58bd
2022-10-04Add unaudited exported flag to exposed runtime receiversMichael Groover
Android T allows apps to declare a runtime receiver as not exported by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag; receivers registered with this flag will only receive broadcasts from the platform and the app itself. However to ensure developers can properly protect their receivers, all apps targeting U or later registering a receiver for non-system broadcasts must specify either the exported or not exported flag when invoking #registerReceiver; if one of these flags is not provided, the platform will throw a SecurityException. This commit updates all the exposed receivers with a new RECEIVER_EXPORTED_UNAUDITED flag to maintain the existing behavior of exporting the receiver while also flagging the receiver for audit before the U release. Bug: 234659204 Test: Build Change-Id: I15aba10fe12dfcd2e67330ca844491341ef6d920
2022-09-22Update DrawableWrapper to DrawableWrapperCompat am: b1401d612f am: ↵Chaohui Wang
9cd6eea905 am: 164064c1c4 am: 8817e83c92 am: 1b37d166b3 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2200597 Change-Id: Id0e8d9b98533b82298bb6292d5cce20fca0f57cc Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22Update DrawableWrapper to DrawableWrapperCompat am: b1401d612f am: ↵Chaohui Wang
9cd6eea905 am: 164064c1c4 am: 8817e83c92 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2200597 Change-Id: Ibcd5ae8095177b970c6163f25134e3ce2e35ed82 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22Update DrawableWrapper to DrawableWrapperCompat am: b1401d612f am: ↵Chaohui Wang
9cd6eea905 am: 164064c1c4 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2200597 Change-Id: I06cf3ed171327507e082b6aebe6ffe31bceccdaa Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22Update DrawableWrapper to DrawableWrapperCompat am: b1401d612f am: 9cd6eea905Chaohui Wang
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2200597 Change-Id: I29f2e356092269d6d8fe528be00781e0c0864fbc Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22Update DrawableWrapper to DrawableWrapperCompat am: b1401d612fChaohui Wang
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2200597 Change-Id: I7304dcfeefa72e267029d712fb80abb995f16e29 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22Update DrawableWrapper to DrawableWrapperCompat am: f648675fabChaohui Wang
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Messaging/+/19946229 Change-Id: Ibdb65ea61d3d4c58143d6fef8441189dbad58ce3 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15Update DrawableWrapper to DrawableWrapperCompatChaohui Wang
Api changed in aosp/2120177 Bug: 235727273 Test: TAP Change-Id: I1645dab6000dc760b4de2bb625e0af8df014c8c8
2022-08-31Update DrawableWrapper to DrawableWrapperCompatChaohui Wang
Api changed in aosp/2120177 Bug: 235727273 Test: TAP Change-Id: I1645dab6000dc760b4de2bb625e0af8df014c8c8
2022-08-26Update DrawableWrapper to DrawableWrapperCompatChaohui Wang
Api changed in aosp/2120177 Bug: 235727273 Test: TAP Change-Id: I1645dab6000dc760b4de2bb625e0af8df014c8c8
2022-08-24Fix array-related errorprone warnings am: 1aba0b0461 am: c1da51c9af am: ↵Cole Faust
5d9a564880 am: 87e54599d3 am: af083023d7 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186297 Change-Id: I5b9d248cdfbed8a0a683384d2081e6736dedbafa Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24Fix array-related errorprone warnings am: 1aba0b0461 am: c1da51c9af am: ↵Cole Faust
5d9a564880 am: 87e54599d3 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186297 Change-Id: I31bb5ebc65f6664857fadcaa298963bfc47bd2b2 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24Fix array-related errorprone warnings am: 1aba0b0461 am: c1da51c9af am: ↵Cole Faust
5d9a564880 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186297 Change-Id: I712e86ec1b748619457fbabd9edc57518ddf4fa7 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24Fix array-related errorprone warnings am: 1aba0b0461 am: c1da51c9afCole Faust
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186297 Change-Id: I3032ac78003108ed396bdfc3e067950b18565bd5 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24Fix array-related errorprone warnings am: 1aba0b0461Cole Faust
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186297 Change-Id: I27efca401b1b6332cc3fcc037a4bd3f6043158a4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-23Fix array-related errorprone warningsCole Faust
The ArrayEquals, ArrayHashCode, ArrayToString, and ArraysAsListPrimitiveArray errorprone findings were demoted from errors to warnings. Fix existing occurrences of them so they can be made errors again. Bug: 242630963 Test: RUN_ERROR_PRONE=true m javac-check Change-Id: I8a507da97e99a7e86577fda91960dd477c0a6af4
2022-08-17[automerger skipped] DO NOT MERGE - Merge Android 13 am: aee8039030 -s ours ↵Xin Li
am: 0e6cdf2eb7 -s ours am: ad83b97fc2 -s ours am: ecdfb3e761 -s ours am skip reason: subject contains skip directive Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186587 Change-Id: Ia9b01e428c22d660ee142dbcd03fcef3a2b02057 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17[automerger skipped] DO NOT MERGE - Merge Android 13 am: aee8039030 -s ours ↵Xin Li
am: 0e6cdf2eb7 -s ours am: ad83b97fc2 -s ours am skip reason: Merged-In Ibbc4fb11e96b5179ff5dec906e74c9d582b6fb97 with SHA-1 909a0763c6 is already in history Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186587 Change-Id: If55ad601b9c596aa24b61a65a94a2f5a34d54648 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-16[automerger skipped] DO NOT MERGE - Merge Android 13 am: aee8039030 -s ours ↵Xin Li
am: 0e6cdf2eb7 -s ours am skip reason: Merged-In Ibbc4fb11e96b5179ff5dec906e74c9d582b6fb97 with SHA-1 909a0763c6 is already in history Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186587 Change-Id: I1523d98dbb1656e2576661952c89468da72068c6 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-16[automerger skipped] DO NOT MERGE - Merge Android 13 am: aee8039030 -s oursXin Li
am skip reason: Merged-In Ibbc4fb11e96b5179ff5dec906e74c9d582b6fb97 with SHA-1 909a0763c6 is already in history Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/2186587 Change-Id: I2c6d39abd94c84fc897cf0b69db9ccc543b5c428 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-15DO NOT MERGE - Merge Android 13Xin Li
Bug: 242648940 Merged-In: Ibbc4fb11e96b5179ff5dec906e74c9d582b6fb97 Change-Id: If921e7f572b3c1a867b20042acc58ae7c9e26821
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-05 01:19:12 +0000