diff options
author | Jean Chen <chenjean@google.com> | 2023-12-09 05:04:34 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2023-12-09 05:04:34 +0000 |
commit | 013626ebff251f539474566f51a8770575cf4415 (patch) | |
tree | b2070296b55bd856b66154496d31228293734779 | |
parent | 4ed55488879de07a6f4b655becfa5bc5bdf8a857 (diff) | |
parent | 097d8a891b72f954a1fbf859e926e83fae179690 (diff) | |
download | Settings-013626ebff251f539474566f51a8770575cf4415.tar.gz |
Merge "feat(MultiFingerMultiTap): Update shortcut string to double tap from triple tap" into main
4 files changed, 18 insertions, 18 deletions
diff --git a/res/values/strings.xml b/res/values/strings.xml index 9de79d4e410..33cae6d0783 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4646,8 +4646,8 @@ <string name="accessibility_tutorial_dialog_title_volume">Hold volume keys to open</string> <!-- Title for the accessibility tutorial dialog in accessibility service with triple tap. [CHAR LIMIT=100] --> <string name="accessibility_tutorial_dialog_title_triple">Triple tap screen to open</string> - <!-- Title for the accessibility tutorial dialog in accessibility service with two finger triple tap. [CHAR LIMIT=100] --> - <string name="accessibility_tutorial_dialog_title_two_finger_triple">Two finger triple tap screen to open</string> + <!-- Title for the accessibility tutorial dialog in accessibility service with two finger double tap. [CHAR LIMIT=100] --> + <string name="accessibility_tutorial_dialog_title_two_finger_double">Two finger double tap screen to open</string> <!-- Title for the accessibility tutorial dialog in accessibility service with gesture. [CHAR LIMIT=50] --> <string name="accessibility_tutorial_dialog_title_gesture">Use gesture to open</string> <!-- Title for the accessibility tutorial dialog in gesture navigation settings. [CHAR LIMIT=50] --> @@ -4660,8 +4660,8 @@ <string name="accessibility_tutorial_dialog_message_volume">To use this feature, press & hold both volume keys.</string> <!-- Instruction for the accessibility tutorial dialog in accessibility service with triple tap. [CHAR LIMIT=100] --> <string name="accessibility_tutorial_dialog_message_triple">To start and stop magnification, triple-tap anywhere on your screen.</string> - <!-- Instruction for the accessibility tutorial dialog in accessibility service with two finger triple tap. [CHAR LIMIT=100] --> - <string name="accessibility_tutorial_dialog_message_two_finger_triple">To start and stop magnification, triple-tap anywhere on your screen with two fingers.</string> + <!-- Instruction for the accessibility tutorial dialog in accessibility service with two finger double tap. [CHAR LIMIT=100] --> + <string name="accessibility_tutorial_dialog_message_two_finger_triple">To start and stop magnification, double-tap anywhere on your screen with two fingers.</string> <!-- Message for the accessibility tutorial dialog when user enables an accessibility service while using gesture navigation and touch exploration is not enabled. [CHAR LIMIT=NONE] --> <string name="accessibility_tutorial_dialog_message_gesture">To use this feature, swipe up from the bottom of the screen with 2 fingers.\n\nTo switch between features, swipe up with 2 fingers and hold.</string> <!-- Message for the accessibility tutorial dialog when user enables an accessibility service while using gesture navigation and touch exploration is enabled. [CHAR LIMIT=NONE] --> @@ -4704,12 +4704,12 @@ <string name="accessibility_shortcut_hardware_keyword">hold volume keys</string> <!-- Summary for hardware shortcut in accessibility edit shortcut dialog. [CHAR LIMIT=NONE] --> <string name="accessibility_shortcut_edit_dialog_summary_hardware">Press & hold both volume keys</string> - <!-- Title for two finger triple tap shortcut in accessibility edit shortcut dialog. [CHAR LIMIT=NONE] --> - <string name="accessibility_shortcut_edit_dialog_title_two_finger_triple_tap">Two-finger triple-tap screen</string> + <!-- Title for two finger double tap shortcut in accessibility edit shortcut dialog. [CHAR LIMIT=NONE] --> + <string name="accessibility_shortcut_edit_dialog_title_two_finger_double_tap">Two-finger double-tap screen</string> <!-- Part of list to compose user's accessibility shortcut list. [CHAR LIMIT=NONE] --> - <string name="accessibility_shortcut_two_finger_triple_tap_keyword">two-finger triple-tap screen</string> - <!-- Summary for two finger triple tap shortcut in accessibility edit shortcut dialog. [CHAR LIMIT=NONE] --> - <string name="accessibility_shortcut_edit_dialog_summary_two_finger_triple_tap">Quickly tap screen {0,number,integer} times with two fingers</string> + <string name="accessibility_shortcut_two_finger_double_tap_keyword">two-finger double-tap screen</string> + <!-- Summary for two finger double tap shortcut in accessibility edit shortcut dialog. [CHAR LIMIT=NONE] --> + <string name="accessibility_shortcut_edit_dialog_summary_two_finger_double_tap">Quickly tap screen {0,number,integer} times with two fingers</string> <!-- Title for triple tap shortcut in accessibility edit shortcut dialog. [CHAR LIMIT=NONE] --> <string name="accessibility_shortcut_edit_dialog_title_triple_tap">Triple-tap screen</string> <!-- Part of list to compose user's accessibility shortcut list. [CHAR LIMIT=NONE] --> diff --git a/src/com/android/settings/accessibility/AccessibilityDialogUtils.java b/src/com/android/settings/accessibility/AccessibilityDialogUtils.java index c429e0b0d55..ca3a7b1d53b 100644 --- a/src/com/android/settings/accessibility/AccessibilityDialogUtils.java +++ b/src/com/android/settings/accessibility/AccessibilityDialogUtils.java @@ -249,7 +249,7 @@ public class AccessibilityDialogUtils { initSoftwareShortcut(context, contentView); initHardwareShortcut(context, contentView); if (Flags.enableMagnificationMultipleFingerMultipleTapGesture()) { - initTwoFingerTripleTapMagnificationShortcut(context, contentView); + initTwoFingerDoubleTapMagnificationShortcut(context, contentView); } initMagnifyShortcut(context, contentView); initAdvancedWidget(contentView); @@ -260,7 +260,7 @@ public class AccessibilityDialogUtils { initSoftwareShortcutForSUW(context, contentView); initHardwareShortcut(context, contentView); if (Flags.enableMagnificationMultipleFingerMultipleTapGesture()) { - initTwoFingerTripleTapMagnificationShortcut(context, contentView); + initTwoFingerDoubleTapMagnificationShortcut(context, contentView); } initMagnifyShortcut(context, contentView); initAdvancedWidget(contentView); @@ -365,15 +365,15 @@ public class AccessibilityDialogUtils { R.raw.a11y_shortcut_type_triple_tap); } - private static void initTwoFingerTripleTapMagnificationShortcut(Context context, View view) { + private static void initTwoFingerDoubleTapMagnificationShortcut(Context context, View view) { // TODO(b/306153204): Update shortcut string and image when UX provides them final View dialogView = view.findViewById(R.id.two_finger_triple_tap_shortcut); final CharSequence title = context.getText( - R.string.accessibility_shortcut_edit_dialog_title_two_finger_triple_tap); + R.string.accessibility_shortcut_edit_dialog_title_two_finger_double_tap); String summary = context.getString( - R.string.accessibility_shortcut_edit_dialog_summary_two_finger_triple_tap); - // Format the number '3' in the summary. - final Object[] arguments = {3}; + R.string.accessibility_shortcut_edit_dialog_summary_two_finger_double_tap); + // Format the number '2' in the summary. + final Object[] arguments = {2}; summary = MessageFormat.format(summary, arguments); setupShortcutWidgetWithImageRawResource(context, dialogView, title, summary, diff --git a/src/com/android/settings/accessibility/AccessibilityGestureNavigationTutorial.java b/src/com/android/settings/accessibility/AccessibilityGestureNavigationTutorial.java index e90ed87da1b..1f71ab0ab36 100644 --- a/src/com/android/settings/accessibility/AccessibilityGestureNavigationTutorial.java +++ b/src/com/android/settings/accessibility/AccessibilityGestureNavigationTutorial.java @@ -416,7 +416,7 @@ public final class AccessibilityGestureNavigationTutorial { // TODO(b/308088945): Update tutorial string and image when UX provides them final int type = UserShortcutType.TWOFINGERTRIPLETAP; final CharSequence title = - context.getText(R.string.accessibility_tutorial_dialog_title_two_finger_triple); + context.getText(R.string.accessibility_tutorial_dialog_title_two_finger_double); final View image = createIllustrationViewWithImageRawResource(context, R.raw.a11y_shortcut_type_triple_tap); diff --git a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java index 9f6eec3a31d..1d946fbd3b1 100644 --- a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java @@ -477,7 +477,7 @@ public class ToggleScreenMagnificationPreferenceFragment extends if (Flags.enableMagnificationMultipleFingerMultipleTapGesture()) { if (hasShortcutType(shortcutTypes, UserShortcutType.TWOFINGERTRIPLETAP)) { final CharSequence twoFingerTripleTapTitle = context.getText( - R.string.accessibility_shortcut_two_finger_triple_tap_keyword); + R.string.accessibility_shortcut_two_finger_double_tap_keyword); list.add(twoFingerTripleTapTitle); } } |