Age | Commit message (Collapse) | Author |
|
BUG=140434525
FIXED=140434525
PiperOrigin-RevId: 266988284
Change-Id: I7cb49d07a3faa9cb61a1d5e2b34b672cc49dcf34
|
|
PiperOrigin-RevId: 263374001
Change-Id: Ifa8eb8b4017d084afd5a19d034729909cc158325
|
|
Test: m LiveTv
Change-Id: I65088a8563c183e2b57f8c41e7e6bbd7b3731f3a
|
|
PiperOrigin-RevId: 260213424
Change-Id: I5fc75f204a0c24612ce2f6cd4436fe3d4574b6c9
|
|
This allows future import of robolectric tests.
Change-Id: Ib3c3356bc21d7255c1da684fb7300c6174f1afab
Bug:71358552
Test: m tv-test-common
|
|
Bug:71358552
Change-Id: Idb86b11d41b4e02acae28a9ffaebb008ca138cca
Test: m tv-test-common
|
|
This CL cleans up code findings in third_party/java_src/android_app/live_channels.
Affected code:
//depot/google3/third_party/java_src/android_app/live_channels/
Applied fixes:
ErrorProneFragileCode
This is a CL created with Zwingli (go/zwingli).
You can revert this CL by replying `REVERT: <provide reason>`.
PiperOrigin-RevId: 254988337
Change-Id: I1fedb433e14546932ff74bbaa7a806b2dbfdb378
|
|
PiperOrigin-RevId: 254473872
Change-Id: I503f1cd7d7f562095adc0bb2fab9499075f459f5
|
|
PiperOrigin-RevId: 254467452
Change-Id: I03ca19647d1491f529103d1af24524f21b984316
|
|
Renames may include:
- containsAllOf => containsAtLeast
- containsAllIn => containsAtLeastElementsIn
- isSameAs => isSameInstanceAs
- isOrdered => isInOrder
- isStrictlyOrdered => isInStrictOrder
The other major change is to change custom subjects to extend raw Subject instead of supplying type parameters. The type parameters are being removed from Subject. This CL will temporarily produce rawtypes warnings, which will go away when I remove the type parameters (as soon as this batch of CLs is submitted).
Some CLs in this batch also migrate calls away from actualAsString(). Its literal replacement is `"<" + actual + ">"` (unless an object overrides actualCustomStringRepresentation()), but usually I've made a larger change, such as switching from an old-style "Not true that..." failure message to one generated with the Fact API. In that case, the new code usually contains a direct reference to this.actual (a field that I occasionally had to create). Another larger change I sometimes made is to switch from a manual check-and-fail approach to instead use check(...). And sometimes I just remove a withMessage() call that's no longer necessary now that the code uses check(...), or I introduce a check(...) call. (An assertion made with check(...) automatically includes the actual value from the original subject, so there's no need to set it again with withMessage().)
Finally, there's one CL in this batch in which I migrate a Correspondence subclass to instead use Correspondence.from.
END_PUBLIC
If this is too many changes at once, let me know, and I can split it up and/or explain further. In the past, I've erred on the side of sending separate CLs for each change, which has required some owners to manually reapply each one, so now I'm trying this way.
Thanks again for your patience. There is an outside chance that this will be the last CL I send you before Truth 1.0 -- but certainly no promises :)
More information:
Renames:
go/containsall-lsc
go/issameas-lsc
go/isordered-lsc
Removing type parameters: go/truth-subject-lsc
Migration from old fail*(...) methods to new ones and to check(...): go/legacy-fail-lsc
Changes that replace assert*(...) with introduce check(...): go/check-not-assert-lsc
Correspondence subclass to Correspondence.from: go/correspondence-lsc
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:251456649:BASE:251438222:1559666931910:421718d5
PiperOrigin-RevId: 251940641
Change-Id: I7a8dd9c9951cb5370e3c217577ad6c57dd7997b0
|
|
The self-type parameter is being removed from ComparableSubject. In order to remove one type parameter while leaving the other in place, it's necessary either to make an atomic change (which is tricky for third-party code) or to temporarily remove *both* type parameters and then put the one back. This CL implements the latter. This CL will temporarily produce rawtypes warnings -- and temporarily eliminate type-checking of calls to the ComparableSubject methods -- which will go away when I remove the type parameters (as soon as this batch of CLs is submitted).
This CL requires Truth 0.45. I should already have another CL out to you (perhaps even already submitted) to make other changes to prepare for Truth 0.45.
END_PUBLIC
More information:
go/truth-subject-lsc
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:251865774:BASE:251846460:1559838467261:72e6c90a
PiperOrigin-RevId: 251933003
Change-Id: I8dc7bb4212893c79b44e16386f51575f95732a7d
|
|
PiperOrigin-RevId: 251565132
Change-Id: I0c6c5bb3636728c2217cf4362b2020da511df681
|
|
PiperOrigin-RevId: 251306388
Change-Id: I308d30d34f120dfad22a104288884674b7eaeae4
|
|
Reduce usage of BooleanSystemProperty.
END_PUBLIC
Bug=80084809
Live Channels: Import of http://pa/1354302
Change-Id: Iec9d6793f22103f0ec2bfda7f0c96eb687c03669
PiperOrigin-RevId: 251280651
|
|
PiperOrigin-RevId: 250773299
Change-Id: I355d9ffef2b0b2bb494683c53396b9f847c1d633
|
|
The former is deprecated and replaced by the latter in Mockito 2. However, there is a
functional difference: ArgumentMatchers will reject `null` and check the type
if the matcher specified a type (e.g. `any(Class)` or `anyInt()`). `any()` will
remain to accept anything.
For more information see go/matchers-any-null-lsc
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:250287304:BASE:250411780:1559100945691:2daa4cb5
PiperOrigin-RevId: 250458606
Change-Id: Ic046c51d6a35be6dd2417f48b1351ad6f2b5f7f7
|
|
read that.
actual() is being removed.
More information:
go/truth-subject-lsc
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:246937524:BASE:246916962:1557195397775:e9045b3b
PiperOrigin-RevId: 247012871
Change-Id: I88caa3a1124c6bf4aca23802117652c4dcfd7e86
|
|
Subject.fail* methods or, in some cases, to Subject.check.
Most of the changes in this CL were made manually.
I've tried to preserve all information (and of course behavior!), but the format and grammar of the messages does change. For example before-and-after messages, see the LSC doc.
In some of the CLs in this round (e.g., jscomp), I don't know a lot about the domain being tested, and the assertions are complex, so please let me know if my new phrasing is wrong or confusing.
Thanks again for your patience with all the Truth changes lately.
END_PUBLIC
More information:
go/legacy-fail-lsc
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:246510312:BASE:246506198:1556896359433:4d06667
PiperOrigin-RevId: 246536992
Change-Id: Idec849b299e3582722c53558096a507580bcdcb2
|
|
They behave identically, and the old names are being removed.
Open-source note: The new methods are available in Truth as of version 0.44.
END_PUBLIC
More information:
go/issameas-lsc
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:246024172:BASE:246042619:1556672664622:bc5e776e
PiperOrigin-RevId: 246063612
Change-Id: I9188fe6aaf358f225c74b7879384c4e453fd6ca4
|
|
- 245843574 CLEANUP: Remove unused fields and methods from TestSingle... by nchalko <nchalko@google.com>
PiperOrigin-RevId: 245843574
Change-Id: I536e4a683efd642e1ff2f9594f6c08b3abc20b1e
Test: m LiveTv
|
|
PiperOrigin-RevId: 242485635
Change-Id: If490b9236d9c5408b6b15bf7ea45b4ee51ab1bcd
|
|
Will move more classes to fakes in another CL
PiperOrigin-RevId: 241849555
Change-Id: Ia9bab0b112ede7101318bf99a76ddeeaa34e9058
(cherry picked from commit c1f492a47bf8cb8b345b88ca764b9db2dbad2cf7)
|
|
PiperOrigin-RevId: 234595512
Change-Id: I1b57005dcb892b7bfcfc565628979e7685d7cb08
|
|
So other packages don't need to know the name of the generated factory.
PiperOrigin-RevId: 231871231
Change-Id: I19c100a957b25fcc0bb044fb495c0e9fd4da08df
|
|
PiperOrigin-RevId: 228613798
Change-Id: I57af89dc5ebc772cb3b0cedfc87ec067abb199f9
|
|
PiperOrigin-RevId: 228408379
Change-Id: Ibf0b680153ce9a8a6401cb4e80d2a6ace853e393
|
|
PiperOrigin-RevId: 228408293
Change-Id: I63c8cdd87d80512edbc0581fce83730ec5d6cf69
|
|
PiperOrigin-RevId: 228408250
Change-Id: Ie5f41a1f95353238bc4e3c898b600f844db68e21
|
|
PiperOrigin-RevId: 228253623
Change-Id: Ie36647f19025925632e2818611d90a1c58a02102
|
|
PiperOrigin-RevId: 227884397
Change-Id: I9a437ce6438b45fdabc034aabc0e05c4aae55e85
|
|
* changes:
Migrate tv/common to song
Namespace lib modules into tv-*
|
|
PiperOrigin-RevId: 227624325
Change-Id: I41d3527eda350a46eaede106b47b69a6856a7540
Test: m LiveTv
|
|
The modules in lib/ duplicate modules that are commonly used in
the platform. Give them all tv-* names so they don't conflict.
Test: m checkbuild
Change-Id: I4eb716fe59080c684bf942af8caafc8bb7abbd79
|
|
PiperOrigin-RevId: 227623749
Change-Id: I8daebe2234151fdac45b32d974d68ee41b34716f
Test: m LiveTv
|
|
This is a soong dependency
Test: m LiveTv
Change-Id: I78bec9dbe1622e72b8d93b590bf6e9105e2e1726
|
|
The only use was to always unhide live channels on a Nexus Player with
a SDK > O
PiperOrigin-RevId: 226928216
Change-Id: Ifa949934c64b1ba17c23450a48fd471973cd60b4
|
|
PiperOrigin-RevId: 226242349
Change-Id: I145f9427e6b08c74845fc9d5ec39b92bc6710b48
Test: m -j LiveTv
|
|
PiperOrigin-RevId: 226195173
Change-Id: Ie0272d84d56e2a43d95a1ff2c4b6859370ca6283
|
|
This manager is absent if the tuner is not enabled.
PiperOrigin-RevId: 226039646
Change-Id: Ib71a3a9abd361794048ea8917300a9f2187ea3d2
|
|
PiperOrigin-RevId: 225558022
Change-Id: I99fef3520c340067698aed6a0343b8952522fba3
|
|
See go/jetpack-test-android-migration
Test: make checkbuild
Change-Id: I53b88e63933c44f9bc9116a8ede5a2e3d6456766
|
|
PiperOrigin-RevId: 224656015
Change-Id: Iabbc87d8feb12567e3343d0d546463d4c4aeb4f6
|
|
Cloned from CL 222241056 by 'hg patch'.
Original change by nchalko@nchalko:copybara_1C855C64AE66326F8BB69F7A220D4FC5_0:9725:citc on 2018/11/20 07:13:45.
Live Channels: Import of http://pa/1180863
PiperOrigin-RevId: 222316043
Change-Id: Ie141f70a88ed54ee20a89c2cf1523546c3b08a4f
|
|
PiperOrigin-RevId: 222157840
Change-Id: Iabe6ce3a014545aae4abe8c7e92250196aa4af41
|
|
PiperOrigin-RevId: 221518179
Change-Id: I66a0df92e807719d6779e957d9612d0f3ac0c5d5
|
|
This allows more data objects to use AutoValue
Also updated guave to v23
PiperOrigin-RevId: 221493115
Change-Id: Ie9799fc224e73c9f28832b840024f256686c31d8
Test: m -j LiveTv
|
|
PiperOrigin-RevId: 219864217
Change-Id: Ib1888f8a0942a200dbdb65f73909883875fe510a
|
|
Neither of these locations contain robolectric tests:
packages/apps/TV/tuner/tests
packages/apps/TV/tests/common
but their build scripts included robolectric jars unnecessarily.
Test: make -j56 tv-test-common
Change-Id: I1fb25a745501ae94a9eda15d282c7efa6bf81942
|
|
PiperOrigin-RevId: 218909562
Change-Id: Ie1c781409dcc4f820cb6b23912d28f34f5793823
|
|
Test: m -j checkbuild
Change-Id: Ib9441ea8cdaa56bf0742dd7b4fd8eccd2a12b398
|