diff options
| author | John Pan <johnpan@google.com> | 2022-02-18 21:32:50 +0800 |
|---|---|---|
| committer | John Pan <johnpan@google.com> | 2022-03-02 06:45:36 +0000 |
| commit | cdd6a20a3c358458c9fd8a8dd839c0c233d27aed (patch) | |
| tree | ab08fcad3cfbff7b9c1fceb5bfc2f3ae62863a71 /res/layout-land | |
| parent | caf59966f58db3eaf3972babf7ad2af86d0f1373 (diff) | |
| download | ThemePicker-cdd6a20a3c358458c9fd8a8dd839c0c233d27aed.tar.gz | |
Fix GridFragment crash in landscape
Grid layout-land is out of date for long time. Just fix the crash first. And file an issue for launcher team to turn off grid selection https://buganizer.corp.google.com/issues/221129455
Screenshot: https://screenshot.googleplex.com/5zdrAZLQhnKLFGo
Bug: 220268751
Test: Manual
Change-Id: I4b8302961c56a05199e3485149bdd759c9125907
Diffstat (limited to 'res/layout-land')
| -rw-r--r-- | res/layout-land/fragment_grid_picker.xml | 60 |
1 files changed, 33 insertions, 27 deletions
diff --git a/res/layout-land/fragment_grid_picker.xml b/res/layout-land/fragment_grid_picker.xml index 2861e7da..0fd52c87 100644 --- a/res/layout-land/fragment_grid_picker.xml +++ b/res/layout-land/fragment_grid_picker.xml @@ -26,35 +26,41 @@ android:layout_width="match_parent" android:layout_height="match_parent"> - <LinearLayout - android:id="@+id/content_section" - android:layout_width="match_parent" - android:layout_height="match_parent" - android:orientation="horizontal"> - <FrameLayout - android:layout_width="0dp" - android:layout_height="match_parent" - android:layout_weight="1" - android:clipToPadding="false" - android:paddingTop="@dimen/preview_content_padding_top" - android:paddingBottom="@dimen/preview_content_padding_bottom" - android:background="?android:colorSecondary"> - <include layout="@layout/grid_preview_card"/> - </FrameLayout> + <androidx.constraintlayout.widget.ConstraintLayout + android:id="@+id/content_section" + android:layout_width="match_parent" + android:layout_height="match_parent"> - <FrameLayout - android:id="@+id/options_section" - android:layout_width="0dp" - android:layout_height="match_parent" - android:layout_weight="1" - android:paddingVertical="10dp"> + <FrameLayout + android:id="@+id/preview_card_container" + android:layout_width="0dp" + android:layout_height="match_parent" + android:background="?android:colorSecondary" + android:clipToPadding="false" + android:paddingBottom="@dimen/preview_content_padding_bottom" + android:paddingTop="@dimen/preview_content_padding_top" + app:layout_constraintHorizontal_weight="1" + app:layout_constraintLeft_toLeftOf="parent" + app:layout_constraintRight_toLeftOf="@+id/options_section"> + <include layout="@layout/grid_preview_card"/> + </FrameLayout> + + <FrameLayout + android:id="@+id/options_section" + android:layout_width="0dp" + android:layout_height="match_parent" + android:paddingVertical="10dp" + app:layout_constraintHorizontal_weight="1" + app:layout_constraintLeft_toRightOf="@+id/preview_card_container" + app:layout_constraintRight_toRightOf="parent"> + + <androidx.recyclerview.widget.RecyclerView + android:id="@+id/options_container" + android:layout_width="match_parent" + android:layout_height="match_parent"/> + </FrameLayout> + </androidx.constraintlayout.widget.ConstraintLayout> - <androidx.recyclerview.widget.RecyclerView - android:id="@+id/options_container" - android:layout_width="match_parent" - android:layout_height="match_parent"/> - </FrameLayout> - </LinearLayout> <androidx.core.widget.ContentLoadingProgressBar android:id="@+id/loading_indicator" style="@android:style/Widget.DeviceDefault.ProgressBar" |