summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorandroid-build-team Robot <android-build-team-robot@google.com>2020-06-04 01:03:19 +0000
committerandroid-build-team Robot <android-build-team-robot@google.com>2020-06-04 01:03:19 +0000
commitd34669f5d17ccdc663479aaa7a6ecf026c1e3dbd (patch)
tree34aec7a8d98e7b2428fd08701f69123fbe25b7a9
parent660b8feba01955602dcbebf7e59ebc6b41c6b21f (diff)
parent1def6b568e44d5623eaa263be5eb54b7cdbe71cb (diff)
downloadCellBroadcastService-d34669f5d17ccdc663479aaa7a6ecf026c1e3dbd.tar.gz
Snap for 6557338 from 1def6b568e44d5623eaa263be5eb54b7cdbe71cb to rvc-release
Change-Id: I5ee4fe52d3c289004b74d0aba55cc92862f36549
-rw-r--r--res/values-en-rAU/strings.xml3
-rw-r--r--res/values-en-rCA/strings.xml3
-rw-r--r--res/values-en-rGB/strings.xml3
-rw-r--r--res/values-en-rIN/strings.xml3
-rw-r--r--res/values-en-rXC/strings.xml3
-rw-r--r--res/values-es/strings.xml3
-rw-r--r--res/values-fr/strings.xml3
-rw-r--r--res/values-in/strings.xml3
-rw-r--r--res/values-ka/strings.xml3
-rw-r--r--res/values-lo/strings.xml3
-rw-r--r--res/values-pt/strings.xml3
-rw-r--r--src/com/android/cellbroadcastservice/CbGeoUtils.java5
-rw-r--r--src/com/android/cellbroadcastservice/CdmaServiceCategoryProgramHandler.java18
-rw-r--r--src/com/android/cellbroadcastservice/CellBroadcastHandler.java19
-rw-r--r--src/com/android/cellbroadcastservice/DefaultCellBroadcastService.java14
-rw-r--r--src/com/android/cellbroadcastservice/GsmCellBroadcastHandler.java18
-rw-r--r--src/com/android/cellbroadcastservice/GsmSmsCbMessage.java5
-rw-r--r--src/com/android/cellbroadcastservice/SmsCbHeader.java13
18 files changed, 76 insertions, 49 deletions
diff --git a/res/values-en-rAU/strings.xml b/res/values-en-rAU/strings.xml
index 6dafae9..5f5ac6e 100644
--- a/res/values-en-rAU/strings.xml
+++ b/res/values-en-rAU/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Evacuate immediately from coastal regions and riverside areas to a safer place such as high ground."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Stay calm and seek shelter nearby."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Emergency messages test"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alert issued by local government. More information coming soon."</string>
</resources>
diff --git a/res/values-en-rCA/strings.xml b/res/values-en-rCA/strings.xml
index 6dafae9..5f5ac6e 100644
--- a/res/values-en-rCA/strings.xml
+++ b/res/values-en-rCA/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Evacuate immediately from coastal regions and riverside areas to a safer place such as high ground."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Stay calm and seek shelter nearby."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Emergency messages test"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alert issued by local government. More information coming soon."</string>
</resources>
diff --git a/res/values-en-rGB/strings.xml b/res/values-en-rGB/strings.xml
index 6dafae9..5f5ac6e 100644
--- a/res/values-en-rGB/strings.xml
+++ b/res/values-en-rGB/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Evacuate immediately from coastal regions and riverside areas to a safer place such as high ground."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Stay calm and seek shelter nearby."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Emergency messages test"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alert issued by local government. More information coming soon."</string>
</resources>
diff --git a/res/values-en-rIN/strings.xml b/res/values-en-rIN/strings.xml
index 6dafae9..5f5ac6e 100644
--- a/res/values-en-rIN/strings.xml
+++ b/res/values-en-rIN/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Evacuate immediately from coastal regions and riverside areas to a safer place such as high ground."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Stay calm and seek shelter nearby."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Emergency messages test"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alert issued by local government. More information coming soon."</string>
</resources>
diff --git a/res/values-en-rXC/strings.xml b/res/values-en-rXC/strings.xml
index c05fe5c..7e1a164 100644
--- a/res/values-en-rXC/strings.xml
+++ b/res/values-en-rXC/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"‎‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‏‏‏‏‎‏‎‎‎‏‎‏‏‏‏‏‏‎‏‏‏‎‎‎‎‎‏‏‏‏‎‏‎‎‏‎‎‏‏‏‎‎‎‏‏‎‏‏‏‎‎‎‎‏‏‎‏‏‎‏‏‏‏‏‎‏‎‎Evacuate immediately from coastal regions and riverside areas to a safer place such as high ground.‎‏‎‎‏‎"</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"‎‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‏‏‏‏‏‏‏‎‏‏‎‎‏‎‎‏‏‏‎‎‎‎‏‎‏‎‎‏‏‏‎‏‎‏‏‏‎‏‏‎‎‎‏‏‏‎‎‎‏‎‏‎‏‎‏‏‏‏‎‎‎‎‏‎‎‏‎‎‎Stay calm and seek shelter nearby.‎‏‎‎‏‎"</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"‎‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‏‏‏‏‎‏‎‎‏‏‎‎‎‎‎‎‏‎‏‏‏‎‏‎‏‎‎‎‎‏‏‎‏‏‎‎‏‎‏‏‏‎‎‎‏‎‎‎‎‏‏‏‏‎‏‏‎‎‎‏‎‎‎‎‎‎‏‎Emergency messages test‎‏‎‎‏‎"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"‎‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‎‏‏‏‎‎‎‎‎‏‏‏‏‏‎‏‎‏‏‎‏‎‏‏‎‎‏‏‏‎‎‎‏‏‎‎‏‏‎‏‎‎‎‏‏‎‏‎‏‏‏‎‏‏‏‏‏‏‏‎‎‎‎‎‏‏‎‏‏‎‏‏‏‏‏‏‎‎Alert issued by local government. More information coming soon.‎‏‎‎‏‎"</string>
</resources>
diff --git a/res/values-es/strings.xml b/res/values-es/strings.xml
index 9112c72..97c615a 100644
--- a/res/values-es/strings.xml
+++ b/res/values-es/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Aléjate inmediatamente de las zonas costeras y situadas junto a un río para dirigirte hacia un lugar más seguro, por ejemplo, un terreno elevado."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Mantén la calma y busca refugio en algún lugar cercano."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Prueba de mensajes de emergencia"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alerta enviada por tu administración local. Pronto se dará más información."</string>
</resources>
diff --git a/res/values-fr/strings.xml b/res/values-fr/strings.xml
index 82a927b..f681721 100644
--- a/res/values-fr/strings.xml
+++ b/res/values-fr/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Évacuez immédiatement les zones côtières et les berges des fleuves, et réfugiez-vous dans un endroit plus sûr, comme un terrain surélevé."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Restez calme et cherchez un abri à proximité."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Test de messages d\'urgence"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alerte du gouvernement local. Plus d\'informations à venir."</string>
</resources>
diff --git a/res/values-in/strings.xml b/res/values-in/strings.xml
index 3e7a5d2..e63c29a 100644
--- a/res/values-in/strings.xml
+++ b/res/values-in/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Evakuasi segera dari daerah pesisir dan area tepi sungai ke tempat yang lebih aman seperti dataran tinggi."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Tetap tenang dan cari tempat berlindung terdekat."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Tes pesan darurat"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Peringatan dikeluarkan oleh pemerintah lokal. Informasi selengkapnya akan segera datang."</string>
</resources>
diff --git a/res/values-ka/strings.xml b/res/values-ka/strings.xml
index 84e106c..a607b86 100644
--- a/res/values-ka/strings.xml
+++ b/res/values-ka/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"დაუყოვნებლივ გადაინაცვლეთ სანაპირო რეგიონებიდან და მდინარისპირა ტერიტორიებიდან უსაფრთხო ადგილზე (მაგალითად, შემაღლებულ ადგილზე)."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"შეინარჩუნეთ სიმშვიდე და იპოვეთ ახლომდებარე თავშესაფარი."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"სატესტო საგანგებო შეტყობინება"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"ადგილობრივი მთავრობის მიერ გამოცემულია გაფრთხილება. დამატებითი ინფორმაცია მალე იქნება ხელმისაწვდომი."</string>
</resources>
diff --git a/res/values-lo/strings.xml b/res/values-lo/strings.xml
index 2739b4f..96f66f1 100644
--- a/res/values-lo/strings.xml
+++ b/res/values-lo/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"ອົບພະຍົບອອກຈາກເຂດຊາຍຝັ່ງທະເລ ແລະ ບໍລິເວນແມ່ນ້ຳໄປບ່ອນທີ່ປອດໄພກວ່າ ເຊັ່ນ: ບ່ອນສູງ ໂດຍທັນທີ."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"ໃຈເຢັນໆ ແລະ ຊອກຫາບ່ອນພັກຢູ່ໃກ້ໆ."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"ທົດສອບຂໍ້ຄວາມສຸກເສີນ"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"ການເຕືອນທີ່ອອກໂດຍລັດຖະບານທ້ອງຖິ່ນ. ຈະມີຂໍ້ມູນເພີ່ມເຕີມໃນໄວໆນີ້."</string>
</resources>
diff --git a/res/values-pt/strings.xml b/res/values-pt/strings.xml
index 41fa596..705ccb5 100644
--- a/res/values-pt/strings.xml
+++ b/res/values-pt/strings.xml
@@ -20,6 +20,5 @@
<string name="etws_primary_default_message_tsunami" msgid="2521384573822842618">"Saia imediatamente de regiões costeiras e áreas ribeirinhas e vá para um lugar mais seguro, como terrenos elevados."</string>
<string name="etws_primary_default_message_earthquake_and_tsunami" msgid="7826176257527823396">"Fique calmo e procure um abrigo por perto."</string>
<string name="etws_primary_default_message_test" msgid="2739829278266087553">"Teste de mensagens de emergência"</string>
- <!-- no translation found for etws_primary_default_message_others (3271611843755121534) -->
- <skip />
+ <string name="etws_primary_default_message_others" msgid="3271611843755121534">"Alerta emitido pelo governo local. Mais informações em breve."</string>
</resources>
diff --git a/src/com/android/cellbroadcastservice/CbGeoUtils.java b/src/com/android/cellbroadcastservice/CbGeoUtils.java
index f2098f7..b308909 100644
--- a/src/com/android/cellbroadcastservice/CbGeoUtils.java
+++ b/src/com/android/cellbroadcastservice/CbGeoUtils.java
@@ -74,10 +74,11 @@ public class CbGeoUtils {
geometries.add(new Polygon(vertices));
break;
default:
- Log.e(TAG, "Invalid geometry format " + geometryStr);
+ final String errorMessage = "Invalid geometry format " + geometryStr;
+ Log.e(TAG, errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_ERROR__TYPE__UNEXPECTED_GEOMETRY_FROM_FWK,
- geometryStr);
+ errorMessage);
}
}
return geometries;
diff --git a/src/com/android/cellbroadcastservice/CdmaServiceCategoryProgramHandler.java b/src/com/android/cellbroadcastservice/CdmaServiceCategoryProgramHandler.java
index 57006ee..6d1a6ce 100644
--- a/src/com/android/cellbroadcastservice/CdmaServiceCategoryProgramHandler.java
+++ b/src/com/android/cellbroadcastservice/CdmaServiceCategoryProgramHandler.java
@@ -113,10 +113,12 @@ public final class CdmaServiceCategoryProgramHandler extends WakeLockStateMachin
cdmaScpMessage.mOriginatingAddress, cdmaScpMessage.mSlotIndex,
cdmaScpMessage.mCallback);
} else {
- loge("handleMessage got object of type: " + message.obj.getClass().getName());
+ final String errorMessage =
+ "handleMessage got object of type: " + message.obj.getClass().getName();
+ loge(errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CELL_BROADCAST_MESSAGE_ERROR__TYPE__UNEXPECTED_CDMA_SCP_MESSAGE_TYPE_FROM_FWK,
- message.obj.getClass().getName());
+ errorMessage);
return false;
}
}
@@ -133,9 +135,12 @@ public final class CdmaServiceCategoryProgramHandler extends WakeLockStateMachin
private boolean handleServiceCategoryProgramData(ArrayList<CdmaSmsCbProgramData> programData,
String originatingAddress, int phoneId, Consumer<Bundle> callback) {
if (programData == null) {
- loge("handleServiceCategoryProgramData: program data list is null!");
+ final String errorMessage =
+ "handleServiceCategoryProgramData: program data list is null!";
+ loge(errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
- CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_ERROR__TYPE__CDMA_SCP_EMPTY);
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_ERROR__TYPE__CDMA_SCP_EMPTY,
+ errorMessage);
return false;
}
@@ -163,10 +168,11 @@ public final class CdmaServiceCategoryProgramHandler extends WakeLockStateMachin
public void onReceive(Context context, Intent intent) {
int resultCode = getResultCode();
if ((resultCode != Activity.RESULT_OK) && (resultCode != Intents.RESULT_SMS_HANDLED)) {
- loge("SCP results error: result code = " + resultCode);
+ final String errorMessage = "SCP results error: result code = " + resultCode;
+ loge(errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CELL_BROADCAST_MESSAGE_ERROR__TYPE__CDMA_SCP_HANDLING_ERROR,
- "result code = " + resultCode);
+ errorMessage);
return;
}
Bundle extras = getResultExtras(false);
diff --git a/src/com/android/cellbroadcastservice/CellBroadcastHandler.java b/src/com/android/cellbroadcastservice/CellBroadcastHandler.java
index 61ffe2c..70733b7 100644
--- a/src/com/android/cellbroadcastservice/CellBroadcastHandler.java
+++ b/src/com/android/cellbroadcastservice/CellBroadcastHandler.java
@@ -263,13 +263,19 @@ public class CellBroadcastHandler extends WakeLockStateMachine {
if (!isDuplicate((SmsCbMessage) message.obj)) {
handleBroadcastSms((SmsCbMessage) message.obj);
return true;
+ } else {
+ CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_FILTERED,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__TYPE__CDMA,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__FILTER__DUPLICATE_MESSAGE);
}
return false;
} else {
- loge("handleSmsMessage got object of type: " + message.obj.getClass().getName());
+ final String errorMessage =
+ "handleSmsMessage got object of type: " + message.obj.getClass().getName();
+ loge(errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CELL_BROADCAST_MESSAGE_ERROR__TYPE__UNEXPECTED_CDMA_MESSAGE_TYPE_FROM_FWK,
- message.obj.getClass().getName());
+ errorMessage);
return false;
}
}
@@ -516,6 +522,15 @@ public class CellBroadcastHandler extends WakeLockStateMachine {
logd("Device location is outside the broadcast area "
+ CbGeoUtils.encodeGeometriesToString(broadcastArea));
}
+ if (message.getMessageFormat() == SmsCbMessage.MESSAGE_FORMAT_3GPP) {
+ CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_FILTERED,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__TYPE__GSM,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__FILTER__GEOFENCED_MESSAGE);
+ } else if (message.getMessageFormat() == SmsCbMessage.MESSAGE_FORMAT_3GPP2) {
+ CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_FILTERED,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__TYPE__CDMA,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__FILTER__GEOFENCED_MESSAGE);
+ }
sendMessage(EVENT_BROADCAST_NOT_REQUIRED);
}
diff --git a/src/com/android/cellbroadcastservice/DefaultCellBroadcastService.java b/src/com/android/cellbroadcastservice/DefaultCellBroadcastService.java
index 1eddde1..d607034 100644
--- a/src/com/android/cellbroadcastservice/DefaultCellBroadcastService.java
+++ b/src/com/android/cellbroadcastservice/DefaultCellBroadcastService.java
@@ -71,7 +71,8 @@ public class DefaultCellBroadcastService extends CellBroadcastService {
public void onGsmCellBroadcastSms(int slotIndex, byte[] message) {
Log.d(TAG, "onGsmCellBroadcastSms received message on slotId=" + slotIndex);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_REPORTED,
- CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__TYPE__GSM);
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__TYPE__GSM,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__SOURCE__CB_SERVICE);
mGsmCellBroadcastHandler.onGsmCellBroadcastSms(slotIndex, message);
}
@@ -79,7 +80,8 @@ public class DefaultCellBroadcastService extends CellBroadcastService {
public void onCdmaCellBroadcastSms(int slotIndex, byte[] bearerData, int serviceCategory) {
Log.d(TAG, "onCdmaCellBroadcastSms received message on slotId=" + slotIndex);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_REPORTED,
- CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__TYPE__CDMA);
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__TYPE__CDMA,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__SOURCE__CB_SERVICE);
int[] subIds =
((SubscriptionManager) getSystemService(
Context.TELEPHONY_SUBSCRIPTION_SERVICE)).getSubscriptionIds(slotIndex);
@@ -104,7 +106,8 @@ public class DefaultCellBroadcastService extends CellBroadcastService {
String originatingAddress, Consumer<Bundle> callback) {
Log.d(TAG, "onCdmaScpMessage received message on slotId=" + slotIndex);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_REPORTED,
- CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__TYPE__CDMA_SPC);
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__TYPE__CDMA_SPC,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_REPORTED__SOURCE__CB_SERVICE);
mCdmaScpHandler.onCdmaScpMessage(slotIndex, new ArrayList<>(programData),
originatingAddress, callback);
}
@@ -131,9 +134,10 @@ public class DefaultCellBroadcastService extends CellBroadcastService {
try {
bData = BearerData.decode(context, bearerData, serviceCategory);
} catch (Exception e) {
- Log.e(TAG, "Error decoding bearer data e=" + e.toString());
+ final String errorMessage = "Error decoding bearer data e=" + e.toString();
+ Log.e(TAG, errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
- CELL_BROADCAST_MESSAGE_ERROR__TYPE__CDMA_DECODING_ERROR, e.toString());
+ CELL_BROADCAST_MESSAGE_ERROR__TYPE__CDMA_DECODING_ERROR, errorMessage);
return null;
}
Log.d(TAG, "MT raw BearerData = " + toHexString(bearerData, 0, bearerData.length));
diff --git a/src/com/android/cellbroadcastservice/GsmCellBroadcastHandler.java b/src/com/android/cellbroadcastservice/GsmCellBroadcastHandler.java
index 5077409..8449166 100644
--- a/src/com/android/cellbroadcastservice/GsmCellBroadcastHandler.java
+++ b/src/com/android/cellbroadcastservice/GsmCellBroadcastHandler.java
@@ -294,11 +294,17 @@ public class GsmCellBroadcastHandler extends CellBroadcastHandler {
SmsCbMessage cbMessage = handleGsmBroadcastSms(header, pdu, slotIndex);
if (cbMessage != null) {
if (isDuplicate(cbMessage)) {
+ CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_FILTERED,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__TYPE__GSM,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__FILTER__DUPLICATE_MESSAGE);
return false;
}
if (handleAreaInfoMessage(slotIndex, cbMessage)) {
log("Channel " + cbMessage.getServiceCategory() + " message processed");
+ CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_FILTERED,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__TYPE__GSM,
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_FILTERED__FILTER__AREA_INFO_MESSAGE);
return false;
}
@@ -308,11 +314,12 @@ public class GsmCellBroadcastHandler extends CellBroadcastHandler {
if (VDBG) log("Not handled GSM broadcasts.");
}
} else {
- loge("handleSmsMessage for GSM got object of type: "
- + message.obj.getClass().getName());
+ final String errorMessage = "handleSmsMessage for GSM got object of type: "
+ + message.obj.getClass().getName();
+ loge(errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CELL_BROADCAST_MESSAGE_ERROR__TYPE__UNEXPECTED_GSM_MESSAGE_TYPE_FROM_FWK,
- message.obj.getClass().getName());
+ errorMessage);
}
if (message.obj instanceof SmsCbMessage) {
return super.handleSmsMessage(message);
@@ -449,9 +456,10 @@ public class GsmCellBroadcastHandler extends CellBroadcastHandler {
return GsmSmsCbMessage.createSmsCbMessage(mContext, header, location, pdus, slotIndex);
} catch (RuntimeException e) {
- loge("Error in decoding SMS CB pdu", e);
+ final String errorMessage = "Error in decoding SMS CB pdu" + e.toString();
+ loge(errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
- CELL_BROADCAST_MESSAGE_ERROR__TYPE__GSM_INVALID_PDU, e.toString());
+ CELL_BROADCAST_MESSAGE_ERROR__TYPE__GSM_INVALID_PDU, errorMessage);
return null;
}
}
diff --git a/src/com/android/cellbroadcastservice/GsmSmsCbMessage.java b/src/com/android/cellbroadcastservice/GsmSmsCbMessage.java
index 8657c6b..2e14c83 100644
--- a/src/com/android/cellbroadcastservice/GsmSmsCbMessage.java
+++ b/src/com/android/cellbroadcastservice/GsmSmsCbMessage.java
@@ -209,10 +209,11 @@ public class GsmSmsCbMessage {
}
return new GeoFencingTriggerMessage(type, cbIdentifiers);
} catch (Exception ex) {
- Log.e(TAG, "create geo-fencing trigger failed, ex = " + ex.toString());
+ final String errorMessage = "create geo-fencing trigger failed, ex = " + ex.toString();
+ Log.e(TAG, errorMessage);
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CELL_BROADCAST_MESSAGE_ERROR__TYPE__GSM_INVALID_GEO_FENCING_DATA,
- ex.toString());
+ errorMessage);
return null;
}
}
diff --git a/src/com/android/cellbroadcastservice/SmsCbHeader.java b/src/com/android/cellbroadcastservice/SmsCbHeader.java
index 186d9f1..fb090ac 100644
--- a/src/com/android/cellbroadcastservice/SmsCbHeader.java
+++ b/src/com/android/cellbroadcastservice/SmsCbHeader.java
@@ -131,9 +131,11 @@ public class SmsCbHeader {
public SmsCbHeader(byte[] pdu) throws IllegalArgumentException {
if (pdu == null || pdu.length < PDU_HEADER_LENGTH) {
+ final String errorMessage = "Illegal PDU";
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
- CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_ERROR__TYPE__GSM_INVALID_HEADER_LENGTH);
- throw new IllegalArgumentException("Illegal PDU");
+ CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_ERROR__TYPE__GSM_INVALID_HEADER_LENGTH,
+ errorMessage);
+ throw new IllegalArgumentException(errorMessage);
}
if (pdu.length <= PDU_LENGTH_GSM) {
@@ -569,11 +571,12 @@ public class SmsCbHeader {
// UDH structure not supported
case 0x0e:
// Defined by the WAP forum not supported
+ final String errorMessage =
+ "Unsupported GSM dataCodingScheme " + dataCodingScheme;
CellBroadcastStatsLog.write(CellBroadcastStatsLog.CB_MESSAGE_ERROR,
CellBroadcastStatsLog.CELL_BROADCAST_MESSAGE_ERROR__TYPE__GSM_UNSUPPORTED_HEADER_DATA_CODING_SCHEME,
- "Unsupported GSM dataCodingScheme " + dataCodingScheme);
- throw new IllegalArgumentException("Unsupported GSM dataCodingScheme "
- + dataCodingScheme);
+ errorMessage);
+ throw new IllegalArgumentException(errorMessage);
case 0x0f:
if (((dataCodingScheme & 0x04) >> 2) == 0x01) {