From a791b70ab1a6700ff6ac49c3c2fe67add0cd32a5 Mon Sep 17 00:00:00 2001 From: Chidera Olibie Date: Tue, 9 Apr 2024 09:27:08 +0000 Subject: Remove NetHttpTests The NetHttpTests is not being run anywhere and has been a source of duplication with NetHttpCoverageTests. This cl removes this target and merges the xml to that of NetHttpCoverageTests which is our MTS target. Bug:b/329262802 Test: atest NetHttpCoverageTests Change-Id: Id1faead3bdea5ba5a65938dcd88d4ebca5a16ebc --- Cronet/tests/common/Android.bp | 30 ++++++++++ Cronet/tests/common/AndroidManifest.xml | 12 ++-- Cronet/tests/common/AndroidTest.xml | 8 ++- Cronet/tests/common/jarjar_excludes.txt | 29 +++++++++ Cronet/tests/common/res/raw/quicroot.pem | 19 ++++++ .../res/values/cronet-test-rule-configuration.xml | 20 +++++++ .../common/res/xml/network_security_config.xml | 47 +++++++++++++++ Cronet/tests/mts/Android.bp | 68 ---------------------- Cronet/tests/mts/AndroidManifest.xml | 33 ----------- Cronet/tests/mts/AndroidTest.xml | 58 ------------------ Cronet/tests/mts/jarjar_excludes.txt | 29 --------- Cronet/tests/mts/res/raw/quicroot.pem | 19 ------ .../res/values/cronet-test-rule-configuration.xml | 20 ------- .../tests/mts/res/xml/network_security_config.xml | 47 --------------- 14 files changed, 159 insertions(+), 280 deletions(-) create mode 100644 Cronet/tests/common/jarjar_excludes.txt create mode 100644 Cronet/tests/common/res/raw/quicroot.pem create mode 100644 Cronet/tests/common/res/values/cronet-test-rule-configuration.xml create mode 100644 Cronet/tests/common/res/xml/network_security_config.xml delete mode 100644 Cronet/tests/mts/Android.bp delete mode 100644 Cronet/tests/mts/AndroidManifest.xml delete mode 100644 Cronet/tests/mts/AndroidTest.xml delete mode 100644 Cronet/tests/mts/jarjar_excludes.txt delete mode 100644 Cronet/tests/mts/res/raw/quicroot.pem delete mode 100644 Cronet/tests/mts/res/values/cronet-test-rule-configuration.xml delete mode 100644 Cronet/tests/mts/res/xml/network_security_config.xml diff --git a/Cronet/tests/common/Android.bp b/Cronet/tests/common/Android.bp index 703f54479b..0b6eceffc7 100644 --- a/Cronet/tests/common/Android.bp +++ b/Cronet/tests/common/Android.bp @@ -25,6 +25,7 @@ package { // TODO: Consider merging with ConnectivityCoverageTests which is a collection of all // Connectivity tests being used for coverage. This will depend on how far we decide to // go with merging NetHttp and Tethering targets. +// Target used for coverage. Combines CTS tests and our MTS tests. android_test { name: "NetHttpCoverageTests", enforce_default_target_sdk_version: true, @@ -47,3 +48,32 @@ android_test { ], data: [":cronet_javatests_resources"], } + +// MTS-only specific targets. +java_genrule { + name: "net-http-test-jarjar-rules", + tool_files: [ + ":NetHttpTestsLibPreJarJar{.jar}", + "jarjar_excludes.txt", + ], + tools: [ + "jarjar-rules-generator", + ], + out: ["net_http_test_jarjar_rules.txt"], + cmd: "$(location jarjar-rules-generator) " + + "$(location :NetHttpTestsLibPreJarJar{.jar}) " + + "--prefix android.net.connectivity " + + "--excludes $(location jarjar_excludes.txt) " + + "--output $(out)", +} + +android_library { + name: "NetHttpTestsLibPreJarJar", + static_libs: [ + "cronet_aml_api_java", + "cronet_aml_java__testing", + "cronet_java_tests", + ], + sdk_version: "module_current", + min_sdk_version: "30", +} diff --git a/Cronet/tests/common/AndroidManifest.xml b/Cronet/tests/common/AndroidManifest.xml index b00fc90adb..418af8641b 100644 --- a/Cronet/tests/common/AndroidManifest.xml +++ b/Cronet/tests/common/AndroidManifest.xml @@ -19,12 +19,16 @@ xmlns:tools="http://schemas.android.com/tools" package="com.android.net.http.tests.coverage"> - - + + + + + + diff --git a/Cronet/tests/common/AndroidTest.xml b/Cronet/tests/common/AndroidTest.xml index 7646a04f84..bb7ed11473 100644 --- a/Cronet/tests/common/AndroidTest.xml +++ b/Cronet/tests/common/AndroidTest.xml @@ -24,10 +24,14 @@