diff options
| author | bodamnam <bodamnam@google.com> | 2023-02-02 03:17:30 +0000 |
|---|---|---|
| committer | bodamnam <bodamnam@google.com> | 2023-02-02 04:45:54 +0000 |
| commit | 836e0e8a2c1812174c89b3ed2c48892eb7965bc9 (patch) | |
| tree | 2ef2ffa8fd1ad0afae900259d692f177d9f3d029 /tests/native | |
| parent | 867810ba6a383c75f6ee6101c14a1b9ac0b08eeb (diff) | |
| download | ImsMedia-836e0e8a2c1812174c89b3ed2c48892eb7965bc9.tar.gz | |
Fix the rtcp counter is not increased in MediaQualityAnalyzer
1) Fix the rtcp packet counter initalized.
2) Move rtp packet null check into the rtp type statement
3) Add checking the rtp inactivity time is not zero to prevent the
notify every sec when the rtp inactivty time is set 0.
4) Add more UT to cover the case that rtp and rtcp inactivity
Bug: 267543974
Test: atest ImsMediaNativeTest and verified by device test in live
network
Change-Id: Ie2c70079c330860811eed9e9ef34c76af7411ff4
Diffstat (limited to 'tests/native')
| -rw-r--r-- | tests/native/service/src/com/android/telephony/imsmedia/lib/libimsmedia/core/audio/MediaQualityAnalyzerTest.cpp | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/tests/native/service/src/com/android/telephony/imsmedia/lib/libimsmedia/core/audio/MediaQualityAnalyzerTest.cpp b/tests/native/service/src/com/android/telephony/imsmedia/lib/libimsmedia/core/audio/MediaQualityAnalyzerTest.cpp index 56bed86e..a979dd4a 100644 --- a/tests/native/service/src/com/android/telephony/imsmedia/lib/libimsmedia/core/audio/MediaQualityAnalyzerTest.cpp +++ b/tests/native/service/src/com/android/telephony/imsmedia/lib/libimsmedia/core/audio/MediaQualityAnalyzerTest.cpp @@ -225,7 +225,19 @@ TEST_F(MediaQualityAnalyzerTest, TestCollectTxPackets) EXPECT_EQ(quality2.getNumRtpPacketsTransmitted(), numPackets); } -TEST_F(MediaQualityAnalyzerTest, TestRtpInactivity) +TEST_F(MediaQualityAnalyzerTest, TestRtpInactivityNotRunning) +{ + EXPECT_CALL(mCallback, onEvent(kAudioCallQualityChangedInd, _, _)).Times(1); + EXPECT_CALL(mCallback, onEvent(kImsMediaEventMediaQualityStatus, _, _)).Times(0); + MediaQualityThreshold threshold; + threshold.setRtpInactivityTimerMillis(std::vector<int32_t>{0}); + mAnalyzer->setMediaQualityThreshold(threshold); + mAnalyzer->start(); + mCondition.wait_timeout(2100); // 2.1 sec + mAnalyzer->stop(); +} + +TEST_F(MediaQualityAnalyzerTest, TestRtpInactivityRunning) { EXPECT_CALL(mCallback, onEvent(kAudioCallQualityChangedInd, _, _)).Times(2); EXPECT_CALL(mCallback, onEvent(kImsMediaEventMediaQualityStatus, _, _)).Times(3); @@ -278,7 +290,7 @@ TEST_F(MediaQualityAnalyzerTest, TestRtcpInactivity) mAnalyzer->SendEvent(kCollectPacketInfo, kStreamRtcp); - mCondition.wait_timeout(2100); // 2.1 sec + mCondition.wait_timeout(3100); // 3.1 sec MediaQualityStatus quality3 = mFakeCallback.getMediaQualityStatus(); EXPECT_EQ(quality3.getRtcpInactivityTimeMillis(), 2000); |