diff options
| author | Elliott Hughes <enh@google.com> | 2022-02-17 16:46:16 -0800 |
|---|---|---|
| committer | Elliott Hughes <enh@google.com> | 2022-09-27 20:16:02 +0000 |
| commit | 2cb8c94ea696f48c62b1eb9ffac2b0217dbe82f7 (patch) | |
| tree | 2cf2a4a2f4680b43313d0f0a481e2d5b2c9dceb2 /pairing_connection/Android.bp | |
| parent | ff2446d0bf3d4b396c2800045fb54aba855893de (diff) | |
| download | adb-2cb8c94ea696f48c62b1eb9ffac2b0217dbe82f7.tar.gz | |
Remove dead CLOEXEC/NONBLOCK code.
You can't set O_NONBLOCK with F_SETFD. You need F_SETFL for that.
Unfortunately, the kernel will silently no-op invalid flags in F_SETFD,
so you'll never know.
Worse than that, calling F_SETFD with O_NONBLOCK actually _clears_ the
previous successful setting of O_CLOEXEC. So all this code is just a
very long-winded way to do nothing.
Test: treehugger
Change-Id: I77e3a181ee0966d85d8d885054fc11891278ab33
Diffstat (limited to 'pairing_connection/Android.bp')
| -rw-r--r-- | pairing_connection/Android.bp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pairing_connection/Android.bp b/pairing_connection/Android.bp index 3557810d..2b33bee8 100644 --- a/pairing_connection/Android.bp +++ b/pairing_connection/Android.bp @@ -176,7 +176,7 @@ cc_library { static_libs: [ // Statically link libadb_crypto because it is not - // ABI-stable. + // ABI-stable. "libadb_crypto", "libadb_protos", ], |