diff options
| author | Andre Furtado <afurtado@google.com> | 2016-09-15 01:43:47 +0000 |
|---|---|---|
| committer | android-build-merger <android-build-merger@google.com> | 2016-09-15 01:43:47 +0000 |
| commit | ef3bdb5f6eed90b525c3d771079ac75aebac7ba9 (patch) | |
| tree | d1e53da429ea6575ecafffd8e19b58b658287d41 | |
| parent | 44108eca8b4528a7ab68fe83e2a03c549ef57bb1 (diff) | |
| parent | d0c5b20403b3924cee67e0e72d745b10b0691eac (diff) | |
| download | Mms-ef3bdb5f6eed90b525c3d771079ac75aebac7ba9.tar.gz | |
Bump up MMS network request timeout and don't retry
am: d0c5b20403
Change-Id: Ib4d728cca94b52b861a5c9a184a9c2dfd526bee2
| -rw-r--r-- | src/com/android/mms/service/MmsNetworkManager.java | 3 | ||||
| -rw-r--r-- | src/com/android/mms/service/MmsRequest.java | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/src/com/android/mms/service/MmsNetworkManager.java b/src/com/android/mms/service/MmsNetworkManager.java index 67b0af6..c2e2f6a 100644 --- a/src/com/android/mms/service/MmsNetworkManager.java +++ b/src/com/android/mms/service/MmsNetworkManager.java @@ -31,7 +31,8 @@ import com.android.mms.service.exception.MmsNetworkException; */ public class MmsNetworkManager { // Timeout used to call ConnectivityManager.requestNetwork - private static final int NETWORK_REQUEST_TIMEOUT_MILLIS = 60 * 1000; + // Given that the telephony layer will retry on failures, this timeout should be high enough. + private static final int NETWORK_REQUEST_TIMEOUT_MILLIS = 30 * 60 * 1000; // Wait timeout for this class, a little bit longer than the above timeout // to make sure we don't bail prematurely private static final int NETWORK_ACQUIRE_TIMEOUT_MILLIS = diff --git a/src/com/android/mms/service/MmsRequest.java b/src/com/android/mms/service/MmsRequest.java index e4ebdc4..4eeac08 100644 --- a/src/com/android/mms/service/MmsRequest.java +++ b/src/com/android/mms/service/MmsRequest.java @@ -147,7 +147,7 @@ public abstract class MmsRequest { result = SmsManager.MMS_ERROR_IO_ERROR; } else { // Execute long retryDelaySecs = 2; - // Try multiple times of MMS HTTP request + // Try multiple times of MMS HTTP request, depending on the error. for (int i = 0; i < RETRY_TIMES; i++) { try { networkManager.acquireNetwork(requestId); @@ -182,7 +182,7 @@ public abstract class MmsRequest { } catch (MmsNetworkException e) { LogUtil.e(requestId, "MMS network acquiring failure", e); result = SmsManager.MMS_ERROR_UNABLE_CONNECT_MMS; - // Retry + break; } catch (MmsHttpException e) { LogUtil.e(requestId, "HTTP or network I/O failure", e); result = SmsManager.MMS_ERROR_HTTP_FAILURE; |