diff options
| author | Timothy Knight <tknight@google.com> | 2014-09-04 23:25:39 -0700 |
|---|---|---|
| committer | Timothy Knight <tknight@google.com> | 2014-09-04 23:25:39 -0700 |
| commit | bd001196d0480a9ed3f45956d5b3da7ae9a5637a (patch) | |
| tree | a9324e903670d68388769f774c0db50fd82b3260 /apps | |
| parent | c65822cd038068f70853913ee7d7732cb56e752d (diff) | |
| download | pdk-bd001196d0480a9ed3f45956d5b3da7ae9a5637a.tar.gz | |
CameraITS: Added some TODOs to remove hard-coded capture settings
Change-Id: I47d3570cd87141eea34c4d61a68c2d7c04cc0b5d
Diffstat (limited to 'apps')
4 files changed, 4 insertions, 1 deletions
diff --git a/apps/CameraITS/pymodules/its/device.py b/apps/CameraITS/pymodules/its/device.py index cbf579e..ea763ef 100644 --- a/apps/CameraITS/pymodules/its/device.py +++ b/apps/CameraITS/pymodules/its/device.py @@ -291,7 +291,7 @@ class ItsSession(object): format(s) of the captured image. The formats may be "yuv", "jpeg", "dng", "raw", or "raw10". The default is a YUV420 frame ("yuv") corresponding to a full sensor frame. - + Note that one or more surfaces can be specified, allowing a capture to request images back in multiple formats (e.g.) raw+yuv, raw+jpeg, yuv+jpeg, raw+yuv+jpeg. If the size is omitted for a surface, the diff --git a/apps/CameraITS/tests/scene0/test_capture_result_dump.py b/apps/CameraITS/tests/scene0/test_capture_result_dump.py index ceac43a..40c3e45 100644 --- a/apps/CameraITS/tests/scene0/test_capture_result_dump.py +++ b/apps/CameraITS/tests/scene0/test_capture_result_dump.py @@ -27,6 +27,7 @@ def main(): with its.device.ItsSession() as cam: # Arbitrary capture request exposure values; image content is not # important for this test, only the metadata. + # TODO: Update test to ensure manual settings are within legal ranges. req = its.objects.manual_capture_request(100, 10*1000*1000) req["android.statistics.lensShadingMapMode"] = 1 cap = cam.do_capture(req, cam.CAP_YUV) diff --git a/apps/CameraITS/tests/scene0/test_metadata.py b/apps/CameraITS/tests/scene0/test_metadata.py index ff39290..861c071 100644 --- a/apps/CameraITS/tests/scene0/test_metadata.py +++ b/apps/CameraITS/tests/scene0/test_metadata.py @@ -31,6 +31,7 @@ def main(): # Arbitrary capture request exposure values; image content is not # important for this test, only the metadata. props = cam.get_camera_properties() + # TODO: Update test to ensure manual settings are within legal ranges. req = its.objects.manual_capture_request(100, 10*1000*1000) cap = cam.do_capture(req, cam.CAP_YUV) md = cap["metadata"] diff --git a/apps/CameraITS/tests/scene0/test_param_sensitivity_burst.py b/apps/CameraITS/tests/scene0/test_param_sensitivity_burst.py index ad94446..f906287 100644 --- a/apps/CameraITS/tests/scene0/test_param_sensitivity_burst.py +++ b/apps/CameraITS/tests/scene0/test_param_sensitivity_burst.py @@ -34,6 +34,7 @@ def main(): sens_range = props['android.sensor.info.sensitivityRange'] sens_step = (sens_range[1] - sens_range[0]) / NUM_STEPS sensitivities = range(sens_range[0], sens_range[1], sens_step) + # TODO: Update test to ensure manual settings are within legal ranges. reqs = [its.objects.manual_capture_request(s,10*1000*1000) for s in sensitivities] |