Age | Commit message (Collapse) | Author |
|
tm-qpr2-release
Change-Id: I614521571ccb18531e0955ade5f3318753b62e8e
|
|
This CL adds a --no-verify-format rule to ktlint.py so that preuploads
can ignore more formatting rules. This will be used by projects who
already use ktfmt for formatting new files, so that useful ktlint errors
(like unused variables) are not hidden by a ton of ktlint formatting
issues which we are now mostly ignoring.
Bug: 235461679
Test: Manual
Change-Id: I324bcaf4e9e2b087201810343471a55f2434339f
|
|
In ag/18798895, I broke the early exit condition when the ktlint hook
would receive 0 Kotlin files. Since that CL, ktlint would always run on
a big number of files if th CL didn't contain any change in a .kt or
.kts file.
Bug: 235461679
Test: Manual
Change-Id: Iaf21df8e85943229c1d832b186825b41cf231b2d
|
|
Given that we are going to use ktfmt to format our files and that ktlint
and ktfmt don't agree on indentation rules, let's configure ktlint to
disable rules that clash with ktfmt. The configuration is the same as in
google3 [1] with those additional changes:
* Indentation is set to 4.
* wrapping rule is disabled. This is not disabled in google3 yet
because this rules is causing issue starting from release 0.45 and
google3 is on 0.43 (while we are on 0.46/master).
[1] http://google3/third_party/kotlin/ktlint/.editorconfig
Bug: 235461679
Test: Manual
Change-Id: I851e511db06ae38ea89be0f90a86746a1fa92dac
|
|
The jar has been taken from ab/8635833 artifacts.
(ktlint-0.46.0-SNAPSHOT-all.jar)
Test: prebuilds/ktlint/ktlint.py --format --file <kotlin file>
Fixes: 231305338
Change-Id: Ib57e759460bac8fd584188ef4499792680212a2c
|
|
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/2039263
Change-Id: I19b3e07f40b439b1fc05e691d0fe83c59ba92b79
|
|
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/2039263
Change-Id: Ib7570461614545ade211b74182e07f201e791a46
|
|
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/2039263
Change-Id: Idf4b94f83ccc613bf23b224eb8a46a3c1696f905
|
|
Decode it as utf-8 to fix the output.
Fixes: 226370498
Test: manual
Change-Id: Ia4317fe445c6705dbf24bdc57a7f4a88f7ebc0f5
|
|
5ec9533779 am: df4d427876
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/1889435
Change-Id: I017bcfa23734dcb37d2fdeaaf76021f5ac88fed9
|
|
5ec9533779
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/1889435
Change-Id: I9e675633c7cc1bcfa2d5eaa35cbe950da0631286
|
|
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/1889435
Change-Id: I490384fdcdd6931f17b594f7a720350ca4c17477
|
|
Original change: https://android-review.googlesource.com/c/platform/prebuilts/ktlint/+/1889435
Change-Id: Ia0074d2988063f0ad6b1501bcb9fc6d6274eede4
|
|
Change-Id: I3b3b5064c8d52ddd241785914ae1e58b8d2150e1
Test: Run ktlint as a repo hook
Bug: 186749906
|
|
stag-aosp-master am: 12e4973a91 -s ours am: 0c32278962 am: a3f6c8dd6a am: aafe201a62 -s ours
am skip reason: subject contains skip directive
Change-Id: Iaf8f1216221ff698ffd76006e930238700728a48
|
|
stag-aosp-master am: 12e4973a91 -s ours am: 0c32278962 am: a3f6c8dd6a
Change-Id: I07f8f7a0534c7bde97a782f706e2bfdc23bee0e5
|
|
stag-aosp-master am: 12e4973a91 -s ours am: 0c32278962
Change-Id: I7dfc828749407b71ebb24dad697f478768a834ea
|
|
stag-aosp-master am: 12e4973a91 -s ours
am skip reason: subject contains skip directive
Change-Id: I8ec0d2698e0fc9efc4c48fe51d49f4cd2310eec7
|
|
Bug: 151763422
Change-Id: I1e496b24ea5019024e07305d9602bf1fe1c631bf
|
|
qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master am: af28e03956 -s ours am: 1eeba3ee4a am: 30cd40fbfb am: f1404fdfe2 -s ours
am skip reason: subject contains skip directive
Change-Id: Idba0341142dd055be3afd7f72cafb9cf0d2b40fb
|
|
qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master am: af28e03956 -s ours am: 1eeba3ee4a am: 30cd40fbfb
Change-Id: I13f8cc6136ebaf702bcea914cfdb4525b4522fd5
|
|
qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master am: af28e03956 -s ours am: 1eeba3ee4a
Change-Id: I7c883c9e9e62eed06dd14d06c2f447e3de006b26
|
|
stag-aosp-master am: af28e03956
Change-Id: Ib4bd094a9d5981f626548f60f7e5ab668af67cea
|
|
qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master am: af28e03956 -s ours
am skip reason: subject contains skip directive
Change-Id: Id4ee8a980066458165abb60d20e01720ded96eaf
|
|
Bug: 151763422
Change-Id: I148c6df6242214e29fe6a4bd30bf344deb3e610b
|
|
Change-Id: I72a81853ebd9198e5d45f43e3572d8d546d1182d
|
|
Change-Id: I518018b99901f627b741db42c7e69dde3f76318e
|
|
Change-Id: I5d32460315b2f2423a81ed6fad33a5a17aca6ec1
|
|
Change-Id: I4b9869ff2603d7f2aea39572d47a46fbae394bee
|
|
|
|
This reverts commit a54e654be36a2bf8021ca7f838d86a92b70af642.
Reason for revert: was merged to master, but is suppose to go to crane only branch
Change-Id: I1825b8f0191608dccdaa19640df34c4f4d6acb83
|
|
|
|
This CL adds custom build ktlink.r4a.jar to run presumbit check while
`repo upload`. Previous version wasn't working so developer were using
`repo upload --no-verify`, which results in a lot of inconsistensies
with codestyle as well as absence other checks (style checks, checks for
proper api update, etc). This CL adds proper jar file only, script that
will automate this jar update when new r4a version is released will be
soon.
Note, that in current version ktlint "spacing between operator" rule is
turned off so ktlint won't complain about `padding=50.dp` without spaces.
Important: Please note, that unused import rule is temporary turned off due to
`import com.google.r4a.composer` which looks like unused to ktlint. We
need to patch all such imports with `// ktlint-disable`
Bug: b/126198541
Test: Test by run `repo upload` with incorrectly and correctly formatted file
Change-Id: Ib0e8e05cb83703632af69a3fc4d2a9cbfe43513a
|
|
am: ddaa13e7fb -s ours
am skip reason: subject contains skip directive
Change-Id: I2c178b8273b877b87b951736c23a554d1f3f7f4a
|
|
Bug: 120848293
Change-Id: Ic40de7600a0242c71a624a0ecc3506dcde016f1b
|
|
MERGE am: 6550cab4ef -s ours am: 678b022bbd -s ours
am: 4a69c81dc2 -s ours
Change-Id: I8c7f7ce8ac0749e00f657a5309a5df1c6b211c16
|
|
MERGE am: 6550cab4ef -s ours
am: 678b022bbd -s ours
Change-Id: Icb3bf8c0faac7a13e14694729add3b86877232ab
|
|
am: 6550cab4ef -s ours
Change-Id: I2143df19c215802dfb2a2688567b0f3e3d0880d3
|
|
Change-Id: Iddcf9ee1c3f81b1c6bd485eef9f1116e94356de2
|
|
MERGE am: ee5cce34ca -s ours
am: 362e045571 -s ours
Change-Id: I8cb1453bfa7cdb10b78b403edb0b59ce2caae91d
|
|
MERGE
am: ee5cce34ca -s ours
Change-Id: I0ac0df9994b849a3134e6c44d417b8ee750937ef
|
|
Change-Id: Idb4877cf0af45c3dd6c45b15484cbde7d020b38e
|
|
am: 29fcfd35cd
Change-Id: I7ba1ea305487b99f88c96ceeed8d59f0e173011e
|
|
am: fbd130341d
Change-Id: I19773231b420157d8590cd9b7e8e3964411f4646
|
|
am: 1c01f3ef54
Change-Id: I2d045824760642a09acfcde086b8aaf4c85e6b99
|
|
am: 6a8a150711
Change-Id: I28dfd7e9e23f4b652debfca3a0e89982157ac9ac
|
|
am: 35bd6b25ff
Change-Id: I70e61326429b264d787e555662685832d3cf1728
|
|
am: 62ffb1fbdf
Change-Id: I42da181a3d3eb0297e0a0d00d49a7adda0eb5588
|
|
am: 3f75e31a21
Change-Id: I8ef96b64bc31b590ad7237a04dd5f4d6b792c8ed
|
|
am: 8e55ec3c1e
Change-Id: I8fdb7745081e705150f71a747b77c04a5b72ed1f
|