diff options
author | Maciej Żenczykowski <maze@google.com> | 2021-01-14 13:20:41 -0800 |
---|---|---|
committer | Maciej Żenczykowski <maze@google.com> | 2021-01-23 18:30:07 +0000 |
commit | 8ed7c0f9b9e656501b55782fd8397cdabef8039f (patch) | |
tree | 7a25fee20d355d04ccc15160125fde234d37e24b /libbpf_android | |
parent | cdf85a3148696e880c0e03c4b1d17f091ad57560 (diff) | |
download | bpf-8ed7c0f9b9e656501b55782fd8397cdabef8039f.tar.gz |
BpfMap - fix a clang warning: misc-unconventional-assign-operator
//system/bpf/libbpf_android:libbpf_android_test clang-tidy BpfMapTest.cpp
system/bpf/libbpf_android/include/bpf/BpfMap.h:138:5: warning: operator=() should return 'BpfMap&' [misc-unconventional-assign-operator]
void operator=(BpfMap<Key, Value>&& other) noexcept {
^
Test: builds without warnings
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I0bb0d42f58bba58c7b9220f062453d827438e85a
Diffstat (limited to 'libbpf_android')
-rw-r--r-- | libbpf_android/include/bpf/BpfMap.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/libbpf_android/include/bpf/BpfMap.h b/libbpf_android/include/bpf/BpfMap.h index c42801a..bdffc0f 100644 --- a/libbpf_android/include/bpf/BpfMap.h +++ b/libbpf_android/include/bpf/BpfMap.h @@ -133,10 +133,11 @@ class BpfMap { return *this; } - // Move constructor - void operator=(BpfMap<Key, Value>&& other) noexcept { + // Move assignment operator + BpfMap<Key, Value>& operator=(BpfMap<Key, Value>&& other) noexcept { mMapFd = std::move(other.mMapFd); other.reset(-1); + return *this; } void reset(base::unique_fd fd) = delete; |