summaryrefslogtreecommitdiff
path: root/dbus_properties_proxy.h
AgeCommit message (Collapse)Author
2015-09-03License shill to Apache2Peter Qiu
This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi, the NOTICE was added with a copy of the Apache2 license and MODULE_LICENSE_* file was added. BUG=23587594 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
2015-06-18shill: Top-level files a-e: Switch pointer/ref spacingPaul Stewart
Switch to Chrome style spacing. BUG=chromium:501026 TEST=Unit tests Change-Id: Idb7252202e142098999fe0672712aded7d369259 Reviewed-on: https://chromium-review.googlesource.com/278038 Reviewed-by: Rebecca Silberstein <silberst@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>
2015-01-30shill: fix -Winconsistent-missing-override warning found by clang.Yunlian Jiang
This cleans up the warning '-Winconsistent-missing-override'. BUG=chromium:453588 TEST=USE='vpn wimax cellular' FEATURES="test" emerge-amd64-generic shill Change-Id: I39056b312f616eccc916bce7fb6ad8ab8ca6ca55 Reviewed-on: https://chromium-review.googlesource.com/244692 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org>
2014-09-03shill: Include base/macros.h instead of base/basictypes.hBen Chan
shill no longer uses the integer types from base/basictypes.h. It should simply include base/macros.h for the DISALLOW_COPY_AND_ASSIGN macro instead. BUG=None TEST=`USE='cellular wimax' FEATURES=test emerge-$BOARD platform2` Change-Id: I9b350c1bd9eff88e2c87de2ef8d607e90049e102 Reviewed-on: https://chromium-review.googlesource.com/216055 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org>
2014-08-14shill: Add C++11 override specifier to destructors of derived classes.Ben Chan
BUG=None TEST=`USE=wimax FEATURES=test emerge-$BOARD platform2` Change-Id: I88d4e29165869b26924cccb94ac940dc8961c312 Reviewed-on: https://chromium-review.googlesource.com/212267 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org>
2014-07-25shill: Sort headers alphabetically (build/include_alpha)Alex Vakulenko
We are going to enable build/include_alpha linter warning soon, so in preparation for this, fixed the warnings in shill. BUG=None TEST=cpplint.py --filter=-build/include_order,+build/include_alpha shill/* Change-Id: I113ed7f9dd3f465a3f660599320cdb434e7cc214 Reviewed-on: https://chromium-review.googlesource.com/209636 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
2014-07-04shill: Fix header guards to conform to coding style.Ben Chan
BUG=chromium:385849 TEST=Tested the following: 1. `USE='cellular wimax' FEATURES=test emerge-$BOARD platform2` 2. `cpplint.py --filter=-build/include_order shill/*.h` reports no 'build/header_guard' issue. Change-Id: I1a3972a1f88e5001550eccd561633bd4e5c5faba Reviewed-on: https://chromium-review.googlesource.com/206680 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org>
2014-06-18shill: Fix most of warnings from cpplintAlex Vakulenko
Fix most cpplinter's warnings. On a few occasisions, the warnings produced were false-positives, so added explicit // NOLINT comment overrides. There were a few instances of disallowed non-const reference usage (reported as runtime/reference error by cpplint) for "DBus::Error &error" which should potentially be changed to pointers to comply with C++ coding style but I will let Shill owners do that since there is quite a few of those and the change isn't brain-dead simple... BUG=None TEST=platform2 still compiles and all unit tests pass. Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e Reviewed-on: https://chromium-review.googlesource.com/204164 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
2013-10-25Add shill to Platform2Liam McLoughlin
VerifyPath tests were removed. They don't make sense in the Platform2 world, where they're part of the same ebuild and so aren't installed into the sysroot by test time. BUG=chromium:220003 TEST=Run ALL the trybots CQ-DEPEND=CL:56290 Change-Id: Icf79aa729b1ed125743686c4536fe1b59183fed2 Reviewed-on: https://chromium-review.googlesource.com/63659 Reviewed-by: Liam McLoughlin <lmcloughlin@chromium.org> Tested-by: Liam McLoughlin <lmcloughlin@chromium.org> Commit-Queue: Liam McLoughlin <lmcloughlin@chromium.org>
2013-09-11shill: cellular: Remove all direct property accessors from MM1 proxies.Arman Uguray
BUG=chromium:288068 TEST=Build and run unit tests. Change-Id: I7e7804c37b82bc0726cecf7ec08e2ee51165719c Reviewed-on: https://chromium-review.googlesource.com/168853 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Arman Uguray <armansito@chromium.org> Tested-by: Arman Uguray <armansito@chromium.org>
2012-04-26shill: dbus_properties: Convert to callbacks instead of delegatesJason Glasgow
Use callbacks instead of proxies on the DBusPropertiesProxyInterface. This makes the class consistent with the other proxies used for cellular support, and in subsequent CLs will allow access to the GetAll function without having to implement the Delegate interface. Add a GetStrings method to dbus_properties. BUG=none TEST=run unit tests, run on a machine validate that changes in signal strength are noticed. Change-Id: I23e47f011c39a23f406ef62a52a5a613e55c55ed Reviewed-on: https://gerrit.chromium.org/gerrit/20640 Reviewed-by: Jason Glasgow <jglasgow@chromium.org> Tested-by: Jason Glasgow <jglasgow@chromium.org> Commit-Ready: Jason Glasgow <jglasgow@chromium.org>
2011-10-24shill: Rename *ProxyListener to *ProxyDelegate to conform to coding style.Darin Petkov
Coding style requires multiple inheritance only from pure interfaces tagged with the Interface suffix. Chromium style allows Delegate instead of Interface. After this change, a *ProxyInterface class is the RPC proxy abstraction provided for unit test purposes, and a *ProxyDelegate can be inherited and implemented by proxy clients to catch RPC callbacks. For example, ModemProxyInterface is the interface to a ModemManager.Modem service, implemented concretely for dbus-c++ by the ModemProxy class; all callbacks get rerouted by ModemProxy to a ModemProxyDelegate. BUG=chromium-os:19115 TEST=unit tests Change-Id: I75c4c5c1f256b338e665e77f58972ab75f39490e Reviewed-on: http://gerrit.chromium.org/gerrit/10562 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Ready: Darin Petkov <petkov@chromium.org>
2011-08-08shill: On Service::Connect, connect the modem device to the network.Darin Petkov
Also, uncouple the DBusProperties signal callbacks from Modem to make the proxy implementation more consistent with the other proxies. BUG=chromium-os:18727 TEST=unit tests Change-Id: Icdddea8d2a30803150f2a159fdc5a719e960f95d Reviewed-on: http://gerrit.chromium.org/gerrit/5444 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Chris Masone <cmasone@chromium.org>
2011-07-26shill: Create and register a Cellular device for each ModemManager.Modem.Darin Petkov
BUG=chromium-os:17818 TEST=unit tests Change-Id: Ic35adf35c8021f4c9689e72ddd03776948d036c1 Reviewed-on: http://gerrit.chromium.org/gerrit/4711 Reviewed-by: Darin Petkov <petkov@chromium.org> Tested-by: Darin Petkov <petkov@chromium.org>
2011-07-20shill: Create Modem instances for ModemManager.Modem paths.Darin Petkov
Each Modem instance will manage a single ModemManager.Modem and a single Cellular device. BUG=chromium-os:17818 TEST=unit tests, tested on device Change-Id: I4798224f0bc824bd6d1177e6a6b89f65ca4725ba Reviewed-on: http://gerrit.chromium.org/gerrit/4356 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Chris Masone <cmasone@chromium.org>