diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2017-10-18 16:28:14 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2017-10-20 15:46:36 -0700 |
| commit | 373d3c7257fa815d0b9ee8f16874470a6002042e (patch) | |
| tree | 2488faeb9a5a2dfd9f76054bd4ba001b4806ffb3 /micro_bench | |
| parent | d7bf23ae7b93ec93b8b7c2ce98eaa2ea94f387aa (diff) | |
| download | extras-373d3c7257fa815d0b9ee8f16874470a6002042e.tar.gz | |
Use -Werror in system/extras
* Remove unused variables.
* Fix redefined macro warnings.
* Fix sign-compare warnings.
* Fix 'return false' in main().
* Keep existing warnings to fix later.
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ib92ef5297693595fb84ed4f8e61665bda4cee312
Diffstat (limited to 'micro_bench')
| -rw-r--r-- | micro_bench/Android.mk | 2 | ||||
| -rw-r--r-- | micro_bench/micro_bench.cpp | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/micro_bench/Android.mk b/micro_bench/Android.mk index 0655536e..843a2e5e 100644 --- a/micro_bench/Android.mk +++ b/micro_bench/Android.mk @@ -6,6 +6,7 @@ LOCAL_SRC_FILES := micro_bench.cpp LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES) LOCAL_MODULE_TAGS := debug LOCAL_MODULE := micro_bench +LOCAL_CFLAGS := -Wall -Werror -Wno-error=unused-variable LOCAL_MULTILIB := both LOCAL_MODULE_STEM_32 := $(LOCAL_MODULE) @@ -19,6 +20,7 @@ LOCAL_SRC_FILES := micro_bench.cpp LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES) LOCAL_MODULE_TAGS := debug LOCAL_MODULE := micro_bench_static +LOCAL_CFLAGS := -Wall -Werror -Wno-error=unused-variable LOCAL_STATIC_LIBRARIES = libc libm LOCAL_FORCE_STATIC_EXECUTABLE := true diff --git a/micro_bench/micro_bench.cpp b/micro_bench/micro_bench.cpp index 4d3177da..05cc54ed 100644 --- a/micro_bench/micro_bench.cpp +++ b/micro_bench/micro_bench.cpp @@ -400,6 +400,7 @@ int benchmarkMemset(const char *name, const command_data_t &cmd_data, void_func_ int benchmarkMemsetCold(const char *name, const command_data_t &cmd_data, void_func_t func) { memset_func_t memset_func = reinterpret_cast<memset_func_t>(func); COLD_ONE_BUF(name, cmd_data, ;, memset_func(buf, l, size)); + (void)buffer_size; return 0; } @@ -430,7 +431,7 @@ int benchmarkMemmoveBackwards(const char *name, const command_data_t &cmd_data, memcpy_func_t memmove_func = reinterpret_cast<memcpy_func_t>(func); size_t size = cmd_data.args[0]; - size_t alloc_size = size * 2 + 3 * cmd_data.dst_align; + size_t alloc_size = size * 2 + 3 * cmd_data.dst_align; // should alloc_size be used? uint8_t* src = allocateAlignedMemory(size, cmd_data.src_align, cmd_data.src_or_mask); if (!src) return -1; |