diff options
| author | Yabin Cui <yabinc@google.com> | 2021-03-01 10:07:55 -0800 |
|---|---|---|
| committer | Yabin Cui <yabinc@google.com> | 2021-03-01 18:10:36 -0800 |
| commit | fbbe9e5cf0407c1cec719e6d47c4d6f433be2cb5 (patch) | |
| tree | 0a82fd4a047fb2c5f4652ae2f4816c2fac240960 /simpleperf/cmd_merge.cpp | |
| parent | f4089ed75c62d0a092c9b5d5b22f8cafebf302b5 (diff) | |
| download | extras-fbbe9e5cf0407c1cec719e6d47c4d6f433be2cb5.tar.gz | |
simpleperf: keep binaries for debugging failed unwinding cases.
We need binaries for debugging failed unwinding cases. So
change --keep-failed-unwinding-stack-data to
--keep-failed-unwinding-debug-info, which stores both stack data and
used binaries for failed unwinding cases.
To store binaries in perf.data:
1. Add debug_unwind feature section to keep binary path and size info.
2. Add debug_unwind_file feature section to keep binary data.
Bug: 181075274
Test: run simpleperf_unit_test
Change-Id: Id8759051ba520f1be9c2ef6030143f8b4bafc7cb
Diffstat (limited to 'simpleperf/cmd_merge.cpp')
| -rw-r--r-- | simpleperf/cmd_merge.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/simpleperf/cmd_merge.cpp b/simpleperf/cmd_merge.cpp index 9d413083..d1ac6dca 100644 --- a/simpleperf/cmd_merge.cpp +++ b/simpleperf/cmd_merge.cpp @@ -333,7 +333,7 @@ class MergeCommand : public Command { feature == PerfFileFormat::FEAT_META_INFO || feature == PerfFileFormat::FEAT_CMDLINE) { std::vector<char> data; if (!readers_[0]->ReadFeatureSection(feature, &data) || - !writer_->WriteFeature(feature, data)) { + !writer_->WriteFeature(feature, data.data(), data.size())) { return false; } } else if (feature == PerfFileFormat::FEAT_BUILD_ID) { |