diff options
| author | Yabin Cui <yabinc@google.com> | 2018-06-18 17:44:27 -0700 |
|---|---|---|
| committer | Yabin Cui <yabinc@google.com> | 2018-06-18 17:51:01 -0700 |
| commit | 8b5a352cbfd70935eeeae507e165018812f18991 (patch) | |
| tree | af5cf06db56e3f4aa9f86f330d6e7e80380cded6 /simpleperf/cmd_record.cpp | |
| parent | 9e00d29710a22146f7a2a525807540c7a6a0bbd3 (diff) | |
| download | extras-8b5a352cbfd70935eeeae507e165018812f18991.tar.gz | |
simpleperf: remove RecordCache.
When using debug-unwind cmd for system wide profiling result, I
found it might took a lot of memory because RecordCache cached
too many samples. Since simpleperf no longer relies on RecordCache
to sort records, I think it is fine to remove RecordCache instead
of fixing it.
Bug: none.
Test: run simpleperf_unit_test.
Change-Id: Ie28ce17b4158add455004a56bbdac745f9d05f19
Diffstat (limited to 'simpleperf/cmd_record.cpp')
| -rw-r--r-- | simpleperf/cmd_record.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/simpleperf/cmd_record.cpp b/simpleperf/cmd_record.cpp index 5664f0b7..01a2c9f3 100644 --- a/simpleperf/cmd_record.cpp +++ b/simpleperf/cmd_record.cpp @@ -1273,7 +1273,7 @@ bool RecordCommand::PostUnwindRecords() { auto callback = [this](std::unique_ptr<Record> record) { return SaveRecordAfterUnwinding(record.get()); }; - return reader->ReadDataSection(callback, false); + return reader->ReadDataSection(callback); } bool RecordCommand::JoinCallChains() { @@ -1321,7 +1321,7 @@ bool RecordCommand::JoinCallChains() { sr.UpdateUserCallChain(ips); return record_file_writer_->WriteRecord(sr); }; - return reader->ReadDataSection(record_callback, false); + return reader->ReadDataSection(record_callback); } bool RecordCommand::DumpAdditionalFeatures( |