summaryrefslogtreecommitdiff
path: root/simpleperf/cmd_record.cpp
diff options
context:
space:
mode:
authorYabin Cui <yabinc@google.com>2019-01-29 17:06:42 -0800
committerYabin Cui <yabinc@google.com>2019-01-31 14:31:09 -0800
commita24cf9633453220a75e34e339ee5b9c593198da4 (patch)
tree8d6cde15487da77cb7dea1512137241b55da80b1 /simpleperf/cmd_record.cpp
parent58a4d50ece679525d1c3a7fcd1bfa04701041a08 (diff)
downloadextras-a24cf9633453220a75e34e339ee5b9c593198da4.tar.gz
simpleperf: change the way running cts test.
To test profiling debuggable apps, simpleperf cts test sets default app package name for all tests. But it has below problems: 1. It is not explicit in the code of each test, thus harder to maintain. 2. It doesn't profile an app process, thus can't test profiling Java code. 3. Some tests are not suitable to run with app package name and have to disable app package name manually. This will be true for more tests if testing profileable apps. So this CL changes the way running cts tests: 1. Remove default app package name, so all tests by default run in shell context. 2. Add explict tests to test profiling debuggable apps and profileable apps. Bug: 118835348 Test: run CtsSimpleperfTestCases. Change-Id: I7eacaf0dc66357dbb339a6e6d4c5ca694afa2619
Diffstat (limited to 'simpleperf/cmd_record.cpp')
-rw-r--r--simpleperf/cmd_record.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/simpleperf/cmd_record.cpp b/simpleperf/cmd_record.cpp
index 0de8ed32..1deaa597 100644
--- a/simpleperf/cmd_record.cpp
+++ b/simpleperf/cmd_record.cpp
@@ -252,7 +252,6 @@ class RecordCommand : public Command {
// to stdout/stderr, which is a problem when we use '--app' option. So ignore SIGPIPE to
// finish properly.
signal(SIGPIPE, SIG_IGN);
- app_package_name_ = GetDefaultAppPackageName();
}
bool Run(const std::vector<std::string>& args);