diff options
author | Yabin Cui <yabinc@google.com> | 2017-05-18 17:11:32 -0700 |
---|---|---|
committer | Yabin Cui <yabinc@google.com> | 2017-05-18 18:35:26 -0700 |
commit | dcb2a3e580f155bb28621c4cbad019d104e8f300 (patch) | |
tree | fa795a0a463d2d219e83281844b3ea3bc7f24361 /simpleperf/cmd_record_test.cpp | |
parent | bc3f1c9f57f749cc616f9aa5b390bc2f70b15507 (diff) | |
download | extras-dcb2a3e580f155bb28621c4cbad019d104e8f300.tar.gz |
simpleperf: enable two options by default.
Enable dumping symbols in record cmd by default,
and change --dump-symbols option into --no-dump-symbols option.
Show brief call graph in report cmd by default,
and change --brief-callgraph option into --full-callgraph option.
Make the change because these two behaviors are always recommended.
Bug: None.
Test: run simpleperf_unit_test.
Change-Id: Icff6a843a7f46c56313500f4da119aa5118a57e5
Diffstat (limited to 'simpleperf/cmd_record_test.cpp')
-rw-r--r-- | simpleperf/cmd_record_test.cpp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/simpleperf/cmd_record_test.cpp b/simpleperf/cmd_record_test.cpp index ec0605a4..0d0c44a7 100644 --- a/simpleperf/cmd_record_test.cpp +++ b/simpleperf/cmd_record_test.cpp @@ -254,11 +254,11 @@ static void CheckKernelSymbol(const std::string& path, bool need_kallsyms, TEST(record_cmd, kernel_symbol) { TemporaryFile tmpfile; - ASSERT_TRUE(RunRecordCmd({}, tmpfile.path)); + ASSERT_TRUE(RunRecordCmd({"--no-dump-symbols"}, tmpfile.path)); bool success; CheckKernelSymbol(tmpfile.path, true, &success); ASSERT_TRUE(success); - ASSERT_TRUE(RunRecordCmd({"--no-dump-kernel-symbols"}, tmpfile.path)); + ASSERT_TRUE(RunRecordCmd({"--no-dump-symbols", "--no-dump-kernel-symbols"}, tmpfile.path)); CheckKernelSymbol(tmpfile.path, false, &success); ASSERT_TRUE(success); } @@ -303,26 +303,26 @@ static void CheckDsoSymbolRecords(const std::string& path, *success = true; } -TEST(record_cmd, dump_symbols) { +TEST(record_cmd, no_dump_symbols) { TemporaryFile tmpfile; ASSERT_TRUE(RunRecordCmd({}, tmpfile.path)); bool success; - CheckDsoSymbolRecords(tmpfile.path, false, &success); - ASSERT_TRUE(success); - ASSERT_TRUE(RunRecordCmd({"--dump-symbols"}, tmpfile.path)); CheckDsoSymbolRecords(tmpfile.path, true, &success); ASSERT_TRUE(success); + ASSERT_TRUE(RunRecordCmd({"--no-dump-symbols"}, tmpfile.path)); + CheckDsoSymbolRecords(tmpfile.path, false, &success); + ASSERT_TRUE(success); if (IsDwarfCallChainSamplingSupported()) { std::vector<std::unique_ptr<Workload>> workloads; CreateProcesses(1, &workloads); std::string pid = std::to_string(workloads[0]->GetPid()); ASSERT_TRUE(RunRecordCmd({"-p", pid, "-g"}, tmpfile.path)); bool success; - CheckDsoSymbolRecords(tmpfile.path, false, &success); - ASSERT_TRUE(success); - ASSERT_TRUE(RunRecordCmd({"-p", pid, "-g", "--dump-symbols"}, tmpfile.path)); CheckDsoSymbolRecords(tmpfile.path, true, &success); ASSERT_TRUE(success); + ASSERT_TRUE(RunRecordCmd({"-p", pid, "-g", "--no-dump-symbols"}, tmpfile.path)); + CheckDsoSymbolRecords(tmpfile.path, false, &success); + ASSERT_TRUE(success); } } @@ -333,7 +333,7 @@ TEST(record_cmd, dump_kernel_symbols) { } system("echo 0 >/proc/sys/kernel/kptr_restrict"); TemporaryFile tmpfile; - ASSERT_TRUE(RunRecordCmd({"--dump-symbols", "-a", "-o", tmpfile.path, "sleep", "1"})); + ASSERT_TRUE(RunRecordCmd({"-a", "-o", tmpfile.path, "sleep", "1"})); std::unique_ptr<RecordFileReader> reader = RecordFileReader::CreateInstance(tmpfile.path); ASSERT_TRUE(reader != nullptr); std::map<int, SectionDesc> section_map = reader->FeatureSectionDescriptors(); |