diff options
| author | Yabin Cui <yabinc@google.com> | 2016-07-29 16:40:40 -0700 |
|---|---|---|
| committer | Yabin Cui <yabinc@google.com> | 2016-08-01 13:41:42 -0700 |
| commit | dec43c18d06415a955b8f32355bca925be901905 (patch) | |
| tree | aa8f4f614c819728391f353096e32a12cbf595ae /simpleperf/read_apk.h | |
| parent | 8f5d3f48bfcb3a3bd1c93a1fb7cc40b06521f857 (diff) | |
| download | extras-dec43c18d06415a955b8f32355bca925be901905.tar.gz | |
simpleperf: print warning message when failed to read symbol table from elf file.
Change return type of read elf functions to ElfStatus, and print warning message
based on situation.
Add corresponding test.
Bug: 29193936
Change-Id: Ie449f8be34cb579962cb73f4be3df9e4997270ca
Test: run simpleperf_unit_test.
Diffstat (limited to 'simpleperf/read_apk.h')
| -rw-r--r-- | simpleperf/read_apk.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/simpleperf/read_apk.h b/simpleperf/read_apk.h index eb7c206d..65b5df83 100644 --- a/simpleperf/read_apk.h +++ b/simpleperf/read_apk.h @@ -91,12 +91,12 @@ bool IsValidApkPath(const std::string& apk_path); std::string GetUrlInApk(const std::string& apk_path, const std::string& elf_filename); std::tuple<bool, std::string, std::string> SplitUrlInApk(const std::string& path); -bool GetBuildIdFromApkFile(const std::string& apk_path, const std::string& elf_filename, - BuildId* build_id); +ElfStatus GetBuildIdFromApkFile(const std::string& apk_path, const std::string& elf_filename, + BuildId* build_id); -bool ParseSymbolsFromApkFile(const std::string& apk_path, const std::string& elf_filename, - const BuildId& expected_build_id, - const std::function<void(const ElfFileSymbol&)>& callback); +ElfStatus ParseSymbolsFromApkFile(const std::string& apk_path, const std::string& elf_filename, + const BuildId& expected_build_id, + const std::function<void(const ElfFileSymbol&)>& callback); #endif // SIMPLE_PERF_READ_APK_H_ |