From c7743b6aef51b43f4541b1d11b359a221a34e0a9 Mon Sep 17 00:00:00 2001 From: Yabin Cui Date: Wed, 16 Mar 2022 23:25:26 +0000 Subject: Revert "simpleperf: change default aux buffer size to 1M." This reverts commit 847ed0bb3d9f1cc6db98b56774d4214b60e3c712. Reason for revert: no longer needed after using scatter-gather mode in ETR. Bug: 213522686 Change-Id: I5113c77dd08f987432610ee33a94d29a3d03f2ec --- simpleperf/cmd_record.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'simpleperf/cmd_record.cpp') diff --git a/simpleperf/cmd_record.cpp b/simpleperf/cmd_record.cpp index f206b808..b84bcfab 100644 --- a/simpleperf/cmd_record.cpp +++ b/simpleperf/cmd_record.cpp @@ -114,9 +114,7 @@ constexpr size_t DEFAULT_CALL_CHAIN_JOINER_CACHE_SIZE = 8 * 1024 * 1024; static constexpr size_t kRecordBufferSize = 64 * 1024 * 1024; static constexpr size_t kSystemWideRecordBufferSize = 256 * 1024 * 1024; -// If the kernel needs to allocate continuous DMA memory for ETR (like when IOMMU for ETR isn't -// available), requesting 4M ETR buffer may fail and cause warning. So use 1M buffer here. -static constexpr size_t kDefaultAuxBufferSize = 1 * 1024 * 1024; +static constexpr size_t kDefaultAuxBufferSize = 4 * 1024 * 1024; // On Pixel 3, it takes about 1ms to enable ETM, and 16-40ms to disable ETM and copy 4M ETM data. // So make default period to 100ms. @@ -223,7 +221,7 @@ class RecordCommand : public Command { "--aux-buffer-size Set aux buffer size, only used in cs-etm event type.\n" " Need to be power of 2 and page size aligned.\n" " Used memory size is (buffer_size * (cpu_count + 1).\n" -" Default is 1M.\n" +" Default is 4M.\n" "--no-inherit Don't record created child threads/processes.\n" "--cpu-percent Set the max percent of cpu time used for recording.\n" " percent is in range [1-100], default is 25.\n" -- cgit v1.2.3