diff options
| author | Jorge Lucangeli Obes <jorgelo@chromium.org> | 2015-01-29 15:18:46 -0800 |
|---|---|---|
| committer | Gilad Arnold <garnold@google.com> | 2015-08-10 23:11:52 -0700 |
| commit | 5affd8895f6879153fce488c3f92271349eeadc9 (patch) | |
| tree | 152243a908d67a18adcb974bcc37a1658132f053 /iptables.cc | |
| parent | 0e7a658e0f72b0d2113f5c06136620236dde96f9 (diff) | |
| download | firewalld-5affd8895f6879153fce488c3f92271349eeadc9.tar.gz | |
firewalld: make D-Bus methods simple.
BUG=chromium:435400
TEST=unit tests
Change-Id: I4afa4264332ed3ef2eb0e4fafbbb7917e5c995ba
Reviewed-on: https://chromium-review.googlesource.com/244492
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Trybot-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Diffstat (limited to 'iptables.cc')
| -rw-r--r-- | iptables.cc | 28 |
1 files changed, 8 insertions, 20 deletions
diff --git a/iptables.cc b/iptables.cc index ca0a8d7..e70f161 100644 --- a/iptables.cc +++ b/iptables.cc @@ -26,32 +26,20 @@ IpTables::~IpTables() { PlugAllHoles(); } -bool IpTables::PunchTcpHole(chromeos::ErrorPtr* error, - uint16_t in_port, - bool* out_success) { - *out_success = PunchHole(in_port, &tcp_holes_, kProtocolTcp); - return true; +bool IpTables::PunchTcpHole(uint16_t in_port) { + return PunchHole(in_port, &tcp_holes_, kProtocolTcp); } -bool IpTables::PunchUdpHole(chromeos::ErrorPtr* error, - uint16_t in_port, - bool* out_success) { - *out_success = PunchHole(in_port, &udp_holes_, kProtocolUdp); - return true; +bool IpTables::PunchUdpHole(uint16_t in_port) { + return PunchHole(in_port, &udp_holes_, kProtocolUdp); } -bool IpTables::PlugTcpHole(chromeos::ErrorPtr* error, - uint16_t in_port, - bool* out_success) { - *out_success = PlugHole(in_port, &tcp_holes_, kProtocolTcp); - return true; +bool IpTables::PlugTcpHole(uint16_t in_port) { + return PlugHole(in_port, &tcp_holes_, kProtocolTcp); } -bool IpTables::PlugUdpHole(chromeos::ErrorPtr* error, - uint16_t in_port, - bool* out_success) { - *out_success = PlugHole(in_port, &udp_holes_, kProtocolUdp); - return true; +bool IpTables::PlugUdpHole(uint16_t in_port) { + return PlugHole(in_port, &udp_holes_, kProtocolUdp); } bool IpTables::PunchHole(uint16_t port, |