summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-18OWNERS += bug component am: f0933bad94 am: 3188ea20f0 am: 3ad01f0e6f am: ↵android-14.0.0_r45android-14.0.0_r44android-14.0.0_r43android-14.0.0_r42android-14.0.0_r41android-14.0.0_r40android-14.0.0_r39android-14.0.0_r38android14-d2-s5-releaseandroid14-d2-s4-releaseandroid14-d2-s3-releaseandroid14-d2-s2-releaseandroid14-d2-s1-releaseandroid14-d2-releaseSteven Moreland
cfa0abe20f Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2541031 Change-Id: Ia00dbb58681b09cb2eac0a521265d759bfa41587 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17OWNERS += bug component am: f0933bad94 am: 3188ea20f0 am: 3ad01f0e6fandroid-vts-14.0_r4android-vts-14.0_r3android-vts-14.0_r2android-cts-14.0_r4android-cts-14.0_r3android-cts-14.0_r2android14-tests-releaseandroid14-tests-devandroid14-devSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2541031 Change-Id: I5c82d328ac89cb9317bdfda41198401f46042d15 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17OWNERS += bug component am: f0933bad94 am: 3188ea20f0Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2541031 Change-Id: I4c1d75df3dee858414818176fdf245d5c2e2ad4c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17OWNERS += bug component am: f0933bad94Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2541031 Change-Id: I69ef5b22838ac4741327752e0534bd94dc87d483 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17OWNERS += bug componentSteven Moreland
Not automated yet? Fixes: 278493766 Test: N/A Change-Id: Ib4d8d5194478c8fc5d427902ea4db4ed11b227ba
2023-04-03Add a method to get the pointer to the ring buffer am: d66eb85122Devin Moore
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libfmq/+/22433300 Change-Id: I7b017ea2c828b23cb274275ff594c266ab995f0c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03Add a method to get the pointer to the ring bufferDevin Moore
Use the method in the fuzzer to poke around the mapped memory more deterministically. Test: fmq_fuzzer Bug: 276568689 Change-Id: I65b24e5c9e165e16ac224aa2a2e1a68147d02d0e
2023-03-28Merge "Expect min sizes for certain grantors" into udc-dev am: bd176052b8Devin Moore
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libfmq/+/22255482 Change-Id: I38a4ea2e5bfe66ac60ebd7115b4ae9b2836f61ed Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28Merge "Expect min sizes for certain grantors" into udc-devDevin Moore
2023-03-28Remove the sanitizers from fmq_fuzzer am: d5951f918a am: c953684c34 am: ↵Devin Moore
c21a6c7e32 am: ffb0acdb64 Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2509957 Change-Id: I1367f4f99d3bb7eb21baa635be47a307c2f93eb2 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28Remove the sanitizers from fmq_fuzzer am: d5951f918a am: c953684c34 am: ↵Devin Moore
c21a6c7e32 Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2509957 Change-Id: I483ca2efefac7cf05724d8a065b908dc766c64ac Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28Remove the sanitizers from fmq_fuzzer am: d5951f918a am: c953684c34Devin Moore
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2509957 Change-Id: I6ea06f18baadca8379e5d12f0d2051e08a2255f8 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28Remove the sanitizers from fmq_fuzzer am: d5951f918aDevin Moore
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2509957 Change-Id: I30deb0aec84380deb346ea1bc91e4579f8550d99 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27Remove the sanitizers from fmq_fuzzerandroid-u-beta-1-gplDevin Moore
The fuzzer is built with the expected sanitizers in the fuzzing infra, and sometimes we want to build and run it without sanitizers. One case where AddressSanitizer fails to handle a crash and fails to provide a backtrace prevents any useful debugging. Test: fmq_fuzzer Bug: 272625466 Change-Id: I8d4608bc8b7b461abc4ce909ae6b1472c038c93a
2023-03-24Expect min sizes for certain grantorsDevin Moore
We expect the read/write counters to be uint64_t and the event flag word to be uint32_t, so make sure the grantors are set up correctly to handle that. Larger sizes for the sections are unnecessary, but fine. Test: fmq_fuzzer with clusterfuzz testcases Bug: 272625466 Bug: 270834177 Change-Id: I01eae1efb2f23963981e31edcb5f91e1b0a2825f
2023-01-25Reduce blocking wait time for fuzzerDevin Moore
This was causing long execution times. Test: fmq_fuzzer Bug: none Change-Id: I23464fa76589a26da799580297af9cc79a2f37a6
2022-12-12Merge "[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours" ↵Automerger Merge Worker
into stage-aosp-master am: 1e932ab8d1 -s ours am: 0e4bb9789d -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: Ifc3e2fd77ce406b0b5e5042a5605d01492caeae4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours am: ↵Xin Li
62a08c97d4 -s ours am: bdb6d5c227 -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: Ifa10237e00f99b3d7ebe3fb4949b1c8d4f2f2ffb Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours am: ↵Xin Li
54b4a7b53e -s ours am: 0e6b6d91b6 -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: I777ff3991c0f1bc72a894f1d16307baa1992872b Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10Merge "[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours" ↵Automerger Merge Worker
into stage-aosp-master am: 1e932ab8d1 -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: Iff21ae06ff1c7e1f600886b2258d5f88bae8fc41 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours am: ↵Xin Li
62a08c97d4 -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: I721870677ea7e5aad4b08d7f0146c62fbad67d03 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours am: ↵Xin Li
54b4a7b53e -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: I93c12354e425f58db6c87f47fc16ead47ef03f9f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09Merge "[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s ours" ↵Automerger Merge Worker
into stage-aosp-master
2022-12-09[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s oursXin Li
am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: I1d843057dca6b73f3e4d5eeba37446fb8c33b113 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09[automerger skipped] Merge Android 13 QPR1 am: 62b0bcc1a2 -s oursXin Li
am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 98f3a08b2f is already in history Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2338077 Change-Id: Ic540aa946754288c57b73f1682320c7edee1c600 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09Merge Android 13 QPR1main-16k-with-phonesXin Li
Bug: 261731544 Merged-In: I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d Change-Id: Ic26a741d85acc46dbf9c1467eb465d887e4d7183
2022-10-12Merge "Don't allow queues of size 0"Devin Moore
2022-10-12Merge "fmq_fuzzer: use the correct size for user supplied memory"Devin Moore
2022-10-12Don't allow queues of size 0Devin Moore
It doesn't make sense, and can cause problems. Bug: 251774648 Bug: 252935198 Test: fmq_fuzzer with reproducer test cases Change-Id: I1e0e94f72f4b4ae41733fadd2d857fa850a8aaa6
2022-10-11fmq_fuzzer: use the correct size for user supplied memoryDevin Moore
In the case that we supply a user defined FD for the data buffer, we need to make sure it is the correct size for the queue we are requesting. Test: fmq_fuzzer with reproducer test case in bug Bug: 252473606 Change-Id: Iba67ded6ec348fb85d6049cee6924c131a8ca96c
2022-10-11[automerger skipped] Merge tm-qpr-dev-plus-aosp-without-vendor@9129937 am: ↵Xin Li
723384263e -s ours am: e9b8b7dd32 -s ours am skip reason: Merged-In I36eb223602fc67951adbe8d6dcd179db2a01476e with SHA-1 cdf8d33b16 is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libfmq/+/20137244 Change-Id: I397c367b685d8a463379426f36a9da6c4e04d679 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11[automerger skipped] Merge tm-qpr-dev-plus-aosp-without-vendor@9129937 am: ↵Xin Li
723384263e -s ours am skip reason: Merged-In I36eb223602fc67951adbe8d6dcd179db2a01476e with SHA-1 cdf8d33b16 is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libfmq/+/20137244 Change-Id: I93b60f2b6659455944bc2296413f354ee9b54ecc Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10Avoid getIntegralInRange with invalid rangeDevin Moore
Range of 1 to 0 will abort, and getQuantumCount can return 0 for a queue with size of 0. Range of 0 to 0 will not consume any bytes from the FDP, so we can't loop around that case expecting the FDP to run out. Changing to range 0 to quantumCount + 1 give some extra coverage and avoids these issues. Test: fmq_fuzzer with reproducer in bug Bug: 252302860 Change-Id: Ib95af7f80c795761461ab2904737323162ba4129
2022-10-06Merge tm-qpr-dev-plus-aosp-without-vendor@9129937Xin Li
Bug: 248070379 Merged-In: I36eb223602fc67951adbe8d6dcd179db2a01476e Change-Id: Icf0b03ab70e7d48bef7b9d1a4bd9e03a0430fddd
2022-10-03fmq_fuzzer: fuzz manually created grantors and descriptorsDevin Moore
There is nothing preventing users from creating their own grantors and descriptors. It's not recomended. Test: fmq_fuzzer Bug: 244713317 Change-Id: I9db8f13c895e78e4604499479537d0d888716953
2022-10-03fmq_fuzzer: remove duplicated codeDevin Moore
Fun with templates to remove duplicated code. Prep for changes that would add more duplicated code. Test: fmq_fuzzer Bug: 244713317 Change-Id: Icb8844068178543836e98fdd711e7806e2561d27
2022-10-01[automerger skipped] Protect against malformed grantors am: 98f3a08b2f am: ↵Devin Moore
f6c75607cc -s ours am skip reason: Merged-In I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d with SHA-1 d931906af5 is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libfmq/+/20082287 Change-Id: I4dc38f6deb7ede687c7e5a7d51ed6013546e1e64 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01Protect against malformed grantors am: 98f3a08b2fDevin Moore
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libfmq/+/20082287 Change-Id: Ia6fb0c8f9463aea0a932420f234aa3b8fc5cfbc9 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29Protect against malformed grantorsandroid-13.0.0_r82android-13.0.0_r81android-13.0.0_r80android-13.0.0_r74android-13.0.0_r73android-13.0.0_r72android-13.0.0_r66android-13.0.0_r65android-13.0.0_r64android-13.0.0_r60android-13.0.0_r59android-13.0.0_r58android13-qpr3-c-s8-releaseandroid13-qpr3-c-s7-releaseandroid13-qpr3-c-s6-releaseandroid13-qpr3-c-s5-releaseandroid13-qpr3-c-s4-releaseandroid13-qpr3-c-s3-releaseandroid13-qpr3-c-s2-releaseandroid13-qpr3-c-s12-releaseandroid13-qpr3-c-s11-releaseandroid13-qpr3-c-s10-releaseandroid13-qpr3-c-s1-releaseDevin Moore
Grantors might have invalid fdIndex and extent values. Test: atest fmq_unit_tests Test: running POC from bug on device Bug: 244713317 Change-Id: I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d (cherry picked from commit d931906af5e245eeea4a2749e9153be0180d1bae) Merged-In: I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d
2022-09-29Merge "Protect against malformed grantors"Devin Moore
2022-09-29Protect against malformed grantorsDevin Moore
Grantors might have invalid fdIndex and extent values. Test: atest fmq_unit_tests Test: running POC from bug on device Bug: 244713317 Change-Id: I17bd7da9bd47fe7b89ddb890d476d2f66f4c0d0d
2022-09-26fmq_unit_tests: remove objects form the heap am: cdf8d33b16 am: 6a21b5f737 ↵Devin Moore
am: 272fe1e1dd am: 8d0f459682 am: 70e18912d7 Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2230529 Change-Id: I1ebac6b37971d7b39e90bbe0b5fe879ad4f1dfbc Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26fmq_unit_tests: remove objects form the heap am: cdf8d33b16 am: 6a21b5f737 ↵Devin Moore
am: 272fe1e1dd am: 8d0f459682 Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2230529 Change-Id: I691242ca0f191ca627fd1415fd9422929dd539b5 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26fmq_unit_tests: remove objects form the heap am: cdf8d33b16 am: 6a21b5f737 ↵Devin Moore
am: 272fe1e1dd Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2230529 Change-Id: Iaea87395a3706b4b6d40f671a699d8df19546db9 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26fmq_unit_tests: remove objects form the heap am: cdf8d33b16 am: 6a21b5f737Devin Moore
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2230529 Change-Id: I86dcaa344f324b9883351b70f99f29f03f64e1cd Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26fmq_unit_tests: remove objects form the heap am: cdf8d33b16Devin Moore
Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2230529 Change-Id: Ice394c81034749b76ac101ddf9d0b5b4d654b432 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26Merge "Handle unexpected queue types consistently in destructor"Devin Moore
2022-09-23fmq_unit_tests: remove objects form the heapmain-16kDevin Moore
They don't need to be there and weren't being freed. Test: atest fmq_unit_tests Bug: None Change-Id: I36eb223602fc67951adbe8d6dcd179db2a01476e
2022-09-23Handle unexpected queue types consistently in destructorDevin Moore
If the queue type is some unexpected value, it is generally treated as UnsynchronizedWrite type. We need to treat it that way in the destructor so it frees/unmaps the mReadptr based on the way it was initialized. Either mapped in shared memory, or newly allocated per process. Test: atest fmq_unit_tests Bug: 244713396 Change-Id: I3678fed83daa8962c0ed996568ad7e9e63985dc1
2022-08-24[Bluetooth apex] Use new apex name am: aee39f3d83 am: 60b77d846e am: ↵William Escande
0a83b628c9 am: d9cf9d0bd7 am: dea1fea6ba Original change: https://android-review.googlesource.com/c/platform/system/libfmq/+/2192223 Change-Id: Id662c622b8ead338516fc6494f5586243f1ce306 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>