summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKiyoung Kim <kiyoungkim@google.com>2024-02-19 13:02:13 +0900
committerKiyoung Kim <kiyoungkim@google.com>2024-02-19 13:02:13 +0900
commitd58a10656a5cc6fc1d9fe50bbfbfd20401ef1471 (patch)
treed6bca0b79afa1199015dcc3fc1cad6aacce3ea58
parent9f24a721b209a4a031f9b9fc18718f025dca371e (diff)
downloadlibhidl-d58a10656a5cc6fc1d9fe50bbfbfd20401ef1471.tar.gz
BugFix: Always set PRIVATE_PROVIDED_VNDK_VERSIONS
Previous change tried to set PRIVATE_PROVIDED_VNDK_VERSIONS conditionally if it is not empty. However, defining PRIVATE_PROVIDED_VNDK_VERSIONS is part of build action, so it is not accessible with ifeq command. Also as this is env variable, build works even when it is empty. This change would again set PRIVATE_PROVIDED_VNDK_VERSIONS even if it is empty to cover any build errors with PRODUCT_EXTRA_VNDK_VERSIONS. Bug: 316829758 Test: AOSP CF build succeeded Test: AOSP Husky build succeeded Change-Id: Ie86996f15a928d048bfe983f4c94be5719ce02e7
-rw-r--r--vintfdata/Android.mk7
1 files changed, 0 insertions, 7 deletions
diff --git a/vintfdata/Android.mk b/vintfdata/Android.mk
index 6a5fe72..49e1733 100644
--- a/vintfdata/Android.mk
+++ b/vintfdata/Android.mk
@@ -147,18 +147,11 @@ $(GEN): PRIVATE_SYSTEM_EXT_MANIFEST_FILES := $(SYSTEM_EXT_MANIFEST_INPUT_FILES)
$(GEN): PRIVATE_PROVIDED_VNDK_VERSIONS := \
$(sort $(VINTF_VNDK_VERSION) $(PRODUCT_EXTRA_VNDK_VERSIONS))
-ifeq ($(PRIVATE_PROVIDED_VNDK_VERSIONS),)
-$(GEN): $(SYSTEM_EXT_MANIFEST_INPUT_FILES) $(HOST_OUT_EXECUTABLES)/assemble_vintf
- $(HOST_OUT_EXECUTABLES)/assemble_vintf \
- -i $(call normalize-path-list,$(PRIVATE_SYSTEM_EXT_MANIFEST_FILES)) \
- -o $@
-else
$(GEN): $(SYSTEM_EXT_MANIFEST_INPUT_FILES) $(HOST_OUT_EXECUTABLES)/assemble_vintf
PROVIDED_VNDK_VERSIONS="$(PRIVATE_PROVIDED_VNDK_VERSIONS)" \
$(HOST_OUT_EXECUTABLES)/assemble_vintf \
-i $(call normalize-path-list,$(PRIVATE_SYSTEM_EXT_MANIFEST_FILES)) \
-o $@
-endif
LOCAL_PREBUILT_MODULE_FILE := $(GEN)
include $(BUILD_PREBUILT)