Fix hidl_handle/hidl_memory ownership semantics.

hidl_handles that are constructed from a native_handle_t
object never own a handle, unless explicitly requested by
a call to setTo().

Copying a hidl_handle does clone the enclosed native_handle_t
and consequently takes ownership of it.

As a consequence, hidl_memory no longer needs to keep
track of handle ownership; the default constructors
don't take ownership of the passed in native_handle_t,
requiring callers to clean the handles up when it is
done with them. This makes sense because in most cases,
hidl_memory is a very transient object just used for
IPC.

Test: hidl_test, libhidl_test
Bug: 33812533
Change-Id: Idf26434c6a1dc541d4b909ac1523dbf92f214e1a

1 files changed, 2 insertions, 0 deletions

diff --git a/transport/memory/1.0/default/AshmemAllocator.cpp b/transport/memory/1.0/default/AshmemAllocator.cpp
index 59ae3e1..667c46e 100644
--- a/transport/memory/1.0/default/AshmemAllocator.cpp
+++ b/transport/memory/1.0/default/AshmemAllocator.cpp
@@ -37,6 +37,8 @@ Return<void> AshmemAllocator::allocate(uint64_t size, allocate_cb _hidl_cb) {
     hidl_memory memory("ashmem", handle, size);
 
     _hidl_cb(true /* success */, memory);
+    native_handle_close(handle);
+    native_handle_delete(handle);
     return Void();
 }