summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-07-01Snap for 7510676 from 8578d50d847b92c8de63d513ddf17557773a4751 to sc-release ↵android12-gsiAndroid Build Coastguard Worker
am: ef7cca7d56 Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/15165451 Change-Id: Ic67c24703405b13beb2f511a9266c273a2dc053d
2021-07-01Snap for 7510676 from 8578d50d847b92c8de63d513ddf17557773a4751 to sc-releaseandroid-vts-12.0_r9android-vts-12.0_r8android-vts-12.0_r7android-vts-12.0_r6android-vts-12.0_r5android-vts-12.0_r4android-vts-12.0_r3android-vts-12.0_r2android-vts-12.0_r12android-vts-12.0_r11android-vts-12.0_r10android-vts-12.0_r1android-security-12.0.0_r60android-security-12.0.0_r59android-security-12.0.0_r58android-security-12.0.0_r57android-security-12.0.0_r56android-security-12.0.0_r55android-security-12.0.0_r54android-security-12.0.0_r53android-security-12.0.0_r52android-security-12.0.0_r51android-security-12.0.0_r50android-security-12.0.0_r49android-security-12.0.0_r48android-security-12.0.0_r47android-security-12.0.0_r46android-security-12.0.0_r45android-security-12.0.0_r44android-security-12.0.0_r43android-security-12.0.0_r42android-security-12.0.0_r41android-security-12.0.0_r40android-security-12.0.0_r39android-security-12.0.0_r38android-security-12.0.0_r37android-security-12.0.0_r36android-security-12.0.0_r35android-security-12.0.0_r34android-platform-12.0.0_r9android-platform-12.0.0_r8android-platform-12.0.0_r7android-platform-12.0.0_r6android-platform-12.0.0_r5android-platform-12.0.0_r4android-platform-12.0.0_r31android-platform-12.0.0_r30android-platform-12.0.0_r3android-platform-12.0.0_r29android-platform-12.0.0_r28android-platform-12.0.0_r27android-platform-12.0.0_r26android-platform-12.0.0_r25android-platform-12.0.0_r24android-platform-12.0.0_r23android-platform-12.0.0_r22android-platform-12.0.0_r21android-platform-12.0.0_r20android-platform-12.0.0_r2android-platform-12.0.0_r19android-platform-12.0.0_r18android-platform-12.0.0_r17android-platform-12.0.0_r16android-platform-12.0.0_r15android-platform-12.0.0_r14android-platform-12.0.0_r13android-platform-12.0.0_r12android-platform-12.0.0_r11android-platform-12.0.0_r10android-platform-12.0.0_r1android-cts-12.0_r9android-cts-12.0_r8android-cts-12.0_r7android-cts-12.0_r6android-cts-12.0_r5android-cts-12.0_r4android-cts-12.0_r3android-cts-12.0_r2android-cts-12.0_r12android-cts-12.0_r11android-cts-12.0_r10android-cts-12.0_r1android-12.0.0_r9android-12.0.0_r8android-12.0.0_r34android-12.0.0_r33android-12.0.0_r31android-12.0.0_r30android-12.0.0_r3android-12.0.0_r25android-12.0.0_r2android-12.0.0_r11android-12.0.0_r10android-12.0.0_r1android12-tests-releaseandroid12-security-releaseandroid12-s5-releaseandroid12-s4-releaseandroid12-s3-releaseandroid12-s2-releaseandroid12-s1-releaseandroid12-releaseandroid12-platform-releaseAndroid Build Coastguard Worker
Change-Id: I0d3b3d5fe722075087c8c4d9b5a3f8ac598a4b45
2021-06-29HidlLazyUtils: avoid race w/ register & onClientsandroid-12.0.0_r32android-12.0.0_r29android-12.0.0_r28android-12.0.0_r27android-12.0.0_r26android-12.0.0_r21android-12.0.0_r20android-12.0.0_r19android-12.0.0_r18android-12.0.0_r16android12-qpr1-releaseandroid12-qpr1-d-s3-releaseandroid12-qpr1-d-s2-releaseandroid12-qpr1-d-s1-releaseandroid12-qpr1-d-releaseandroid12-devSteven Moreland
In HIDL, the threadpool is started whenever a binder object is sent to another process, so there is the rare race condition: - a process has a threadpool of size > 1 - it calls register service - when sending this service to hwservicemanager, under the hood, the threadpool is started (but it hasn't recorded internally that the service is registered) - another process gets ahold of the service - hwservicemanager tells the service it has a client - the service aborts, because it has no record of registering this service Bug: 191608065 Test: hidl_lazy_test Change-Id: Ia430352db4fb1345ba3e6633e3918b441af24fd7 Merged-In: Ia430352db4fb1345ba3e6633e3918b441af24fd7
2021-04-15Snap for 7283897 from 0445442a6aaa5215f3ec149ca1f7eae28f4c1303 to sc-release ↵android-build-team Robot
am: 6b96981b6f Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14191563 Change-Id: I1fdfaa4597198010df01ecec613268c4df08315f
2021-04-15Snap for 7283897 from 0445442a6aaa5215f3ec149ca1f7eae28f4c1303 to sc-releaseandroid-build-team Robot
Change-Id: Iebbabdd4bce1db343768daf8f457797c9242020d
2021-04-14[automerger skipped] Merge RQ2A.210405.006 to aosp-master - DO NOT MERGE am: ↵Bill Yi
8d76739a53 -s ours am: 67fcb65189 -s ours am: 077d6c34ac -s ours am skip reason: subject contains skip directive Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1675188 Change-Id: I80cde2b433d018b3e43496c6a1ccb5b1f3072d5b
2021-04-14[automerger skipped] Merge RQ2A.210405.006 to aosp-master - DO NOT MERGE am: ↵Bill Yi
8d76739a53 -s ours am: 67fcb65189 -s ours am skip reason: skip tag Change-Id Ia3a9dae55e766ef339a0d16bd5163f592765221a with SHA-1 5ef5916839 is already in history Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1675188 Change-Id: I9c5ca08032402059d04d3151d83dbc5b20e8aef0
2021-04-14[automerger skipped] Merge RQ2A.210405.006 to aosp-master - DO NOT MERGE am: ↵Bill Yi
8d76739a53 -s ours am skip reason: skip tag Change-Id Ia3a9dae55e766ef339a0d16bd5163f592765221a with SHA-1 5ef5916839 is already in history Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1675188 Change-Id: Ie54ddcb4f3471b57b135504e62624d962ce8f8e2
2021-04-13Merge RQ2A.210405.006 to aosp-master - DO NOT MERGEandroid-s-beta-2android-s-beta-1Bill Yi
Merged-In: Ia3a9dae55e766ef339a0d16bd5163f592765221a Merged-In: I42456e274166590d64fb721457700e8e50d36b1e Change-Id: I6c5b960dcf98849b2eaa9e5f0ee9870edae85670
2021-04-14[automerger skipped] Merge RQ2A.210405.006 to stage-aosp-master - DO NOT ↵Bill Yi
MERGE am: 5ef5916839 -s ours am: 57e6121438 -s ours am skip reason: subject contains skip directive Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14174233 Change-Id: Idc553bb4ea052c04a77419846d52d6f60de31fae
2021-04-14[automerger skipped] Merge RQ2A.210405.006 to stage-aosp-master - DO NOT ↵Bill Yi
MERGE am: 5ef5916839 -s ours am skip reason: skip tag Change-Id I435e34d50f469e0056eb23a71b1e8872f491e27f with SHA-1 1a8e6a75a4 is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14174233 Change-Id: I42456e274166590d64fb721457700e8e50d36b1e
2021-04-12Merge RQ2A.210405.006 to stage-aosp-master - DO NOT MERGEBill Yi
Merged-In: I435e34d50f469e0056eb23a71b1e8872f491e27f Change-Id: Ia3a9dae55e766ef339a0d16bd5163f592765221a
2021-04-10Snap for 7272808 from c7cce3d4e5045726d187a7eb17740af5fc04a196 to sc-release ↵android-build-team Robot
am: cc3d24f9d3 Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14148924 Change-Id: I4df67f9a85a1d194d107485b4ebdc7c8066cc816
2021-04-10Snap for 7272808 from c7cce3d4e5045726d187a7eb17740af5fc04a196 to sc-releaseandroid-build-team Robot
Change-Id: I88360f77ff9ae3843d6800335e2724a90e4306db
2021-04-09setTrebleTestingOverride: base on ro.debuggable am: f47cdf7bbb am: ↵Steven Moreland
2b592d4409 am: 1a8e6a75a4 Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1668626 Change-Id: Ic420a00981f2427b09d40efcb6b056a445b09185
2021-04-09setTrebleTestingOverride: base on ro.debuggable am: f47cdf7bbb am: 2b592d4409temp_ab_7272582Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1668626 Change-Id: I435e34d50f469e0056eb23a71b1e8872f491e27f
2021-04-09setTrebleTestingOverride: base on ro.debuggable am: f47cdf7bbbSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1668626 Change-Id: Ib286ae228d986f1ecc76269906244b2fd513c9a3
2021-04-07setTrebleTestingOverride: base on ro.debuggableSteven Moreland
This was previously based on the build, but this causes hidl_test, hidl_test_java, and fmq_test to fail on the GSI build. In order to avoid this problem, checking this property at runtime. Fixes: 184616522 Test: atest hidl_test hidl_test_java fmq_test Change-Id: Ifff473fa9530557bbb3fabc3fda1b25a05249f05
2021-03-30Snap for 7243396 from ee47ab21d540f11f6b5ff8abec8872b212429bf7 to sc-release ↵android-build-team Robot
am: 6e0d6b100b Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14022895 Change-Id: Ia410fe7e6335a2917d15fe9e74fa70ee43410765
2021-03-30Snap for 7243396 from ee47ab21d540f11f6b5ff8abec8872b212429bf7 to sc-releaseandroid-build-team Robot
Change-Id: I82d481a53fdc2599e397dfc760c43eb292076123
2021-03-29Merge "hidl_string: empty string opt always applies" am: 34fb6e1222 am: ↵Steven Moreland
2f35293174 am: 47b900270c Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656230 Change-Id: I77bfb1ad910b1774e6fca27daabb522e7d9ea424
2021-03-29clarify getRawServiceInternal 'retry' docs am: e5f8f7c02c am: ec1e232221 am: ↵Steven Moreland
70ecfbf092 Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656229 Change-Id: I77a45e3fecc2a80afc614a123378009f7116baf6
2021-03-29Merge "hidl_string: empty string opt always applies" am: 34fb6e1222 am: ↵Steven Moreland
2f35293174 Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656230 Change-Id: I68c091f0b4bc4248f22d2e71f0537763a6e5abd6
2021-03-29clarify getRawServiceInternal 'retry' docs am: e5f8f7c02c am: ec1e232221Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656229 Change-Id: I8dfdef7b2197d711f594ac967801f5a36732f251
2021-03-29Merge "hidl_string: empty string opt always applies" am: 34fb6e1222Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656230 Change-Id: I9f6aea65b86a849ce8e69e7dec2c436d28a96b74
2021-03-29clarify getRawServiceInternal 'retry' docs am: e5f8f7c02cSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656229 Change-Id: Ie5acec5527ff810e49697cfeb2167ba5c8865d86
2021-03-29Merge "hidl_string: empty string opt always applies"Steven Moreland
2021-03-29hidl_string: empty string opt always appliesSteven Moreland
Before, it only applied for the default constructor. However, there are many cases where we can avoid the extra allocation. The most important is when we allocate a hidl_memory object. Here, the empty string literal is passed to hidl_string, but we don't actually need an allocation. Bug: 179720143 Test: N/A Change-Id: I307305b88e8b8c54cb2e2759b60b7015a3ac82b9
2021-03-29clarify getRawServiceInternal 'retry' docsSteven Moreland
This will only retry for VINTF manifest services. Bug: 183154648 Test: N/A Change-Id: I9bdf2448ca8c4fe910c27539e0847156acb7bb6a
2021-02-26Snap for 7171598 from 5be905655a92a55c688fa06c73455b5cf94fb2b3 to sc-release ↵android-build-team Robot
am: 853730a769 Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/13704403 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Iaaf704c1425203a39a588ebde653bf0c8523e7c9
2021-02-26Snap for 7171598 from 5be905655a92a55c688fa06c73455b5cf94fb2b3 to sc-releaseandroid-build-team Robot
Change-Id: Ic95ec46392c8f63364ea1df3a141268340524d84
2021-02-24libhidlbase: PID is always sharable. am: 8b9e383583 am: 70260b5a12 am: ↵Steven Moreland
3a949737b6 Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1602501 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I08f527b0d7b964cb3bd2a480f4b4104a3dd0cec9
2021-02-24libhidlbase: PID is always sharable. am: 8b9e383583 am: 70260b5a12Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1602501 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I2ded502013c8ed7f51237771fdb213ece19eb56f
2021-02-24libhidlbase: PID is always sharable. am: 8b9e383583Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1602501 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I62e823d991913f207f5ca0748583a243cdc396cc
2021-02-24libhidlbase: PID is always sharable.Steven Moreland
This is useful for debugging, at parity with AIDL, and the information is already exposed via hwservicemanager. The client of audio HAL (audio server) needs to know the PID of it in order to adjust the priority of HAL threads (b/181148259). Bug: 180991044 Test: N/A Change-Id: I50803e60bb1d8ba8892e40be762162ef9c5ff7c1
2021-02-21Snap for 7160059 from 76f4ead2e2fb249f8a451715ff9ca634e21f2cc2 to sc-release ↵android-build-team Robot
am: 6a302547b8 Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/13647241 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I3c96ce9ad662048d17d5d956132f81b41255837c
2021-02-21Snap for 7160059 from 76f4ead2e2fb249f8a451715ff9ca634e21f2cc2 to sc-releaseandroid-build-team Robot
Change-Id: I0bcf8aee7b3d3fa1a27c54c7cad259725d135db7
2021-02-20[automerger skipped] Mark ab/7061308 as merged in stage. am: 8b52af87ca -s ↵Xin Li
ours am: 7f8b7ace57 -s ours am skip reason: Change-Id I6ddf4f417f3f0a994077f0a8140bffd2baafe0aa with SHA-1 85ec5c0516 is in history Original change: undetermined MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ifd123bf1eb95435c8f10d3b49822fc9c1a17935f
2021-02-20[automerger skipped] Mark ab/7061308 as merged in stage. am: 8b52af87ca -s oursXin Li
am skip reason: Change-Id I6ddf4f417f3f0a994077f0a8140bffd2baafe0aa with SHA-1 85ec5c0516 is in history Original change: undetermined MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I7fc18f8971cfbaac6b91cc68dc0d5cfe1c889e45
2021-02-20Mark ab/7061308 as merged in stage.Xin Li
Bug: 180401296 Merged-In: I6ddf4f417f3f0a994077f0a8140bffd2baafe0aa Change-Id: I028d0c5b7c0855385c34245d2ae4ad608e20de45
2021-02-19Snap for 7155190 from 0b3cd0401042f30b9b11a3d01377d764ffa627b4 to sc-release ↵android-build-team Robot
am: 89df9ddc07 Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/13622864 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ib8a9d23164af13b44273f494bd32fa6534047cd6
2021-02-19Snap for 7155190 from 0b3cd0401042f30b9b11a3d01377d764ffa627b4 to sc-releaseandroid-build-team Robot
Change-Id: I58786486f6b7247e6faa1f9b56a2e34a7da2663a
2021-02-18libhidlbase: avoid dlclose am: edd49128bc am: 6785dc4b99 am: a2680e6287Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1592996 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ia122fcc72cb58a1ce29dacd352cacf6a39861aa9
2021-02-18libhidlbase: avoid dlclose am: edd49128bc am: 6785dc4b99Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1592996 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I8edbe4820d299d8013cac69b6c96f12047d2427a
2021-02-18libhidlbase: avoid dlclose am: edd49128bcSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1592996 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I4d23e19613633cc473b8dda746362a8a7d9db3e3
2021-02-17libhidlbase: avoid dlcloseSteven Moreland
HIDL passthrough has a fatal design flaw! It's not known which implementation library serves which instance name. dlclose is extremely problematic: - some symbols (e.g. like [[clang::no_destroy]] or equiv) may be leaked. - binder, given multithreaded environment, might have other threads using this data - binder, may send ownership of some of this data out of process So, proactively removing dlclose here. As a side effect, this may mean we are keeping extra libraries open when they were closed before. Though, note: a. ephemeral dlopen/dlclose is a mostly silent cost which is now visible b. dlopen/dlclose will definitely be leaking memory c. for passthrough HALs used by system, only one instance is supported, so we shouldn't have this problem d. passthrough HALs are used as implementation detail for vendors, but: i. (a)/(b) still apply here ii. most vendor HALs are direct implemenations now (not passthrough). If this turns out to take more memory on some devices, we can prefer to improve HIDL's passthrough infrastructure to know which library it needs to open for which implementation. This would improve device performance over the existing baseline. Fixes: 180501607 Test: N/A Change-Id: I8555ce46b497be4df9d02490bbbe78dbf3255d32
2021-02-16Snap for 7146909 from d85f2c9bdcf7d0e6b0355d81eb7a8858bb20fac6 to sc-release ↵android-build-team Robot
am: 71aed5a8ff Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/13576346 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I1451f12adfa7b3c5174138108d14d19cf37ac908
2021-02-16Snap for 7146909 from d85f2c9bdcf7d0e6b0355d81eb7a8858bb20fac6 to sc-releaseandroid-build-team Robot
Change-Id: I579eca8aa78f1995b7cdff41b50942abc582780f
2021-02-16[LSC] Add LOCAL_LICENSE_KINDS to system/libhidl am: ad2415c261 am: ↵Bob Badour
d49bfa9bc6 am: 4c5963579d Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1589043 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: If423cfbc201577ca0b2142c416524f22c044615e
2021-02-16[LSC] Add LOCAL_LICENSE_KINDS to system/libhidl am: ad2415c261 am: d49bfa9bc6Bob Badour
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1589043 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I23678ad1b50dc4da5ec9b54f07a40e9ebc5f6f9d