Age | Commit message (Collapse) | Author |
|
In HIDL, the threadpool is started whenever a binder object is sent to
another process, so there is the rare race condition:
- a process has a threadpool of size > 1
- it calls register service
- when sending this service to hwservicemanager, under the hood, the
threadpool is started (but it hasn't recorded internally that the
service is registered)
- another process gets ahold of the service
- hwservicemanager tells the service it has a client
- the service aborts, because it has no record of registering this
service
Bug: 191608065
Test: hidl_lazy_test
Change-Id: Ia430352db4fb1345ba3e6633e3918b441af24fd7
Merged-In: Ia430352db4fb1345ba3e6633e3918b441af24fd7
|
|
8d76739a53 -s ours am: 67fcb65189 -s ours am: 077d6c34ac -s ours
am skip reason: subject contains skip directive
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1675188
Change-Id: I80cde2b433d018b3e43496c6a1ccb5b1f3072d5b
|
|
8d76739a53 -s ours am: 67fcb65189 -s ours
am skip reason: skip tag Change-Id Ia3a9dae55e766ef339a0d16bd5163f592765221a with SHA-1 5ef5916839 is already in history
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1675188
Change-Id: I9c5ca08032402059d04d3151d83dbc5b20e8aef0
|
|
8d76739a53 -s ours
am skip reason: skip tag Change-Id Ia3a9dae55e766ef339a0d16bd5163f592765221a with SHA-1 5ef5916839 is already in history
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1675188
Change-Id: Ie54ddcb4f3471b57b135504e62624d962ce8f8e2
|
|
Merged-In: Ia3a9dae55e766ef339a0d16bd5163f592765221a
Merged-In: I42456e274166590d64fb721457700e8e50d36b1e
Change-Id: I6c5b960dcf98849b2eaa9e5f0ee9870edae85670
|
|
MERGE am: 5ef5916839 -s ours am: 57e6121438 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14174233
Change-Id: Idc553bb4ea052c04a77419846d52d6f60de31fae
|
|
MERGE am: 5ef5916839 -s ours
am skip reason: skip tag Change-Id I435e34d50f469e0056eb23a71b1e8872f491e27f with SHA-1 1a8e6a75a4 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/14174233
Change-Id: I42456e274166590d64fb721457700e8e50d36b1e
|
|
Merged-In: I435e34d50f469e0056eb23a71b1e8872f491e27f
Change-Id: Ia3a9dae55e766ef339a0d16bd5163f592765221a
|
|
2b592d4409 am: 1a8e6a75a4
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1668626
Change-Id: Ic420a00981f2427b09d40efcb6b056a445b09185
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1668626
Change-Id: I435e34d50f469e0056eb23a71b1e8872f491e27f
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1668626
Change-Id: Ib286ae228d986f1ecc76269906244b2fd513c9a3
|
|
This was previously based on the build, but this causes hidl_test,
hidl_test_java, and fmq_test to fail on the GSI build. In order to avoid
this problem, checking this property at runtime.
Fixes: 184616522
Test: atest hidl_test hidl_test_java fmq_test
Change-Id: Ifff473fa9530557bbb3fabc3fda1b25a05249f05
|
|
2f35293174 am: 47b900270c
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656230
Change-Id: I77bfb1ad910b1774e6fca27daabb522e7d9ea424
|
|
70ecfbf092
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656229
Change-Id: I77a45e3fecc2a80afc614a123378009f7116baf6
|
|
2f35293174
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656230
Change-Id: I68c091f0b4bc4248f22d2e71f0537763a6e5abd6
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656229
Change-Id: I8dfdef7b2197d711f594ac967801f5a36732f251
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656230
Change-Id: I9f6aea65b86a849ce8e69e7dec2c436d28a96b74
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1656229
Change-Id: Ie5acec5527ff810e49697cfeb2167ba5c8865d86
|
|
|
|
Before, it only applied for the default constructor. However, there are
many cases where we can avoid the extra allocation. The most important
is when we allocate a hidl_memory object. Here, the empty string literal
is passed to hidl_string, but we don't actually need an allocation.
Bug: 179720143
Test: N/A
Change-Id: I307305b88e8b8c54cb2e2759b60b7015a3ac82b9
|
|
This will only retry for VINTF manifest services.
Bug: 183154648
Test: N/A
Change-Id: I9bdf2448ca8c4fe910c27539e0847156acb7bb6a
|
|
3a949737b6
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1602501
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I08f527b0d7b964cb3bd2a480f4b4104a3dd0cec9
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1602501
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I2ded502013c8ed7f51237771fdb213ece19eb56f
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1602501
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I62e823d991913f207f5ca0748583a243cdc396cc
|
|
This is useful for debugging, at parity with AIDL, and the information
is already exposed via hwservicemanager.
The client of audio HAL (audio server) needs to know the PID
of it in order to adjust the priority of HAL threads (b/181148259).
Bug: 180991044
Test: N/A
Change-Id: I50803e60bb1d8ba8892e40be762162ef9c5ff7c1
|
|
ours am: 7f8b7ace57 -s ours
am skip reason: Change-Id I6ddf4f417f3f0a994077f0a8140bffd2baafe0aa with SHA-1 85ec5c0516 is in history
Original change: undetermined
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ifd123bf1eb95435c8f10d3b49822fc9c1a17935f
|
|
am skip reason: Change-Id I6ddf4f417f3f0a994077f0a8140bffd2baafe0aa with SHA-1 85ec5c0516 is in history
Original change: undetermined
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I7fc18f8971cfbaac6b91cc68dc0d5cfe1c889e45
|
|
Bug: 180401296
Merged-In: I6ddf4f417f3f0a994077f0a8140bffd2baafe0aa
Change-Id: I028d0c5b7c0855385c34245d2ae4ad608e20de45
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1592996
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ia122fcc72cb58a1ce29dacd352cacf6a39861aa9
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1592996
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I8edbe4820d299d8013cac69b6c96f12047d2427a
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1592996
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I4d23e19613633cc473b8dda746362a8a7d9db3e3
|
|
HIDL passthrough has a fatal design flaw! It's not known which
implementation library serves which instance name.
dlclose is extremely problematic:
- some symbols (e.g. like [[clang::no_destroy]] or equiv) may be leaked.
- binder, given multithreaded environment, might have other threads
using this data
- binder, may send ownership of some of this data out of process
So, proactively removing dlclose here.
As a side effect, this may mean we are keeping extra libraries open when
they were closed before. Though, note:
a. ephemeral dlopen/dlclose is a mostly silent cost which is now visible
b. dlopen/dlclose will definitely be leaking memory
c. for passthrough HALs used by system, only one instance is supported,
so we shouldn't have this problem
d. passthrough HALs are used as implementation detail for vendors, but:
i. (a)/(b) still apply here
ii. most vendor HALs are direct implemenations now (not passthrough).
If this turns out to take more memory on some devices, we can prefer to
improve HIDL's passthrough infrastructure to know which library it needs
to open for which implementation. This would improve device performance
over the existing baseline.
Fixes: 180501607
Test: N/A
Change-Id: I8555ce46b497be4df9d02490bbbe78dbf3255d32
|
|
d49bfa9bc6 am: 4c5963579d
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1589043
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: If423cfbc201577ca0b2142c416524f22c044615e
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1589043
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I23678ad1b50dc4da5ec9b54f07a40e9ebc5f6f9d
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1589043
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ic0db761c0cc176bcb531716a6a46d1f21cb5af36
|
|
Added SPDX-license-identifier-Apache-2.0 to:
Android.bp
adapter/Android.bp
libhidlmemory/Android.bp
minijail/Android.bp
transport/Android.bp
transport/allocator/1.0/Android.bp
transport/allocator/1.0/default/Android.bp
transport/allocator/1.0/utils/Android.bp
transport/allocator/1.0/vts/functional/Android.bp
transport/base/1.0/Android.bp
transport/base/1.0/vts/functional/Android.bp
transport/manager/1.0/Android.bp
transport/manager/1.1/Android.bp
transport/manager/1.2/Android.bp
transport/memory/1.0/Android.bp
transport/memory/1.0/default/Android.bp
transport/memory/block/1.0/Android.bp
transport/memory/token/1.0/Android.bp
transport/safe_union/1.0/Android.bp
transport/token/1.0/Android.bp
transport/token/1.0/utils/Android.bp
vintfdata/Android.mk
Bug: 68860345
Bug: 151177513
Bug: 151953481
Test: m all
Exempt-From-Owner-Approval: janitorial work
Change-Id: I2a7ef0ec44c7b087eb00ed2bdfc4940d07f7a148
|
|
13533871, 13534991, 13533562, 13532553, 13533872, 13534992, 13532554, 13535065, 13535085, 13535105, 13535125, 13535126, 13535106, 13535107, 13535086] into rvc-qpr2-release
Change-Id: I02599dc44549485b81711b20edff8e13b1b927e0
|
|
A certain system crash has pointed to this at least 77K times, and it's
not important.
Bug: 173264759
Test: boot
Change-Id: Ice3dddee6d62c443d3fd88e1082e5af7a58b4255
Merged-In: Ice3dddee6d62c443d3fd88e1082e5af7a58b4255
(cherry picked from commit 8ea10819ca6a3333f488fdfdf2e8eef5cc3ac3cf)
|
|
There function is jumping to abort on specific boots in two processes
on the device repeatedly. Most likely, it is failing because of ubsan,
but it isn't clear where exactly it is failing, so checking all
assumptions and dumping errors.
Bug: 170456142
Bug: 173264759
Test: adb logcat *:E | grep HidlServiceManagement # no errors on ToT
Test: adb logcat | grep HidlServiceManagement # see registration logs
Merged-In: Ib5c390dd93a9e4f78b42e7172cff74603a89f6cf
Change-Id: Ib5c390dd93a9e4f78b42e7172cff74603a89f6cf
(cherry picked from commit adee24d077f082bc8e946e1cd81a2c3830570c56)
|
|
am: bf8445ce7a
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1558666
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ic1009d0607e34c016e5ae7d256e20f3cd298b783
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1558666
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ia28c9a7c52236b62711bf40b6f7c820989948c69
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1558666
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Id609874274c9833ac676f12b7d524517b5f95b85
|
|
|
|
Avoid stopping the compiler.
Fixes: 178056347
Test: build only
Change-Id: Icdd0e0002c60774fea07452c06a58a3bed0fb236
|
|
8d99411d54
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1557027
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I9b3ebc88eb0f279ba4bef2e254ba5fad526f81a2
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1557027
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ibb2fe7b38b68d9847ae9462110f7e1d56647a6b0
|
|
d081c12130 -s ours
am skip reason: Change-Id Ice3dddee6d62c443d3fd88e1082e5af7a58b4255 with SHA-1 489e7571db is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/13382330
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I038fec434b96d3ff84b3b62597a09987c6c4f4a6
|
|
Original change: https://android-review.googlesource.com/c/platform/system/libhidl/+/1557027
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I9b42aa336514513c1b7e8c737087caa4e191a851
|
|
am skip reason: Change-Id Ice3dddee6d62c443d3fd88e1082e5af7a58b4255 with SHA-1 489e7571db is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/libhidl/+/13382330
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ic69fba849da738a6c802ca1c5486585e89c3ed49
|
|
|