From 2fcf57e9fd260db88c8abfa014eab775b86db76b Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Sat, 15 Jan 2022 01:13:01 +0000 Subject: libhwbinder_benchmark -= 1 race The comments here were wrong. I*::getService only waits for HIDL services which are declared in the VINTF manifest. This test usually passed before because testing the passthrough service gave enough time for the server to start. Fixes: 206700689 Test: atest libhwbinder_benchmark Change-Id: Ibaac31fde82d6cbd2c03aac362fd26ba48f9165f --- vts/performance/Benchmark.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vts/performance/Benchmark.cpp b/vts/performance/Benchmark.cpp index f995ec7..87185f5 100644 --- a/vts/performance/Benchmark.cpp +++ b/vts/performance/Benchmark.cpp @@ -82,7 +82,6 @@ static void BM_sendVec(benchmark::State& state, sp service) { } static void BM_sendVec_passthrough(benchmark::State& state) { - // getService automatically retries sp service = IBenchmark::getService(gServiceName, true /* getStub */); if (service == nullptr) { state.SkipWithError("Failed to retrieve benchmark service."); @@ -94,7 +93,7 @@ static void BM_sendVec_passthrough(benchmark::State& state) { } static void BM_sendVec_binderize(benchmark::State& state) { - // getService automatically retries + android::hardware::details::waitForHwService(IBenchmark::descriptor, gServiceName); sp service = IBenchmark::getService(gServiceName); if (service == nullptr) { state.SkipWithError("Failed to retrieve benchmark service."); -- cgit v1.2.3