From 566d53185653d38c1da4a6943c0bde542b86080a Mon Sep 17 00:00:00 2001 From: Yi Kong Date: Fri, 13 Jan 2023 15:14:00 +0900 Subject: Fix misc-use-anonymous-namespace warning system/netd/tests/benchmarks/bpf_benchmark.cpp:77:1: error: variable '_benchmark_2BpfBenchMark_MapUpdateEntry_Benchmark' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors] BENCHMARK_REGISTER_F(BpfBenchMark, MapUpdateEntry)->Arg(1); ^ external/google-benchmark/include/benchmark/benchmark.h:1252:3: note: expanded from macro 'BENCHMARK_REGISTER_F' BENCHMARK_PRIVATE_REGISTER_F(BENCHMARK_PRIVATE_CONCAT_NAME(BaseClass, Method)) ^ external/google-benchmark/include/benchmark/benchmark.h:1255:3: note: expanded from macro 'BENCHMARK_PRIVATE_REGISTER_F' BENCHMARK_PRIVATE_DECLARE(TestName) = \ ^ external/google-benchmark/include/benchmark/benchmark.h:1114:44: note: expanded from macro 'BENCHMARK_PRIVATE_DECLARE' static ::benchmark::internal::Benchmark* BENCHMARK_PRIVATE_NAME(n) \ ^ Test: presubmit Bug: 264965700 Change-Id: I2b5c13f1f2a530a0d0fa0cb874f1864733abccec --- tests/benchmarks/bpf_benchmark.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/benchmarks/bpf_benchmark.cpp b/tests/benchmarks/bpf_benchmark.cpp index 4614142f..4ceefca3 100644 --- a/tests/benchmarks/bpf_benchmark.cpp +++ b/tests/benchmarks/bpf_benchmark.cpp @@ -74,8 +74,11 @@ BENCHMARK_DEFINE_F(BpfBenchMark, WaitForRcu)(benchmark::State& state) { } } +namespace { BENCHMARK_REGISTER_F(BpfBenchMark, MapUpdateEntry)->Arg(1); BENCHMARK_REGISTER_F(BpfBenchMark, MapWriteNewEntry)->Arg(1); BENCHMARK_REGISTER_F(BpfBenchMark, MapDeleteAddEntry)->Arg(1); BENCHMARK_REGISTER_F(BpfBenchMark, WaitForRcu)->Arg(1); +} // namespace + BENCHMARK_MAIN(); -- cgit v1.2.3