summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2019-03-13 23:49:29 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2019-03-13 23:49:29 +0000
commit2cd64544e03c4699e952fa9a51c64aae6ceeb3a4 (patch)
tree2d4e7acc3696ccc7017a97302983ef65975cb8e8
parenteb7b084d60f228a06991cf53aa0352fcde2ca867 (diff)
parent61aea5137541f228cc8e5e5ba771d83ed44db002 (diff)
downloadsecurity-2cd64544e03c4699e952fa9a51c64aae6ceeb3a4.tar.gz
Merge "keystore_backend_binder: fix misinterpretation of getKeyCharacteristics return value."
-rw-r--r--keystore-engine/keystore_backend_binder.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/keystore-engine/keystore_backend_binder.cpp b/keystore-engine/keystore_backend_binder.cpp
index 590f005f..9a7c63ef 100644
--- a/keystore-engine/keystore_backend_binder.cpp
+++ b/keystore-engine/keystore_backend_binder.cpp
@@ -114,14 +114,14 @@ int32_t KeystoreBackendBinder::sign(const char* key_id, const uint8_t* in, size_
LOG(ERROR) << AT << "communication error while calling keystore";
return -1;
}
- if (KSReturn(error_code).isOk()) {
+ if (!KSReturn(error_code).isOk()) {
LOG(ERROR) << AT << "getKeyCharacteristics failed: " << error_code;
return -1;
}
auto [km_response, characteristics] = kc_future.get();
- if (KSReturn(km_response.response_code()).isOk()) {
+ if (!KSReturn(km_response.response_code()).isOk()) {
LOG(ERROR) << AT << "getKeyCharacteristics failed: " << km_response.response_code();
return -1;
}