summaryrefslogtreecommitdiff
path: root/identity
diff options
context:
space:
mode:
authorDavid Zeuthen <zeuthen@google.com>2021-03-31 10:41:27 -0400
committerDavid Zeuthen <zeuthen@google.com>2021-03-31 10:46:42 -0400
commit62d43bf7cbe63c3c22544523cf584c31bcfbb81a (patch)
tree624c84fd48b64519a6e97d7c2e55cb0e5e1696e3 /identity
parent6eda4846ec000e8395c7ee929b3cf1501483376a (diff)
downloadsecurity-62d43bf7cbe63c3c22544523cf584c31bcfbb81a.tar.gz
identity: Use "credstore" for LOG_TAG everywhere.
Currently we're using file-specific tags which makes it hard for people looking at logcat to infer it's actually from credstore and it also complicates filtering. Just use "credstore" everywhere. Also change logging level from ERROR to INFO in the message "Registered binder service" which is logged on startup. Bug: None Test: Compiles + manual inspection via logcat Test: atest android.security.identity.cts (on goldfish) Change-Id: I336d1a4e4e10b87fd3f08a5046cf5e13f09c9cb6
Diffstat (limited to 'identity')
-rw-r--r--identity/Credential.cpp2
-rw-r--r--identity/CredentialData.cpp2
-rw-r--r--identity/CredentialStore.cpp2
-rw-r--r--identity/CredentialStoreFactory.cpp2
-rw-r--r--identity/Util.cpp2
-rw-r--r--identity/WritableCredential.cpp2
-rw-r--r--identity/main.cpp4
7 files changed, 8 insertions, 8 deletions
diff --git a/identity/Credential.cpp b/identity/Credential.cpp
index 2e6b9c16..7c75d8a2 100644
--- a/identity/Credential.cpp
+++ b/identity/Credential.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "Credential"
+#define LOG_TAG "credstore"
#include <android-base/logging.h>
#include <android/binder_manager.h>
diff --git a/identity/CredentialData.cpp b/identity/CredentialData.cpp
index 96c436a8..d95c1ace 100644
--- a/identity/CredentialData.cpp
+++ b/identity/CredentialData.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "CredentialData"
+#define LOG_TAG "credstore"
#include <chrono>
diff --git a/identity/CredentialStore.cpp b/identity/CredentialStore.cpp
index 509e022c..071cf247 100644
--- a/identity/CredentialStore.cpp
+++ b/identity/CredentialStore.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "CredentialStore"
+#define LOG_TAG "credstore"
#include <algorithm>
diff --git a/identity/CredentialStoreFactory.cpp b/identity/CredentialStoreFactory.cpp
index 5c3bf36c..0e901ba5 100644
--- a/identity/CredentialStoreFactory.cpp
+++ b/identity/CredentialStoreFactory.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "CredentialStoreFactory"
+#define LOG_TAG "credstore"
#include <android-base/logging.h>
diff --git a/identity/Util.cpp b/identity/Util.cpp
index cd290178..3a46bca4 100644
--- a/identity/Util.cpp
+++ b/identity/Util.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "Util"
+#define LOG_TAG "credstore"
#include <fcntl.h>
#include <stdlib.h>
diff --git a/identity/WritableCredential.cpp b/identity/WritableCredential.cpp
index a300e514..9827d754 100644
--- a/identity/WritableCredential.cpp
+++ b/identity/WritableCredential.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "WritableCredential"
+#define LOG_TAG "credstore"
#include <android-base/logging.h>
#include <android/hardware/identity/support/IdentityCredentialSupport.h>
diff --git a/identity/main.cpp b/identity/main.cpp
index 9add73ca..25597898 100644
--- a/identity/main.cpp
+++ b/identity/main.cpp
@@ -14,7 +14,7 @@
* limitations under the License.
*/
-#define LOG_TAG "android.security.identity"
+#define LOG_TAG "credstore"
#include <filesystem>
@@ -51,7 +51,7 @@ int main(int argc, char* argv[]) {
auto ret = sm->addService(String16("android.security.identity"), factory);
CHECK(ret == ::android::OK) << "Couldn't register binder service";
- LOG(ERROR) << "Registered binder service";
+ LOG(INFO) << "Registered binder service";
// Credstore is a single-threaded process. So devote the main thread
// to handling binder messages.