From 4d23482d7ed3395872c7cae5549a831e56f5f1b3 Mon Sep 17 00:00:00 2001 From: Stephen Hines Date: Fri, 9 Feb 2024 15:39:25 -0800 Subject: Prefer `.first()` to `.get(0)` ``` error: accessing first element with `key_descriptors.get(0)` --> system/security/keystore2/tests/keystore2_client_list_entries_tests.rs:143:27 | 143 | let key = key_descriptors.get(0).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `key_descriptors.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-D clippy::get-first` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::get_first)]` ``` Bug: http://b/321303117 Test: toolchain/android_rust/test_compiler.py --prebuilt-path dist/rust-dev.tar.xz --target aosp_cf_x86_64_phone --all-rust Change-Id: Ic278ca9ec8fc48e779741f43b1fd53702b54396f --- keystore2/tests/keystore2_client_list_entries_tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keystore2/tests/keystore2_client_list_entries_tests.rs b/keystore2/tests/keystore2_client_list_entries_tests.rs index 1c0c4961..8b3f7001 100644 --- a/keystore2/tests/keystore2_client_list_entries_tests.rs +++ b/keystore2/tests/keystore2_client_list_entries_tests.rs @@ -140,7 +140,7 @@ fn keystore2_list_entries_success() { let key_descriptors = keystore2.listEntries(Domain::APP, -1).unwrap(); assert_eq!(1, key_descriptors.len()); - let key = key_descriptors.get(0).unwrap(); + let key = key_descriptors.first().unwrap(); assert_eq!(key.alias, Some(alias)); assert_eq!(key.nspace, GRANTEE_UID.try_into().unwrap()); assert_eq!(key.domain, Domain::APP); -- cgit v1.2.3