diff options
author | Steven Moreland <smoreland@google.com> | 2023-03-31 23:30:38 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2023-03-31 23:30:38 +0000 |
commit | 07ce4b0ee668140ccc64d0012cd59cb6557db1ff (patch) | |
tree | 88b77447d5c63a088eae5cedd9bc3534669f6cee | |
parent | 66d45754571647230ba658494491d01d9fce359d (diff) | |
parent | 00acfb344addc59e610f4de01667059cac6835fb (diff) | |
download | aidl-07ce4b0ee668140ccc64d0012cd59cb6557db1ff.tar.gz |
Clarify VINTF stability error. am: e460aa358c am: 8c047c373d am: d685cb82f3 am: 00acfb344a
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2517675
Change-Id: I587856080d78889b7f16c700b9fc6608bf731a1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r-- | aidl.cpp | 3 | ||||
-rw-r--r-- | aidl_unittest.cpp | 8 |
2 files changed, 7 insertions, 4 deletions
@@ -641,7 +641,8 @@ AidlError load_and_validate_aidl(const std::string& input_file_name, const Optio !isStable) { err = AidlError::NOT_STRUCTURED; AIDL_ERROR(type) << type.GetCanonicalName() - << " does not have VINTF level stability, but this interface requires it in " + << " does not have VINTF level stability (marked @VintfStability), but this " + "interface requires it in " << to_string(options.TargetLanguage()); } diff --git a/aidl_unittest.cpp b/aidl_unittest.cpp index 41a20829..2d401143 100644 --- a/aidl_unittest.cpp +++ b/aidl_unittest.cpp @@ -476,7 +476,8 @@ TEST_P(AidlTest, VintfStabilityAppliesToNestedTypesAsWell) { CaptureStderr(); EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage(), nullptr, {"--structured", "--stability", "vintf"})); - EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo does not have VINTF level stability")); + EXPECT_THAT(GetCapturedStderr(), + HasSubstr("Foo does not have VINTF level stability (marked @VintfStability)")); } TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) { @@ -547,8 +548,9 @@ TEST_P(AidlTest, NdkAndJavaStabilityIsVintfStable) { EXPECT_EQ(GetCapturedStderr(), ""); } else { EXPECT_EQ(result, nullptr); - EXPECT_THAT(GetCapturedStderr(), - HasSubstr("NonPortableThing does not have VINTF level stability")); + EXPECT_THAT( + GetCapturedStderr(), + HasSubstr("NonPortableThing does not have VINTF level stability (marked @VintfStability)")); } } |