aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteven Moreland <smoreland@google.com>2023-03-31 21:56:20 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2023-03-31 21:56:20 +0000
commit8c047c373d2913c7cdd53cda3ac2042ca95db76a (patch)
tree88b77447d5c63a088eae5cedd9bc3534669f6cee
parent7160254ee070e19af5daa9c2b6faabaac15caab9 (diff)
parente460aa358cf40a95e8da7d873c4f11f69fe15d1d (diff)
downloadaidl-8c047c373d2913c7cdd53cda3ac2042ca95db76a.tar.gz
Clarify VINTF stability error. am: e460aa358c
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2517675 Change-Id: Ib1af6a60bf4e0f5c0189247ae2255166b0b2bbb5 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--aidl.cpp3
-rw-r--r--aidl_unittest.cpp8
2 files changed, 7 insertions, 4 deletions
diff --git a/aidl.cpp b/aidl.cpp
index 038a11b0..3b6f2ee8 100644
--- a/aidl.cpp
+++ b/aidl.cpp
@@ -641,7 +641,8 @@ AidlError load_and_validate_aidl(const std::string& input_file_name, const Optio
!isStable) {
err = AidlError::NOT_STRUCTURED;
AIDL_ERROR(type) << type.GetCanonicalName()
- << " does not have VINTF level stability, but this interface requires it in "
+ << " does not have VINTF level stability (marked @VintfStability), but this "
+ "interface requires it in "
<< to_string(options.TargetLanguage());
}
diff --git a/aidl_unittest.cpp b/aidl_unittest.cpp
index 41a20829..2d401143 100644
--- a/aidl_unittest.cpp
+++ b/aidl_unittest.cpp
@@ -476,7 +476,8 @@ TEST_P(AidlTest, VintfStabilityAppliesToNestedTypesAsWell) {
CaptureStderr();
EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage(), nullptr,
{"--structured", "--stability", "vintf"}));
- EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo does not have VINTF level stability"));
+ EXPECT_THAT(GetCapturedStderr(),
+ HasSubstr("Foo does not have VINTF level stability (marked @VintfStability)"));
}
TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
@@ -547,8 +548,9 @@ TEST_P(AidlTest, NdkAndJavaStabilityIsVintfStable) {
EXPECT_EQ(GetCapturedStderr(), "");
} else {
EXPECT_EQ(result, nullptr);
- EXPECT_THAT(GetCapturedStderr(),
- HasSubstr("NonPortableThing does not have VINTF level stability"));
+ EXPECT_THAT(
+ GetCapturedStderr(),
+ HasSubstr("NonPortableThing does not have VINTF level stability (marked @VintfStability)"));
}
}