diff options
| author | Steven Moreland <smoreland@google.com> | 2018-03-19 15:20:06 -0700 |
|---|---|---|
| committer | Steven Moreland <smoreland@google.com> | 2018-03-19 15:20:06 -0700 |
| commit | feec3aa82e418c216c166a8ab0ac5aafcb157e8c (patch) | |
| tree | 9aeab269ccfb72296d9c90cd3196003be3d84675 /generateCppAdapter.cpp | |
| parent | 51b02f42c076d73e0167c17e9189fb693d2e8330 (diff) | |
| download | hidl-feec3aa82e418c216c166a8ab0ac5aafcb157e8c.tar.gz | |
Remove hypothetical TODO from adapter.
Since recommendation is against doing this in
interfaces, waiting for a real case to be hit
before fixing.
Bug: 66900959
Test: N/A
Change-Id: I5cbfd82344cceaa9662932f36a558bd5cfd0db93
Diffstat (limited to 'generateCppAdapter.cpp')
| -rw-r--r-- | generateCppAdapter.cpp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/generateCppAdapter.cpp b/generateCppAdapter.cpp index 1fbfb57e..a83e9f3c 100644 --- a/generateCppAdapter.cpp +++ b/generateCppAdapter.cpp @@ -128,13 +128,6 @@ void AST::generateAdapterMethod(Formatter& out, const Method* method) const { return; } - // TODO(b/66900959): if we are creating the adapter for a 1.1 IFoo - // and we are using a method that takes/returns a 1.0 Callback, but - // there exists a 1.1 Callback (or other subclass that is depended - // on by this module), then wrap with the adapter subclass adapter - // IFF that callback is a subclass. However, if the callback - // is 1.0 ICallback, then wrap with a 1.0 adapter. - const Interface* interface = static_cast<const Interface*>(type); out << "static_cast<::android::sp<" << interface->fqName().cppName() << ">>(" << interface->fqName().cppName() << "::castFrom(" |